Skip to content

Commit 5363345

Browse files
oberstetoberstet
committed
Replace actions/*-artifact@v4 with verified actions
- Replace all actions/upload-artifact@v4 with wamp-proto/wamp-cicd/ actions/upload-artifact-verified@main - Replace all actions/download-artifact@v4 with wamp-proto/wamp-cicd/ actions/download-artifact-verified@main - Expand pattern-based downloads to explicit enumerated downloads (cpy314, cpy311, pypy311) since verified actions don't support patterns - Update main.yml (5 uploads), wstest.yml (7 uploads, 6 downloads), release.yml (14 downloads each for PyPI and TestPyPI jobs), release-post-comment.yml (2 downloads) This eliminates all usage of actions/upload-artifact@v4 and actions/download-artifact@v4, using only the verified wamp-cicd actions for artifact handling with checksum verification. Note: When the Python matrix changes (cpy314, cpy311, pypy311), the explicit download steps must be updated accordingly. Note: This work was completed with AI assistance (Claude Code).
1 parent 83d985d commit 5363345

File tree

4 files changed

+148
-59
lines changed

4 files changed

+148
-59
lines changed

‎.github/workflows/main.yml‎

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -94,7 +94,7 @@ jobs:
9494

9595
- name: Upload coverage report (with-nvx)
9696
if: always()
97-
uses: actions/upload-artifact@v4
97+
uses: wamp-proto/wamp-cicd/actions/upload-artifact-verified@main
9898
with:
9999
name: coverage-report-combined-with-nvx
100100
path: docs/_build/html/coverage-combined-with-nvx/
@@ -105,7 +105,7 @@ jobs:
105105

106106
- name: Upload coverage report (without-nvx)
107107
if: always()
108-
uses: actions/upload-artifact@v4
108+
uses: wamp-proto/wamp-cicd/actions/upload-artifact-verified@main
109109
with:
110110
name: coverage-report-combined-without-nvx
111111
path: docs/_build/html/coverage-combined-without-nvx/
@@ -268,7 +268,7 @@ jobs:
268268
run: just docs cpy314
269269

270270
- name: Upload documentation artifacts
271-
uses: actions/upload-artifact@v4
271+
uses: wamp-proto/wamp-cicd/actions/upload-artifact-verified@main
272272
with:
273273
name: documentation
274274
path: docs/_build/html/
@@ -509,7 +509,7 @@ jobs:
509509
fi
510510
511511
- name: Upload FlatBuffers artifacts
512-
uses: actions/upload-artifact@v4
512+
uses: wamp-proto/wamp-cicd/actions/upload-artifact-verified@main
513513
with:
514514
name: flatbuffers-schema-${{ matrix.python-env }}
515515
path: |
@@ -585,7 +585,7 @@ jobs:
585585
ls -la dist/
586586
587587
- name: Upload build artifacts
588-
uses: actions/upload-artifact@v4
588+
uses: wamp-proto/wamp-cicd/actions/upload-artifact-verified@main
589589
with:
590590
name: package-${{ matrix.python-env }}
591591
path: dist/

‎.github/workflows/release-post-comment.yml‎

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -287,12 +287,12 @@ jobs:
287287
core.setOutput('run_id', '');
288288
}
289289
290-
- name: Download wstest conformance summary
290+
# Download wstest conformance summary (explicit name, no pattern)
291+
- name: Download wstest conformance summary (quick)
291292
if: steps.find-wstest.outputs.run_id != ''
292-
uses: actions/download-artifact@v4
293+
uses: wamp-proto/wamp-cicd/actions/download-artifact-verified@main
293294
with:
294-
pattern: conformance-summary-*
295-
merge-multiple: true
295+
name: conformance-summary-quick
296296
run-id: ${{ steps.find-wstest.outputs.run_id }}
297297
github-token: ${{ secrets.GITHUB_TOKEN }}
298298
path: summary-artifact/
@@ -465,12 +465,12 @@ jobs:
465465
core.setOutput('run_id', '');
466466
}
467467
468-
- name: Download wstest conformance summary
468+
# Download wstest conformance summary (explicit name, no pattern)
469+
- name: Download wstest conformance summary (quick)
469470
if: steps.find-wstest.outputs.run_id != ''
470-
uses: actions/download-artifact@v4
471+
uses: wamp-proto/wamp-cicd/actions/download-artifact-verified@main
471472
with:
472-
pattern: conformance-summary-*
473-
merge-multiple: true
473+
name: conformance-summary-quick
474474
run-id: ${{ steps.find-wstest.outputs.run_id }}
475475
github-token: ${{ secrets.GITHUB_TOKEN }}
476476
path: summary-artifact/

‎.github/workflows/release.yml‎

Lines changed: 102 additions & 34 deletions
Original file line numberDiff line numberDiff line change
@@ -455,40 +455,74 @@ jobs:
455455
retry-delay: 30
456456
continue-on-error: true
457457

458-
- name: Download wstest conformance summary
459-
uses: actions/download-artifact@v4
458+
# Download wstest conformance summary (explicit enumeration, no pattern)
459+
- name: Download wstest conformance summary (quick)
460+
uses: wamp-proto/wamp-cicd/actions/download-artifact-verified@main
460461
with:
461-
pattern: conformance-summary-*
462-
merge-multiple: true
462+
name: conformance-summary-quick
463463
path: wstest-results/
464464
run-id: ${{ needs.check-all-workflows.outputs.wstest_run_id }}
465465
github-token: ${{ secrets.GITHUB_TOKEN }}
466466
continue-on-error: true
467467

468-
- name: Download FlatBuffers schema artifacts
469-
uses: actions/download-artifact@v4
468+
# Download FlatBuffers schema artifacts (explicit enumeration for each matrix env)
469+
- name: Download FlatBuffers schema artifacts (cpy314)
470+
uses: wamp-proto/wamp-cicd/actions/download-artifact-verified@main
471+
with:
472+
name: flatbuffers-schema-cpy314
473+
path: flatbuffers-schema/cpy314/
474+
run-id: ${{ needs.check-all-workflows.outputs.main_run_id }}
475+
github-token: ${{ secrets.GITHUB_TOKEN }}
476+
continue-on-error: true
477+
478+
- name: Download FlatBuffers schema artifacts (cpy311)
479+
uses: wamp-proto/wamp-cicd/actions/download-artifact-verified@main
480+
with:
481+
name: flatbuffers-schema-cpy311
482+
path: flatbuffers-schema/cpy311/
483+
run-id: ${{ needs.check-all-workflows.outputs.main_run_id }}
484+
github-token: ${{ secrets.GITHUB_TOKEN }}
485+
continue-on-error: true
486+
487+
- name: Download FlatBuffers schema artifacts (pypy311)
488+
uses: wamp-proto/wamp-cicd/actions/download-artifact-verified@main
489+
with:
490+
name: flatbuffers-schema-pypy311
491+
path: flatbuffers-schema/pypy311/
492+
run-id: ${{ needs.check-all-workflows.outputs.main_run_id }}
493+
github-token: ${{ secrets.GITHUB_TOKEN }}
494+
continue-on-error: true
495+
496+
# Download SerDes conformance test results (explicit enumeration for each matrix env)
497+
- name: Download SerDes test results (cpy314)
498+
uses: wamp-proto/wamp-cicd/actions/download-artifact-verified@main
499+
with:
500+
name: serdes-test-results-cpy314
501+
path: serdes-test-results/cpy314/
502+
run-id: ${{ needs.check-all-workflows.outputs.main_run_id }}
503+
github-token: ${{ secrets.GITHUB_TOKEN }}
504+
continue-on-error: true
505+
506+
- name: Download SerDes test results (cpy311)
507+
uses: wamp-proto/wamp-cicd/actions/download-artifact-verified@main
470508
with:
471-
pattern: flatbuffers-schema-*
472-
merge-multiple: true
473-
path: flatbuffers-schema/
509+
name: serdes-test-results-cpy311
510+
path: serdes-test-results/cpy311/
474511
run-id: ${{ needs.check-all-workflows.outputs.main_run_id }}
475512
github-token: ${{ secrets.GITHUB_TOKEN }}
476513
continue-on-error: true
477514

478-
- name: Download SerDes conformance test results
515+
- name: Download SerDes test results (pypy311)
479516
uses: wamp-proto/wamp-cicd/actions/download-artifact-verified@main
480517
with:
481-
pattern: serdes-test-results-*
482-
merge-multiple: true
483-
path: serdes-test-results/
518+
name: serdes-test-results-pypy311
519+
path: serdes-test-results/pypy311/
484520
run-id: ${{ needs.check-all-workflows.outputs.main_run_id }}
485521
github-token: ${{ secrets.GITHUB_TOKEN }}
486-
max-attempts: 3
487-
retry-delay: 10
488522
continue-on-error: true
489523

490524
- name: Download WebSocket conformance HTML reports with-nvx (for RTD)
491-
uses: actions/download-artifact@v4
525+
uses: wamp-proto/wamp-cicd/actions/download-artifact-verified@main
492526
with:
493527
name: websocket-conformance-docs-quick-with-nvx
494528
path: websocket-conformance/with-nvx/
@@ -497,7 +531,7 @@ jobs:
497531
continue-on-error: true
498532

499533
- name: Download WebSocket conformance HTML reports without-nvx (for RTD)
500-
uses: actions/download-artifact@v4
534+
uses: wamp-proto/wamp-cicd/actions/download-artifact-verified@main
501535
with:
502536
name: websocket-conformance-docs-quick-without-nvx
503537
path: websocket-conformance/without-nvx/
@@ -1222,40 +1256,74 @@ jobs:
12221256
retry-delay: 30
12231257
continue-on-error: true
12241258

1225-
- name: Download wstest conformance summary
1226-
uses: actions/download-artifact@v4
1259+
# Download wstest conformance summary (explicit enumeration, no pattern)
1260+
- name: Download wstest conformance summary (quick)
1261+
uses: wamp-proto/wamp-cicd/actions/download-artifact-verified@main
12271262
with:
1228-
pattern: conformance-summary-*
1229-
merge-multiple: true
1263+
name: conformance-summary-quick
12301264
path: wstest-results/
12311265
run-id: ${{ needs.check-all-workflows.outputs.wstest_run_id }}
12321266
github-token: ${{ secrets.GITHUB_TOKEN }}
12331267
continue-on-error: true
12341268

1235-
- name: Download FlatBuffers schema artifacts
1236-
uses: actions/download-artifact@v4
1269+
# Download FlatBuffers schema artifacts (explicit enumeration for each matrix env)
1270+
- name: Download FlatBuffers schema artifacts (cpy314)
1271+
uses: wamp-proto/wamp-cicd/actions/download-artifact-verified@main
1272+
with:
1273+
name: flatbuffers-schema-cpy314
1274+
path: flatbuffers-schema/cpy314/
1275+
run-id: ${{ needs.check-all-workflows.outputs.main_run_id }}
1276+
github-token: ${{ secrets.GITHUB_TOKEN }}
1277+
continue-on-error: true
1278+
1279+
- name: Download FlatBuffers schema artifacts (cpy311)
1280+
uses: wamp-proto/wamp-cicd/actions/download-artifact-verified@main
1281+
with:
1282+
name: flatbuffers-schema-cpy311
1283+
path: flatbuffers-schema/cpy311/
1284+
run-id: ${{ needs.check-all-workflows.outputs.main_run_id }}
1285+
github-token: ${{ secrets.GITHUB_TOKEN }}
1286+
continue-on-error: true
1287+
1288+
- name: Download FlatBuffers schema artifacts (pypy311)
1289+
uses: wamp-proto/wamp-cicd/actions/download-artifact-verified@main
1290+
with:
1291+
name: flatbuffers-schema-pypy311
1292+
path: flatbuffers-schema/pypy311/
1293+
run-id: ${{ needs.check-all-workflows.outputs.main_run_id }}
1294+
github-token: ${{ secrets.GITHUB_TOKEN }}
1295+
continue-on-error: true
1296+
1297+
# Download SerDes conformance test results (explicit enumeration for each matrix env)
1298+
- name: Download SerDes test results (cpy314)
1299+
uses: wamp-proto/wamp-cicd/actions/download-artifact-verified@main
1300+
with:
1301+
name: serdes-test-results-cpy314
1302+
path: serdes-test-results/cpy314/
1303+
run-id: ${{ needs.check-all-workflows.outputs.main_run_id }}
1304+
github-token: ${{ secrets.GITHUB_TOKEN }}
1305+
continue-on-error: true
1306+
1307+
- name: Download SerDes test results (cpy311)
1308+
uses: wamp-proto/wamp-cicd/actions/download-artifact-verified@main
12371309
with:
1238-
pattern: flatbuffers-schema-*
1239-
merge-multiple: true
1240-
path: flatbuffers-schema/
1310+
name: serdes-test-results-cpy311
1311+
path: serdes-test-results/cpy311/
12411312
run-id: ${{ needs.check-all-workflows.outputs.main_run_id }}
12421313
github-token: ${{ secrets.GITHUB_TOKEN }}
12431314
continue-on-error: true
12441315

1245-
- name: Download SerDes conformance test results
1316+
- name: Download SerDes test results (pypy311)
12461317
uses: wamp-proto/wamp-cicd/actions/download-artifact-verified@main
12471318
with:
1248-
pattern: serdes-test-results-*
1249-
merge-multiple: true
1250-
path: serdes-test-results/
1319+
name: serdes-test-results-pypy311
1320+
path: serdes-test-results/pypy311/
12511321
run-id: ${{ needs.check-all-workflows.outputs.main_run_id }}
12521322
github-token: ${{ secrets.GITHUB_TOKEN }}
1253-
max-attempts: 3
1254-
retry-delay: 10
12551323
continue-on-error: true
12561324

12571325
- name: Download WebSocket conformance HTML reports with-nvx (for RTD)
1258-
uses: actions/download-artifact@v4
1326+
uses: wamp-proto/wamp-cicd/actions/download-artifact-verified@main
12591327
with:
12601328
name: websocket-conformance-docs-quick-with-nvx
12611329
path: websocket-conformance/with-nvx/
@@ -1264,7 +1332,7 @@ jobs:
12641332
continue-on-error: true
12651333

12661334
- name: Download WebSocket conformance HTML reports without-nvx (for RTD)
1267-
uses: actions/download-artifact@v4
1335+
uses: wamp-proto/wamp-cicd/actions/download-artifact-verified@main
12681336
with:
12691337
name: websocket-conformance-docs-quick-without-nvx
12701338
path: websocket-conformance/without-nvx/

‎.github/workflows/wstest.yml‎

Lines changed: 33 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -204,15 +204,15 @@ jobs:
204204
ls -la .wstest/clients-without-nvx/ | head -10 || echo "Not found"
205205
206206
- name: Upload client reports (with-nvx)
207-
uses: actions/upload-artifact@v4
207+
uses: wamp-proto/wamp-cicd/actions/upload-artifact-verified@main
208208
if: always()
209209
with:
210210
name: clients-all-${{ env.TEST_MODE }}-with-nvx
211211
path: .wstest/clients-with-nvx/
212212
retention-days: 30
213213

214214
- name: Upload client reports (without-nvx)
215-
uses: actions/upload-artifact@v4
215+
uses: wamp-proto/wamp-cicd/actions/upload-artifact-verified@main
216216
if: always()
217217
with:
218218
name: clients-all-${{ env.TEST_MODE }}-without-nvx
@@ -416,15 +416,15 @@ jobs:
416416
echo "======================================================================"
417417
418418
- name: Upload server reports (with-nvx)
419-
uses: actions/upload-artifact@v4
419+
uses: wamp-proto/wamp-cicd/actions/upload-artifact-verified@main
420420
if: always()
421421
with:
422422
name: servers-all-${{ env.TEST_MODE }}-with-nvx
423423
path: .wstest/servers-with-nvx/
424424
retention-days: 30
425425

426426
- name: Upload server reports (without-nvx)
427-
uses: actions/upload-artifact@v4
427+
uses: wamp-proto/wamp-cicd/actions/upload-artifact-verified@main
428428
if: always()
429429
with:
430430
name: servers-all-${{ env.TEST_MODE }}-without-nvx
@@ -458,10 +458,31 @@ jobs:
458458
curl --proto '=https' --tlsv1.2 -sSf https://just.systems/install.sh | bash -s -- --to ~/bin
459459
echo "$HOME/bin" >> $GITHUB_PATH
460460
461-
- name: Download all artifacts
462-
uses: actions/download-artifact@v4
461+
# Download all wstest artifacts explicitly (no pattern matching)
462+
# These artifact names match TEST_MODE=quick which is set at workflow level
463+
- name: Download client reports (with-nvx)
464+
uses: wamp-proto/wamp-cicd/actions/download-artifact-verified@main
463465
with:
464-
path: artifacts/
466+
name: clients-all-${{ env.TEST_MODE }}-with-nvx
467+
path: artifacts/clients-all-${{ env.TEST_MODE }}-with-nvx/
468+
469+
- name: Download client reports (without-nvx)
470+
uses: wamp-proto/wamp-cicd/actions/download-artifact-verified@main
471+
with:
472+
name: clients-all-${{ env.TEST_MODE }}-without-nvx
473+
path: artifacts/clients-all-${{ env.TEST_MODE }}-without-nvx/
474+
475+
- name: Download server reports (with-nvx)
476+
uses: wamp-proto/wamp-cicd/actions/download-artifact-verified@main
477+
with:
478+
name: servers-all-${{ env.TEST_MODE }}-with-nvx
479+
path: artifacts/servers-all-${{ env.TEST_MODE }}-with-nvx/
480+
481+
- name: Download server reports (without-nvx)
482+
uses: wamp-proto/wamp-cicd/actions/download-artifact-verified@main
483+
with:
484+
name: servers-all-${{ env.TEST_MODE }}-without-nvx
485+
path: artifacts/servers-all-${{ env.TEST_MODE }}-without-nvx/
465486

466487
- name: Reconstruct test directory structure
467488
run: |
@@ -570,21 +591,21 @@ jobs:
570591
echo "SUMMARY_FILE=$SUMMARY_FILE" >> $GITHUB_ENV
571592
572593
- name: Upload consolidated reports (with-nvx)
573-
uses: actions/upload-artifact@v4
594+
uses: wamp-proto/wamp-cicd/actions/upload-artifact-verified@main
574595
with:
575596
name: websocket-conformance-docs-${{ env.TEST_MODE }}-with-nvx
576597
path: docs/_static/websocket/conformance-with-nvx/
577598
retention-days: 30
578599

579600
- name: Upload consolidated reports (without-nvx)
580-
uses: actions/upload-artifact@v4
601+
uses: wamp-proto/wamp-cicd/actions/upload-artifact-verified@main
581602
with:
582603
name: websocket-conformance-docs-${{ env.TEST_MODE }}-without-nvx
583604
path: docs/_static/websocket/conformance-without-nvx/
584605
retention-days: 30
585606

586607
- name: Upload summary report for PR comment
587-
uses: actions/upload-artifact@v4
608+
uses: wamp-proto/wamp-cicd/actions/upload-artifact-verified@main
588609
with:
589610
name: conformance-summary-${{ env.TEST_MODE }}
590611
path: ${{ env.SUMMARY_FILE }}
@@ -629,13 +650,13 @@ jobs:
629650
submodules: recursive
630651

631652
- name: Download consolidated reports (with-nvx)
632-
uses: actions/download-artifact@v4
653+
uses: wamp-proto/wamp-cicd/actions/download-artifact-verified@main
633654
with:
634655
name: websocket-conformance-docs-${{ env.TEST_MODE }}-with-nvx
635656
path: docs/_static/websocket/conformance-with-nvx/
636657

637658
- name: Download consolidated reports (without-nvx)
638-
uses: actions/download-artifact@v4
659+
uses: wamp-proto/wamp-cicd/actions/download-artifact-verified@main
639660
with:
640661
name: websocket-conformance-docs-${{ env.TEST_MODE }}-without-nvx
641662
path: docs/_static/websocket/conformance-without-nvx/

0 commit comments

Comments
 (0)