Cumbersome usage of getResourceCondition due to 'Unknown' vs 'Unspecified' condition status values

[olvesh]

What happened?

I am trying to set the status via an annotation, like:

gotemplating.fn.crossplane.io/ready: {{ ( getResourceCondition "Ready" $resource).Status }}

but the status returned from the condition in Kubernetes is one of these legal values:

const (
	ConditionTrue    ConditionStatus = "True"
	ConditionFalse   ConditionStatus = "False"
	ConditionUnknown ConditionStatus = "Unknown"
)

while the legal values in funtion-go-templating is:

const (
	ReadyUnspecified Ready = "Unspecified"
	ReadyTrue        Ready = "True"
	ReadyFalse       Ready = "False"
)

This means we cannot easily "transport" values from the resource to the annotation, but have to have conditionals to map between Unknown and Unspecified, resulting in invalid function input: invalid "gotemplating.fn.crossplane.io/ready" annotation value "Unknown": must be True, False, or Unspecified

What environment did it happen in?

Function version: v0.5.0

[bobh66]

Thanks @olvesh - looks like a bug, are you interested in pushing a PR?

[olvesh]

Could do, but not sure about the fallout of changing the ReadyUnspecified from Unspecified to Unknown. Have to think about how to do this un-invasive in case someone uses the Unspecified value for comparisons.

Edit:
Also, the ReadyUnspecified stems from function-sdk-go, and not this function
https://github.com/search?q=repo%3Acrossplane%2Ffunction-sdk-go%20ReadyUnspecified&type=code

Would this then be a bug in the SDK, or is there a meaning to having another value for this than in k8s?

[olvesh]

It seems that the unspecified enum is used throughout

So would this be a design-bug in Crossplane, or a well thought through design? :-)