Fix: Changed implementation to allow non standard convention for chart tgz names

Author: albertoec

pkg/clients/helm/client.go

@@ -20,7 +20,6 @@ import (
 	"fmt"
 	"net/url"
 	"os"
-	"path"
 	"path/filepath"
 	"strings"
 
@@ -180,11 +179,7 @@ func (hc *client) pullLatestChartVersion(spec *v1beta1.ChartSpec, creds *RepoCre
 		}
 	}()
 
-	if err := hc.pullChart(spec, creds, tmpDir); err != nil {
-		return "", err
-	}
-
-	chartFileName, err := getChartFileName(tmpDir)
+	chartFileName, err := hc.pullChart(spec, creds, tmpDir)
 	if err != nil {
 		return "", err
 	}
@@ -196,7 +191,17 @@ func (hc *client) pullLatestChartVersion(spec *v1beta1.ChartSpec, creds *RepoCre
 	return chartFilePath, nil
 }
 
-func (hc *client) pullChart(spec *v1beta1.ChartSpec, creds *RepoCreds, chartDir string) error {
+func (hc *client) pullChart(spec *v1beta1.ChartSpec, creds *RepoCreds, chartDir string) (string, error) {
+	tmpDir, err := os.MkdirTemp(chartDir, "")
+	if err != nil {
+		return "", err
+	}
+	defer func() {
+		if err := os.RemoveAll(tmpDir); err != nil {
+			hc.log.WithValues("tmpDir", tmpDir).Info("failed to remove temporary directory")
+		}
+	}()
+
 	pc := hc.pullClient
 
 	chartRef := spec.URL
@@ -211,29 +216,40 @@ func (hc *client) pullChart(spec *v1beta1.ChartSpec, creds *RepoCreds, chartDir
 	} else if registry.IsOCI(spec.URL) {
 		ociURL, version, err := resolveOCIChartVersion(spec.URL)
 		if err != nil {
-			return err
+			return "", err
 		}
 		pc.Version = version
 		chartRef = ociURL.String()
 	}
 	pc.Username = creds.Username
 	pc.Password = creds.Password
 
-	pc.DestDir = chartDir
+	pc.DestDir = tmpDir
 
 	if creds.Username != "" && creds.Password != "" {
 		err := hc.login(spec, creds, pc.InsecureSkipTLSverify)
 		if err != nil {
-			return err
+			return "", err
 		}
 	}
 
 	o, err := pc.Run(chartRef)
 	hc.log.Debug(o)
+
+	if err != nil {
+		return "", errors.Wrap(err, errFailedToPullChart)
+	}
+
+	chartFileName, err := getChartFileName(tmpDir)
 	if err != nil {
-		return errors.Wrap(err, errFailedToPullChart)
+		return "", err
 	}
-	return nil
+
+	chartFilePath := filepath.Join(chartDir, chartFileName)
+	if err := os.Rename(filepath.Join(tmpDir, chartFileName), chartFilePath); err != nil {
+		return "", err
+	}
+	return chartFilePath, nil
 }
 
 func (hc *client) login(spec *v1beta1.ChartSpec, creds *RepoCreds, insecure bool) error {
@@ -257,14 +273,15 @@ func (hc *client) login(spec *v1beta1.ChartSpec, creds *RepoCreds, insecure bool
 func (hc *client) PullAndLoadChart(spec *v1beta1.ChartSpec, creds *RepoCreds) (*chart.Chart, error) {
 	var chartFilePath string
 	var err error
+
 	switch {
 	case spec.URL == "" && (spec.Version == "" || spec.Version == devel):
 		chartFilePath, err = hc.pullLatestChartVersion(spec, creds)
 		if err != nil {
 			return nil, err
 		}
 	case registry.IsOCI(spec.URL):
-		u, v, err := resolveOCIChartVersion(spec.URL)
+		_, v, err := resolveOCIChartVersion(spec.URL)
 		if err != nil {
 			return nil, err
 		}
@@ -275,24 +292,27 @@ func (hc *client) PullAndLoadChart(spec *v1beta1.ChartSpec, creds *RepoCreds) (*
 				return nil, err
 			}
 		} else {
-			chartFilePath = resolveChartFilePath(path.Base(u.Path), v)
+			chartFilePath, err = hc.pullChart(spec, creds, chartCache)
+			if err != nil {
+				return nil, err
+			}
 		}
 	case spec.URL != "":
-		u, err := url.Parse(spec.URL)
+		chartFilePath, err = hc.pullChart(spec, creds, chartCache)
 		if err != nil {
-			return nil, errors.Wrap(err, errFailedToParseURL)
+			return nil, err
 		}
-		chartFilePath = filepath.Join(chartCache, path.Base(u.Path))
 	default:
-		chartFilePath = resolveChartFilePath(spec.Name, spec.Version)
+		chartFilePath, err = hc.pullChart(spec, creds, chartCache)
+		if err != nil {
+			return nil, err
+		}
 	}
 
 	if _, err := os.Stat(chartFilePath); os.IsNotExist(err) {
-		if err = hc.pullChart(spec, creds, chartCache); err != nil {
-			return nil, err
-		}
-	} else if err != nil {
 		return nil, errors.Wrap(err, errFailedToCheckIfLocalChartExists)
+	} else if err != nil {
+		return nil, err
 	}
 
 	chart, err := loader.Load(chartFilePath)
@@ -359,11 +379,6 @@ func resolveOCIChartVersion(chartURL string) (*url.URL, string, error) {
 	return ociURL, "", nil
 }
 
-func resolveChartFilePath(name string, version string) string {
-	filename := fmt.Sprintf("%s-%s.tgz", name, version)
-	return filepath.Join(chartCache, filename)
-}
-
 func resolveOCIChartRef(repository string, name string) string {
 	return strings.Join([]string{strings.TrimSuffix(repository, "/"), name}, "/")
 }