address review: validate immutability of contained spec in CRD API

Signed-off-by: Bogdan-Adrian Burciu <bogdanadrian.burciu@yahoo.com>

Author: baburciu

apis/cluster/mssql/v1alpha1/user_types.go

@@ -36,6 +36,7 @@ type UserStatus struct {
 
 // UserParameters define the desired state of a MSSQL user instance.
 // +kubebuilder:validation:XValidation:rule="!(has(self.contained) && self.contained == true && (has(self.loginDatabase) || has(self.loginDatabaseRef) || has(self.loginDatabaseSelector)))",message="contained users cannot specify loginDatabase, loginDatabaseRef, or loginDatabaseSelector"
+// +kubebuilder:validation:XValidation:rule="!has(oldSelf.contained) || self.contained == oldSelf.contained",message="contained field is immutable after creation"
 type UserParameters struct {
 	// Database allows you to specify the name of the Database the USER is created for.
 	// +crossplane:generate:reference:type=Database

apis/namespaced/mssql/v1alpha1/user_types.go

@@ -37,6 +37,7 @@ type UserStatus struct {
 
 // UserParameters define the desired state of a MSSQL user instance.
 // +kubebuilder:validation:XValidation:rule="!(has(self.contained) && self.contained == true && (has(self.loginDatabase) || has(self.loginDatabaseRef) || has(self.loginDatabaseSelector)))",message="contained users cannot specify loginDatabase, loginDatabaseRef, or loginDatabaseSelector"
+// +kubebuilder:validation:XValidation:rule="!has(oldSelf.contained) || self.contained == oldSelf.contained",message="contained field is immutable after creation"
 type UserParameters struct {
 	// Database allows you to specify the name of the Database the USER is created for.
 	// +crossplane:generate:reference:type=Database

package/crds/mssql.sql.crossplane.io_users.yaml

@@ -265,6 +265,8 @@ spec:
                     or loginDatabaseSelector
                   rule: '!(has(self.contained) && self.contained == true && (has(self.loginDatabase)
                     || has(self.loginDatabaseRef) || has(self.loginDatabaseSelector)))'
+                - message: contained field is immutable after creation
+                  rule: '!has(oldSelf.contained) || self.contained == oldSelf.contained'
               managementPolicies:
                 default:
                 - '*'

package/crds/mssql.sql.m.crossplane.io_users.yaml

@@ -254,6 +254,8 @@ spec:
                     or loginDatabaseSelector
                   rule: '!(has(self.contained) && self.contained == true && (has(self.loginDatabase)
                     || has(self.loginDatabaseRef) || has(self.loginDatabaseSelector)))'
+                - message: contained field is immutable after creation
+                  rule: '!has(oldSelf.contained) || self.contained == oldSelf.contained'
               managementPolicies:
                 default:
                 - '*'