ci: migrate golangci-lint to v2 (#75)

* ci:  migrate golangci-lint to v2

Signed-off-by: Maximilian Braun (SAP) <[email protected]>

* ci: raise action to v2.0.2

Signed-off-by: Maximilian Braun (SAP) <[email protected]>

* ci: linting

Signed-off-by: Maximilian Braun (SAP) <[email protected]>

* ci: linting

Signed-off-by: Maximilian Braun (SAP) <[email protected]>

---------

Signed-off-by: Maximilian Braun (SAP) <[email protected]>

Author: maximilianbraun

.github/workflows/lint.yaml

@@ -24,10 +24,10 @@ jobs:
           cache: false
       - uses: actions/checkout@v4
       - name: golangci-lint
-        uses: golangci/golangci-lint-action@v6
+        uses: golangci/golangci-lint-action@v7
         with:
           # Optional: version of golangci-lint to use in form of v1.2 or v1.2.3 or `latest` to use the latest version
-          version: v1.60.1
+          version: v2.0.2
 
           # Optional: working directory, useful for monorepos
           # working-directory: somedir

.golangci.yaml

@@ -0,0 +1,130 @@
+version: "2"
+linters:
+  enable:
+    - asasalint
+    - asciicheck
+    - bidichk
+    - bodyclose
+    - contextcheck
+    - durationcheck
+    - errchkjson
+    - errorlint
+    - exhaustive
+    - gocheckcompilerdirectives
+    - gochecksumtype
+    - goconst
+    - gocritic
+    - gocyclo
+    - gosec
+    - gosmopolitan
+    - loggercheck
+    - makezero
+    - misspell
+    - musttag
+    - nakedret
+    - nilerr
+    - nilnesserr
+    - noctx
+    - prealloc
+    - protogetter
+    - reassign
+    - recvcheck
+    - rowserrcheck
+    - spancheck
+    - sqlclosecheck
+    - testifylint
+    - unconvert
+    - unparam
+    - zerologlint
+  settings:
+    dupl:
+      threshold: 100
+    errcheck:
+      check-type-assertions: false
+      check-blank: false
+      exclude-functions:
+        - fmt:.*,io
+        - ioutil:^Read.*
+    goconst:
+      min-len: 3
+      min-occurrences: 5
+    gocritic:
+      enabled-tags:
+        - performance
+      settings:
+        captLocal:
+          paramsOnly: true
+        rangeValCopy:
+          sizeThreshold: 32
+    gocyclo:
+      min-complexity: 10
+    govet:
+      disable:
+        - shadow
+    lll:
+      tab-width: 1
+    nakedret:
+      max-func-lines: 30
+    prealloc:
+      simple: true
+      range-loops: true
+      for-loops: false
+    unparam:
+      check-exported: false
+  exclusions:
+    generated: lax
+    rules:
+      - linters:
+          - staticcheck
+        text: "QF1008:" # could remove embedded field "xy" from selector (staticcheck)
+      - linters:
+          - staticcheck
+        text: "QF1007:" # could merge conditional assignment into variable declaration (staticcheck)
+      - linters:
+          - dupl
+          - errcheck
+          - gocyclo
+          - gosec
+          - scopelint
+          - unparam
+        path: _test(ing)?\.go
+      - linters:
+          - gocritic
+        path: _test\.go
+        text: (unnamedResult|exitAfterDefer)
+      - linters:
+          - gocritic
+        text: '(hugeParam|rangeValCopy):'
+      - linters:
+          - staticcheck
+        text: 'SA3000:'
+      - linters:
+          - gosec
+        text: 'G101:'
+      - linters:
+          - gosec
+        text: 'G104:'
+    paths:
+      - zz_generated\..+\.go$
+      - vendored/.+\.go$
+      - third_party$
+      - builtin$
+      - examples$
+issues:
+  max-same-issues: 0
+  new: false
+formatters:
+  enable:
+    - gofmt
+    - goimports
+  settings:
+    gofmt:
+      simplify: true
+  exclusions:
+    generated: lax
+    paths:
+      - zz_generated\..+\.go$
+      - vendored/.+\.go$
+      - third_party$
+      - builtin$
+      - examples$

.golangci.yml

@@ -32,7 +32,6 @@ import (
 
 	resHelper "github.com/crossplane-contrib/xp-testing/pkg/resources"
 	"github.com/crossplane-contrib/xp-testing/pkg/vendored"
-	xconditions "github.com/crossplane-contrib/xp-testing/pkg/xpconditions"
 
 	"github.com/crossplane-contrib/xp-testing/internal/docker"
 	"github.com/crossplane-contrib/xp-testing/internal/xpkg"
@@ -387,7 +386,7 @@ func awaitProviderHealthy(opts InstallCrossplaneProviderOptions) env.Func {
 			return ctx, err
 		}
 		err = wait.For(
-			xconditions.New(r).ProviderConditionMatch(
+			xpconditions.New(r).ProviderConditionMatch(
 				opts.Name,
 				"Healthy",
 				corev1.ConditionTrue,

pkg/xpenvfuncs/xpenvfuncs.go

@@ -275,7 +275,6 @@ spec:
 	for _, test := range tests {
 		t.Run(
 			test.description, func(t *testing.T) {
-				require.True(t, true)
 				rendered, err := renderTemplate(test.args.template, test.args.data)
 
 				if len(test.expects.errorMessage) == 0 {