Address linter warnings about embedded structs

Specifically it wants them to appear first, before non-embedded things.

Signed-off-by: Nic Cope <[email protected]>

Author: negz

apis/common/v1/connection_details.go

@@ -145,13 +145,13 @@ type Config struct {
 // KubernetesAuthConfig required to authenticate to a K8s API. It expects
 // a "kubeconfig" file to be provided.
 type KubernetesAuthConfig struct {
-	// Source of the credentials.
-	// +kubebuilder:validation:Enum=None;Secret;Environment;Filesystem
-	Source CredentialsSource `json:"source"`
-
 	// CommonCredentialSelectors provides common selectors for extracting
 	// credentials.
 	CommonCredentialSelectors `json:",inline"`
+
+	// Source of the credentials.
+	// +kubebuilder:validation:Enum=None;Secret;Environment;Filesystem
+	Source CredentialsSource `json:"source"`
 }
 
 // KubernetesSecretStoreConfig represents the required configuration

pkg/connection/fake/mocks.go

@@ -56,9 +56,9 @@ func (ss *SecretStore) DeleteKeyValues(ctx context.Context, s *store.Secret, do
 // StoreConfig is a mock implementation of the StoreConfig interface.
 type StoreConfig struct {
 	metav1.ObjectMeta
+	v1.ConditionedStatus
 
 	Config v1.SecretStoreConfig
-	v1.ConditionedStatus
 }
 
 // GetStoreConfig returns SecretStoreConfig.

pkg/connection/store/plugin/fake/mocks.go

@@ -24,10 +24,11 @@ import (
 
 // ExternalSecretStorePluginServiceClient is a fake ExternalSecretStorePluginServiceClient.
 type ExternalSecretStorePluginServiceClient struct {
+	*ess.UnimplementedExternalSecretStorePluginServiceServer
+
 	GetSecretFn   func(context.Context, *ess.GetSecretRequest, ...grpc.CallOption) (*ess.GetSecretResponse, error)
 	ApplySecretFn func(context.Context, *ess.ApplySecretRequest, ...grpc.CallOption) (*ess.ApplySecretResponse, error)
 	DeleteKeysFn  func(context.Context, *ess.DeleteKeysRequest, ...grpc.CallOption) (*ess.DeleteKeysResponse, error)
-	*ess.UnimplementedExternalSecretStorePluginServiceServer
 }
 
 // GetSecret returns the secret.