Skip to content

Commit f7e5e04

Browse files
authored
External link fixes (#738)
* fix link to github issue Signed-off-by: Pete Lumbis <[email protected]> * fix generated link for 'view page source' Signed-off-by: Pete Lumbis <[email protected]> * don't strip query strings to properly check youtube links Signed-off-by: Pete Lumbis <[email protected]> --------- Signed-off-by: Pete Lumbis <[email protected]>
1 parent 4a1d3e6 commit f7e5e04

File tree

4 files changed

+5
-3
lines changed

4 files changed

+5
-3
lines changed

content/master/release-notes/docs.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -42,7 +42,7 @@ registry.
4242
<!-- allow "check" -->
4343
* Fixed [an issue](https://github.com/crossplane/docs/pull/718) where mermaid
4444
diagrams didn't display the right colors across light and dark modes.
45-
* Added support for a "[you are here](https://github.com/crossplane/docs/pull/716")
45+
* Added support for a "[you are here](https://github.com/crossplane/docs/pull/716)"
4646
feature for doc page table of contents.
4747
* Fixed the color of check marks (✔️) in dark mode.
4848
<!-- vale Google.WordList = YES -->

content/v1.15/release-notes/docs.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -42,7 +42,7 @@ registry.
4242
<!-- allow "check" -->
4343
* Fixed [an issue](https://github.com/crossplane/docs/pull/718) where mermaid
4444
diagrams didn't display the right colors across light and dark modes.
45-
* Added support for a "[you are here](https://github.com/crossplane/docs/pull/716")
45+
* Added support for a "[you are here](https://github.com/crossplane/docs/pull/716)"
4646
feature for doc page table of contents.
4747
* Fixed the color of check marks (✔️) in dark mode.
4848
<!-- vale Google.WordList = YES -->

themes/geekboot/layouts/partials/single-list.html

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -57,7 +57,7 @@ <h1 class="bd-title mb-0" id="content">{{ .Title | markdownify }}
5757
</div>
5858
<div>
5959
<svg class="bi" width="1em" height="1em"><use xlink:href="#github"/></svg>
60-
<span class="ps-1"><a href="{{printf "https://github.com/crossplane/docs/tree/master/content/%s" .Page.File}}">View page source</a></span>
60+
<span class="ps-1"><a href="{{printf "https://github.com/crossplane/docs/tree/master/content/%s" .Page.File.Path}}">View page source</a></span>
6161
</div>
6262
</div>
6363
</nav>

utils/htmltest/.htmltest.yml

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3,9 +3,11 @@ DirectoryPath: "public"
33
# This doesn't cause errors
44
IgnoreInternalEmptyHash: true
55
CheckExternal: false
6+
StripQueryString: false
67
IgnoreURLs:
78
- "github.com/crossplane/docs/tree/master/content/(.*).md" # Ignore the links to "view this source"
89
- "www.googletagmanager.com/*" # Ignore google tag manager
910
- "twitter.com/*" # Ignore twitter links since they send to login page
1011
- "https://releases.crossplane.io/stable/current/bin" # S3 bucket listing always returns 404 status even with directory listing
1112
- "docs.crossplane.io/latest/*" # Allow links to the latest release (e.g. from knowledge-base)
13+
- "github.com/crossplane/docs/issues/new*" # Ignore the "open an issue" link

0 commit comments

Comments
 (0)