Skip to content

Conversation

@jbw976
Copy link
Member

@jbw976 jbw976 commented Oct 20, 2025

Description of your changes

This PR adds an OWNERS.md file to list the current maintainers. This file matches what is in the github permissions.

I have:

  • Read and followed Crossplane's contribution process.
  • Run make reviewable to ensure this PR is ready for review.

@coderabbitai
Copy link

coderabbitai bot commented Oct 20, 2025

📝 Walkthrough

Walkthrough

A new OWNERS.md documentation file has been introduced that defines the repository's maintainers, references governance guidelines, and lists contributor information including newly added maintainers Ezgi Demirel and Steven Borrelli, mirroring the crossplane/crossplane repository's structure.

Changes

Cohort / File(s) Summary
Documentation: Maintainers
OWNERS.md
New file defining repository maintainers with governance reference, listing multiple maintainer names, emails, and GitHub handles

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~5 minutes

This is a straightforward documentation addition with no code logic or complex structure—primarily requires verifying maintainer information accuracy and governance reference consistency.

Pre-merge checks

✅ Passed checks (3 passed)
Check name Status Explanation
Title Check ✅ Passed The title "chore: add OWNERS.md file to match repo permissions" is clearly descriptive and directly summarizes the main change in the pull request. At 51 characters, it comfortably stays under the 72-character limit requirement and effectively communicates both what is being added (OWNERS.md file) and the purpose (matching repository permissions). The title aligns well with the changeset, which introduces a new OWNERS.md file listing maintainers.
Description Check ✅ Passed The pull request description is directly related to the changeset and provides meaningful context about the change. The author clearly states that the PR adds an OWNERS.md file to list current maintainers and that it matches the GitHub permissions, which accurately reflects what the changeset does. The description also demonstrates good practice by confirming adherence to contribution guidelines and pre-review preparation steps, making it informative and relevant.
Breaking Changes ✅ Passed This pull request only adds a new OWNERS.md documentation file to list repository maintainers and does not modify any Go source code files. The GitHub API results confirm that only OWNERS.md is included in the PR changes, with no alterations to any .go files. Since the breaking-change check applies exclusively to public Go code in '**/*.go' files (excluding tests and generated files), and there are no such modifications in this PR, there can be no breaking changes to public APIs or exported entities.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (2)
OWNERS.md (2)

11-14: Consider wrapping line 11 to maintain 100-character consistency.

Line 11 runs approximately 148 characters, exceeding the 100-column guideline for Markdown files. While the embedded link is long, you could wrap it as follows without sacrificing readability:

-The Maintainers mirror the [crossplane/crossplane OWNERS](https://github.com/crossplane/crossplane/blob/main/OWNERS.md) with the following changes:
+The Maintainers mirror the [crossplane/crossplane OWNERS](https://github.com/crossplane/crossplane/blob/main/OWNERS.md)
+with the following changes:

This aligns with the document's otherwise clean formatting.


24-24: Add a newline at the end of the file.

Files should conventionally end with a newline character. Please add one after line 24.

📜 Review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 78079b1 and 509e5f3.

📒 Files selected for processing (1)
  • OWNERS.md (1 hunks)
🧰 Additional context used
📓 Path-based instructions (1)
**/*.md

⚙️ CodeRabbit configuration file

**/*.md: Ensure Markdown files are wrapped at 100 columns for consistency and
readability. Lines can be longer if it makes links more readable, but
otherwise should wrap at 100 characters. Check for proper heading
structure, clear language, and that documentation is helpful for users.

Files:

  • OWNERS.md
🔍 Remote MCP

Additional Context for PR #233 Review

Governance Framework

Each repository in the Crossplane organizations can have different teams of maintainers with permissions, with adding and removing maintainers being the responsibility of the existing maintainer team for that repository.

OWNERS.md Purpose

Each repository in the Crossplane organization is expected to list their repository maintainers and reviewers in their own OWNERS.md file. The current list of maintainers for each repository is published and updated in each repo's OWNERS.md file.

Maintainer Requirements

To verify the PR adds appropriate maintainers, note that becoming a maintainer requires demonstrating leadership in the community and domain expertise in the repository's area of focus, along with willingness to contribute beyond organizational interests. Maintainers are expected to spend at least 25% of their time working on Crossplane (~1.25 business days per week).

Repository Context

The function-sdk-go repository is the Go SDK for composition functions and follows the same contributing guidelines as Crossplane.

Key Considerations for Review

  1. Verify the newly added maintainers (Ezgi Demirel and Steven Borrelli) meet the governance requirements for maintainers
  2. Confirm the OWNERS.md structure aligns with other Crossplane repositories (like provider-template and crossplane-runtime)
  3. Ensure the file properly references GOVERNANCE.md for guidelines and maintainer responsibilities

[::web_search::]

🔇 Additional comments (2)
OWNERS.md (2)

1-9: Nice work documenting governance context and maintainers!

The OWNERS.md file is well-structured, clearly references Crossplane's GOVERNANCE.md guidelines, and provides helpful context about how this repository's maintainers align with the crossplane/crossplane repository. The introduction effectively explains the file's purpose for newcomers to the project.


16-24: Maintainers list is clear and well-formatted.

The maintainers section is consistent, comprehensive, and includes all relevant contact information for each person. The addition of Ezgi Demirel and Steven Borrelli is clearly documented in both the summary section and the full list, making it easy for contributors to identify the team.

@jbw976 jbw976 merged commit cc2fdca into crossplane:main Oct 20, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants