fix(reactions): specify proper names for reaction counters in Cypher queries

Author: undrcrxwn

src/CrowdParlay.Social.Api/Services/GlobalExceptionHandler.cs

@@ -4,6 +4,7 @@
 using Grpc.Core;
 using Microsoft.AspNetCore.Diagnostics;
 using Microsoft.AspNetCore.Mvc;
+using static Microsoft.AspNetCore.Http.StatusCodes;
 
 namespace CrowdParlay.Social.Api.Services;
 
@@ -28,21 +29,21 @@ public async ValueTask<bool> TryHandleAsync(HttpContext context, Exception excep
         };
 
         context.Response.ContentType = MediaTypeNames.Application.ProblemJson;
-        context.Response.StatusCode = problemDetails.Status ?? StatusCodes.Status500InternalServerError;
+        context.Response.StatusCode = problemDetails.Status ?? Status500InternalServerError;
         await context.Response.WriteAsJsonAsync(problemDetails, GlobalSerializerOptions.SnakeCase, cancellationToken);
 
         return true;
     }
 
     private static ProblemDetails GetDefaultProblemDetails() => new()
     {
-        Status = (int)HttpStatusCode.InternalServerError,
+        Status = Status500InternalServerError,
         Detail = "Something went wrong. Try again later.",
     };
 
     private static ValidationProblemDetails ConvertToProblemDetails(ValidationException exception) => new()
     {
-        Status = (int)HttpStatusCode.BadRequest,
+        Status = Status400BadRequest,
         Detail = "The specified data is invalid.",
         Errors = exception.Errors.ToDictionary(
             x => x.Key,
@@ -51,7 +52,7 @@ public async ValueTask<bool> TryHandleAsync(HttpContext context, Exception excep
 
     private static ValidationProblemDetails ConvertToProblemDetails(FluentValidation.ValidationException exception) => new()
     {
-        Status = (int)HttpStatusCode.BadRequest,
+        Status = Status400BadRequest,
         Detail = "The specified data is invalid.",
         Errors = exception.Errors
             .GroupBy(failure => failure.PropertyName)
@@ -64,19 +65,19 @@ public async ValueTask<bool> TryHandleAsync(HttpContext context, Exception excep
 
     private static ProblemDetails GetNotFoundProblemDetails() => new()
     {
-        Status = (int)HttpStatusCode.NotFound,
+        Status = Status404NotFound,
         Detail = "The requested resource doesn't exist."
     };
 
     private static ProblemDetails GetForbiddenProblemDetails() => new()
     {
-        Status = (int)HttpStatusCode.Forbidden,
+        Status = Status403Forbidden,
         Detail = "You have no permission for this action."
     };
 
     private static ProblemDetails GetUnavailableDependencyProblemDetails() => new()
     {
-        Status = (int)HttpStatusCode.ServiceUnavailable,
+        Status = Status503ServiceUnavailable,
         Detail = "Failed to handle the request due to an unavailable dependency. Try again later."
     };
 }

src/CrowdParlay.Social.Infrastructure.Persistence/Services/CommentsRepository.cs

@@ -29,7 +29,7 @@ ELSE [] END AS firstRepliesAuthorIds
                 COUNT(reaction) AS reactionCount
 
             WITH comment, author, replyCount, firstRepliesAuthorIds, viewerReactions,
-                apoc.map.fromPairs(COLLECT([reaction.Value, reactionCount])) AS reactions
+                apoc.map.fromPairs(COLLECT([reaction.Value, reactionCount])) AS reactionCounters
 
             RETURN {
                 Id: comment.Id,
@@ -38,7 +38,7 @@ ELSE [] END AS firstRepliesAuthorIds
                 CreatedAt: comment.CreatedAt,
                 ReplyCount: replyCount,
                 FirstRepliesAuthorIds: firstRepliesAuthorIds,
-                Reactions: reactions,
+                ReactionCounters: reactionCounters,
                 ViewerReactions: viewerReactions
             }
             """,
@@ -83,11 +83,11 @@ OPTIONAL MATCH (comment)<-[viewerReaction:REACTED_TO]-(:Author { Id: $viewerId }
                  COUNT(reaction) AS reactionCount
 
             WITH author, comment, deepReplyAuthor, deepReply, viewerReactions,
-                 apoc.map.fromPairs(COLLECT([reaction.Value, reactionCount])) AS reactions
+                 apoc.map.fromPairs(COLLECT([reaction.Value, reactionCount])) AS reactionCounters
                  
             ORDER BY comment.CreatedAt, deepReply.CreatedAt DESC
 
-            WITH author, comment, viewerReactions, reactions,
+            WITH author, comment, viewerReactions, reactionCounters,
                  COUNT(deepReply) AS deepReplyCount,
                  COLLECT(DISTINCT deepReplyAuthor.Id)[0..3] AS firstDeepRepliesAuthorIds
 
@@ -100,7 +100,7 @@ OPTIONAL MATCH (comment)<-[viewerReaction:REACTED_TO]-(:Author { Id: $viewerId }
                     CreatedAt: comment.CreatedAt,
                     ReplyCount: deepReplyCount,
                     FirstRepliesAuthorIds: firstDeepRepliesAuthorIds,
-                    Reactions: reactions,
+                    ReactionCounters: reactionCounters,
                     ViewerReactions: viewerReactions
                 })[$offset..$offset + $count]
             }

src/CrowdParlay.Social.Infrastructure.Persistence/Services/DiscussionsRepository.cs

@@ -22,15 +22,15 @@ OPTIONAL MATCH (discussion)<-[viewerReaction:REACTED_TO]-(:Author { Id: $viewerI
                 COUNT(reaction) AS reactionCount
 
             WITH author, discussion, viewerReactions,
-                apoc.map.fromPairs(COLLECT([reaction.Value, reactionCount])) AS reactions
+                apoc.map.fromPairs(COLLECT([reaction.Value, reactionCount])) AS reactionCounters
 
             RETURN {
                 Id: discussion.Id,
                 Title: discussion.Title,
                 Description: discussion.Description,
                 AuthorId: author.Id,
                 CreatedAt: discussion.CreatedAt,
-                Reactions: reactions,
+                ReactionCounters: reactionCounters,
                 ViewerReactions: viewerReactions
             }
             """,
@@ -64,7 +64,7 @@ OPTIONAL MATCH (discussion)<-[viewerReaction:REACTED_TO]-(:Author { Id: $viewerI
                 COUNT(reaction) AS reactionCount
 
             WITH author, discussion, viewerReactions,
-                apoc.map.fromPairs(COLLECT([reaction.Value, reactionCount])) AS reactions
+                apoc.map.fromPairs(COLLECT([reaction.Value, reactionCount])) AS reactionCounters
 
             ORDER BY discussion.CreatedAt DESC
 
@@ -76,7 +76,7 @@ ORDER BY discussion.CreatedAt DESC
                     Description: discussion.Description,
                     AuthorId: author.Id,
                     CreatedAt: discussion.CreatedAt,
-                    Reactions: reactions,
+                    ReactionCounters: reactionCounters,
                     ViewerReactions: viewerReactions
                 })[$offset..$offset + $count]
             }

tests/CrowdParlay.Social.IntegrationTests/Tests/CommentsRepositoryTests.cs

@@ -36,6 +36,8 @@ public async Task CreateComment()
         comment.ReplyCount.Should().Be(0);
         comment.FirstRepliesAuthorIds.Should().BeEmpty();
         comment.CreatedAt.Should().BeCloseTo(DateTime.Now, TimeSpan.FromMinutes(1));
+        comment.ReactionCounters.Should().BeEmpty();
+        comment.ViewerReactions.Should().BeEmpty();
     }
 
     [Fact(DisplayName = "Search comments")]
@@ -107,6 +109,8 @@ public async Task SearchComments()
         page.Items.Should().HaveCount(2);
         page.Items.Should().BeEquivalentTo([comment1, comment2]);
         page.Items.First().FirstRepliesAuthorIds.Should().BeEquivalentTo([authorId4, authorId2, authorId1]);
+        page.Items.Should().OnlyContain(comment => comment.ReactionCounters.Count == 0);
+        page.Items.Should().OnlyContain(comment => comment.ViewerReactions.Count == 0);
     }
 
     [Fact(DisplayName = "Get comment with unknown ID")]

tests/CrowdParlay.Social.IntegrationTests/Tests/DiscussionsRepositoryTests.cs

@@ -28,6 +28,8 @@ await discussions.CreateAsync(authorId, "Discussion 2", "numa numa e")
 
         // Assert
         response.Items.Should().BeEquivalentTo(expectedDiscussions.Reverse());
+        response.Items.Should().OnlyContain(discussion => discussion.ReactionCounters.Count == 0);
+        response.Items.Should().OnlyContain(discussion => discussion.ViewerReactions.Count == 0);
     }
 
     [Fact(DisplayName = "Get discussions by author of no discussions")]