Skip to content

Conversation

@clementAC
Copy link
Contributor

@clementAC clementAC commented Oct 22, 2024

Don't be scared of the number of files changed it's a simple file move.

Files to review are:

  • github actions
  • amplify.yml

I removed the crowdsec-doc directory and moved all the files to the top level.
As I needed to change the actions to remove the instructions on the working directory, I updated the actions to their last version, and we now use the lts node version (20).

As we change the working directory, we also need to tell Amplify where to generate the app. Before this commit, it was done in the web interface of amplify, but we can also have an amplify.yml file that will be processed by Amplify to take its instructions here.
I modified the node version and changed the working directory

@clementAC clementAC force-pushed the rearrange_repo branch 3 times, most recently from b3bd85f to ee9002f Compare October 22, 2024 14:47
@clementAC clementAC changed the base branch from main to warning_maintenance October 22, 2024 14:50
@aws-amplify-eu-west-1
Copy link

This pull request is automatically being deployed by Amplify Hosting (learn more).

Access this pull request here: https://pr-641.d1to60jd2gb6y6.amplifyapp.com

@clementAC clementAC force-pushed the warning_maintenance branch from 074a566 to f76f55d Compare October 28, 2024 10:51
@LaurenceJJones
Copy link
Member

Not to take away from this PR but foss team are hesitant to move all files because of the conflicts this will causes all others PR's. The only takeaway we will want to add is the amplify.yml so we can use the latest node version on preview and deployments.

@clementAC clementAC force-pushed the warning_maintenance branch from f76f55d to 2b66404 Compare October 30, 2024 14:03
Base automatically changed from warning_maintenance to main October 30, 2024 14:11
@clementAC clementAC closed this Oct 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants