Skip to content

Commit 004195f

Browse files
authored
update version matching check to handle trailing comma in setup_page.js (#11)
1 parent fd69565 commit 004195f

File tree

1 file changed

+3
-5
lines changed

1 file changed

+3
-5
lines changed

.github/workflows/release.yml

Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,6 @@ on:
1919

2020
jobs:
2121
create-release:
22-
2322
name: Create release
2423
runs-on: ubuntu-latest
2524
permissions:
@@ -97,7 +96,7 @@ jobs:
9796
fi
9897
# Check in appserver/static/javascript/setup_page.js
9998
# Example: v=v1.0.6
100-
JS_VERSION=$(sed -n 's/urlArgs\: "v=v\(.*\)"/\1/p' appserver/static/javascript/setup_page.js | sed 's/ //g' | tr -d '\r')
99+
JS_VERSION=$(sed -n 's/urlArgs\: "v=v\(.*\)",\{0,1\}/\1/p' appserver/static/javascript/setup_page.js | sed 's/ //g' | tr -d '\r')
101100
if [[ $JS_VERSION == "${{ env.VERSION_NUMBER }}" ]]
102101
then
103102
echo "appserver/static/javascript/setup_page.js VERSION OK"
@@ -110,7 +109,7 @@ jobs:
110109
- name: Set up Python
111110
uses: actions/setup-python@v5
112111
with:
113-
python-version: '3.9.16'
112+
python-version: "3.9.16"
114113

115114
- name: Install splunk toolkit
116115
run: |
@@ -148,7 +147,6 @@ jobs:
148147
body_path: CHANGELOG.txt
149148
name: ${{ env.VERSION_NUMBER }}
150149
tag_name: ${{ github.event.inputs.tag_name }}
151-
152150

153151
- name: Upload to SplunkBase
154152
if: github.event.inputs.publish-to-splunkbase == 'true'
@@ -159,4 +157,4 @@ jobs:
159157
-F "filename=${{ env.PACKAGE_NAME }}" \
160158
-F "cim_versions=5.x" \
161159
-F "splunk_versions=${{ github.event.inputs.splunk_versions }}" \
162-
-F "visibility=true"
160+
-F "visibility=true"

0 commit comments

Comments
 (0)