windows: fix service getting stuck on shutdown (#3733)

Author: blotus

cmd/crowdsec/run_in_svc.go

@@ -16,6 +16,10 @@ import (
 	"github.com/crowdsecurity/crowdsec/pkg/database"
 )
 
+func isWindowsService() (bool, error) {
+	return false, nil
+}
+
 func StartRunSvc() error {
 	var (
 		cConfig *csconfig.Config

cmd/crowdsec/run_in_svc_windows.go

@@ -15,6 +15,10 @@ import (
 	"github.com/crowdsecurity/crowdsec/pkg/database"
 )
 
+func isWindowsService() (bool, error) {
+	return svc.IsWindowsService()
+}
+
 func StartRunSvc() error {
 	const svcName = "CrowdSec"
 	const svcDescription = "Crowdsec IPS/IDS"
@@ -25,7 +29,7 @@ func StartRunSvc() error {
 	// It's a noop if profiling is not enabled
 	defer pprof.StopCPUProfile()
 
-	isRunninginService, err := svc.IsWindowsService()
+	isRunninginService, err := isWindowsService()
 	if err != nil {
 		return fmt.Errorf("failed to determine if we are running in windows service mode: %w", err)
 	}

cmd/crowdsec/serve.go

@@ -439,7 +439,12 @@ func Serve(cConfig *csconfig.Config, agentReady chan bool) error {
 		return nil
 	}
 
-	if cConfig.Common != nil && !flags.haveTimeMachine() {
+	isWindowsSvc, err := isWindowsService()
+	if err != nil {
+		return fmt.Errorf("failed to determine if we are running in windows service mode: %w", err)
+	}
+
+	if cConfig.Common != nil && !flags.haveTimeMachine() && !isWindowsSvc {
 		_ = csdaemon.Notify(csdaemon.Ready, log.StandardLogger())
 		// wait for signals
 		return HandleSignals(cConfig)