Skip to content

Commit 51d06a0

Browse files
committed
skip journalctl tests on windows
1 parent 36ed2ca commit 51d06a0

File tree

1 file changed

+25
-3
lines changed

1 file changed

+25
-3
lines changed

pkg/acquisition/config_test.go

Lines changed: 25 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,7 @@ import (
44
"os"
55
"path/filepath"
66
"regexp"
7+
"runtime"
78
"slices"
89
"strings"
910
"testing"
@@ -51,6 +52,21 @@ func wantErrFromYAML(t *testing.T, fileContent []byte) (want string, found bool)
5152
return strings.TrimSpace(string(m[1])), true
5253
}
5354

55+
func shouldSkip(t *testing.T, parsed *ParsedSourceConfig, gotErr error) bool {
56+
t.Helper()
57+
58+
if parsed == nil {
59+
return false
60+
}
61+
62+
// not supported in windows and will raise an error we are ignoring here.
63+
if parsed.Common.Source == "journalctl" && runtime.GOOS == "windows" && strings.Contains(gotErr.Error(), "datasource 'journalctl' is not available") {
64+
return true
65+
}
66+
67+
return false
68+
}
69+
5470
func TestParseSourceConfig(t *testing.T) {
5571
ctx := t.Context()
5672

@@ -81,19 +97,25 @@ func TestParseSourceConfig(t *testing.T) {
8197

8298
if s.expectValid {
8399
require.False(t, hasWant, "valid config must not include # wantErr: directive")
84-
_, err := ParseSourceConfig(ctx, fileContent, metrics.AcquisitionMetricsLevelNone, nil)
100+
parsed, err := ParseSourceConfig(ctx, fileContent, metrics.AcquisitionMetricsLevelNone, nil)
101+
if shouldSkip(t, parsed, err) {
102+
return
103+
}
85104
require.NoError(t, err)
86105
return
87106
}
88107

89108
// invalid
109+
90110
require.True(t, hasWant, "invalid config must include '# wantErr: <exact error>'")
91111
require.NotEmpty(t, wantErr, "wantErr directive found but empty")
92112

93-
_, err := ParseSourceConfig(ctx, fileContent, metrics.AcquisitionMetricsLevelNone, nil)
113+
parsed, err := ParseSourceConfig(ctx, fileContent, metrics.AcquisitionMetricsLevelNone, nil)
114+
if shouldSkip(t, parsed, err) {
115+
return
116+
}
94117
require.Error(t, err, "got no error, expected %q", wantErr)
95118
assert.Equal(t, wantErr, err.Error())
96-
// assert.Contains(t, err.Error(), wantErr)
97119
})
98120
}
99121
})

0 commit comments

Comments
 (0)