refact cmd/crowdsec: move plugin initialization to apiserver (#3668)

Author: mmetc

cmd/crowdsec/api.go

@@ -2,9 +2,7 @@ package main
 
 import (
 	"context"
-	"errors"
 	"fmt"
-	"runtime"
 	"time"
 
 	log "github.com/sirupsen/logrus"
@@ -25,24 +23,9 @@ func initAPIServer(ctx context.Context, cConfig *csconfig.Config) (*apiserver.AP
 		return nil, fmt.Errorf("unable to run local API: %w", err)
 	}
 
-	if hasPlugins(cConfig.API.Server.Profiles) {
-		log.Info("initiating plugin broker")
-		// On windows, the plugins are always run as medium-integrity processes, so we don't care about plugin_config
-		if cConfig.PluginConfig == nil && runtime.GOOS != "windows" {
-			return nil, errors.New("plugins are enabled, but the plugin_config section is missing in the configuration")
-		}
-
-		if cConfig.ConfigPaths.PluginDir == "" {
-			return nil, errors.New("plugins are enabled, but config_paths.plugin_dir is not defined")
-		}
-
-		err = pluginBroker.Init(ctx, cConfig.PluginConfig, cConfig.API.Server.Profiles, cConfig.ConfigPaths)
-		if err != nil {
-			return nil, fmt.Errorf("plugin broker: %w", err)
-		}
-
-		log.Info("initiated plugin broker")
-		apiServer.AttachPluginBroker(&pluginBroker)
+	err = apiServer.InitPlugins(ctx, cConfig, &pluginBroker)
+	if err != nil {
+		return nil, err
 	}
 
 	err = apiServer.InitController()
@@ -81,13 +64,3 @@ func serveAPIServer(apiServer *apiserver.APIServer) {
 	})
 	<-apiReady
 }
-
-func hasPlugins(profiles []*csconfig.ProfileCfg) bool {
-	for _, profile := range profiles {
-		if len(profile.Notifications) != 0 {
-			return true
-		}
-	}
-
-	return false
-}

pkg/apiserver/apiserver.go

@@ -10,6 +10,7 @@ import (
 	"net/http"
 	"os"
 	"path/filepath"
+	"runtime"
 	"strings"
 	"time"
 
@@ -547,6 +548,40 @@ func (s *APIServer) AttachPluginBroker(broker *csplugin.PluginBroker) {
 	s.controller.PluginChannel = broker.PluginChannel
 }
 
+func hasPlugins(profiles []*csconfig.ProfileCfg) bool {
+	for _, profile := range profiles {
+		if len(profile.Notifications) != 0 {
+			return true
+		}
+	}
+
+	return false
+}
+
+func (s *APIServer) InitPlugins(ctx context.Context, cConfig *csconfig.Config, pluginBroker *csplugin.PluginBroker) error {
+	if hasPlugins(cConfig.API.Server.Profiles) {
+		log.Info("initiating plugin broker")
+		// On windows, the plugins are always run as medium-integrity processes, so we don't care about plugin_config
+		if cConfig.PluginConfig == nil && runtime.GOOS != "windows" {
+			return errors.New("plugins are enabled, but the plugin_config section is missing in the configuration")
+		}
+
+		if cConfig.ConfigPaths.PluginDir == "" {
+			return errors.New("plugins are enabled, but config_paths.plugin_dir is not defined")
+		}
+
+		err := pluginBroker.Init(ctx, cConfig.PluginConfig, cConfig.API.Server.Profiles, cConfig.ConfigPaths)
+		if err != nil {
+			return fmt.Errorf("plugin broker: %w", err)
+		}
+
+		log.Info("initiated plugin broker")
+		s.AttachPluginBroker(pluginBroker)
+	}
+
+	return nil
+}
+
 func (s *APIServer) InitController() error {
 	err := s.controller.Init()
 	if err != nil {