wip appsec tests

Author: mmetc

pkg/acquisition/acquisition.go

@@ -90,6 +90,9 @@ func DataSourceConfigure(
 
 	if lapiClientAware, ok := dataSrc.(types.LAPIClientAware); ok {
 		cConfig := csconfig.GetConfig()
+		if cConfig.API == nil {
+			return nil, errors.New("crowdsec configuration not loaded while initializing appsec - this is a bug, plese report")
+		}
 		lapiClientAware.SetClientConfig(cConfig.API.Client)
 	}
 

pkg/acquisition/config_test.go

@@ -12,6 +12,8 @@ import (
 	"github.com/stretchr/testify/assert"
 	"github.com/stretchr/testify/require"
 
+	"github.com/crowdsecurity/crowdsec/pkg/csconfig"
+	"github.com/crowdsecurity/crowdsec/pkg/cwhub"
 	"github.com/crowdsecurity/crowdsec/pkg/metrics"
 )
 
@@ -61,6 +63,13 @@ func TestParseSourceConfig(t *testing.T) {
 		expectValid bool
 	}
 
+	// load a configuration, appsec needs it
+	_, _, err := csconfig.NewConfig("./testdata/config.yaml", false, false, true)
+	require.NoError(t, err)
+
+	// load a hub, appsec needs it
+	hub := cwhub.Hub{}
+
 	suites := []suite{
 		{name: "valid", root: filepath.Join("testdata", "valid"), expectValid: true},
 		{name: "invalid", root: filepath.Join("testdata", "invalid"), expectValid: false},
@@ -86,7 +95,7 @@ func TestParseSourceConfig(t *testing.T) {
 
 					if s.expectValid {
 						require.False(t, hasWant, "valid config must not include # wantErr: directive")
-						parsed, err := ParseSourceConfig(ctx, fileContent, metrics.AcquisitionMetricsLevelNone, nil)
+						parsed, err := ParseSourceConfig(ctx, fileContent, metrics.AcquisitionMetricsLevelNone, &hub)
 						require.NotNil(t, parsed)
 						require.NoError(t, err)
 						return
@@ -97,7 +106,7 @@ func TestParseSourceConfig(t *testing.T) {
 					require.True(t, hasWant, "invalid config must include '# wantErr: <exact error>'")
 					require.NotEmpty(t, wantErr, "wantErr directive found but empty")
 
-					parsed, err := ParseSourceConfig(ctx, fileContent, metrics.AcquisitionMetricsLevelNone, nil)
+					parsed, err := ParseSourceConfig(ctx, fileContent, metrics.AcquisitionMetricsLevelNone, &hub)
 					require.Nil(t, parsed)
 					require.Error(t, err, "got no error, expected %q", wantErr)
 					assert.Equal(t, wantErr, err.Error())

pkg/acquisition/modules/appsec/config.go

@@ -128,6 +128,10 @@ func (w *Source) Configure(_ context.Context, yamlConfig []byte, logger *log.Ent
 		return fmt.Errorf("unable to parse appsec configuration: %w", err)
 	}
 
+	if w.lapiClientConfig.Credentials == nil {
+		return fmt.Errorf("missing lapi client credentials")
+	}
+
 	w.lapiURL = fmt.Sprintf("%sv1/decisions/stream", w.lapiClientConfig.Credentials.URL)
 	w.AuthCache = NewAuthCache()
 

pkg/acquisition/testdata/config.yaml

@@ -0,0 +1,6 @@
+# minimal configuration to satisfy appsec
+config_paths:
+  data_dir: /path/to/data
+api:
+  client:
+    insecure_skip_verify: false

pkg/acquisition/testdata/invalid/appsec/appsec_config_required.yaml

@@ -0,0 +1,4 @@
+# wantErr: datasource of type appsec: unable to parse appsec configuration: appsec_config or appsec_config_path must be set
+source: appsec
+labels:
+  type: sometype

pkg/acquisition/testdata/invalid/appsec/invalid_appsec_config.yaml

@@ -0,0 +1,6 @@
+# wantErr: datasource of type appsec: unable to parse appsec configuration: cannot parse appsec configuration: [6:6] cannot unmarshal map[string]interface {} into Go struct field Configuration.AppsecConfig of type string
+source: appsec
+labels:
+  type: sometype
+appsec_config:
+  foo: bar

pkg/acquisition/testdata/invalid/appsec/labels_required.yaml

@@ -0,0 +1,2 @@
+# wantErr: missing labels
+source: appsec

pkg/acquisition/testdata/invalid/appsec/xxx.yaml

@@ -0,0 +1,5 @@
+# wantErr: datasource of type appsec: missing lapi client credentials
+source: appsec
+labels:
+  type: sometype
+appsec_config: something