unused parameters/errors

Author: mmetc

cmd/crowdsec/appsec_stub.go

@@ -6,6 +6,6 @@ import (
 	"github.com/crowdsecurity/crowdsec/pkg/cwhub"
 )
 
-func LoadAppsecRules(hub *cwhub.Hub) error {
+func LoadAppsecRules(_ *cwhub.Hub) error {
 	return nil
 }

cmd/crowdsec/crowdsec.go

@@ -79,10 +79,7 @@ func startParserRoutines(cConfig *csconfig.Config, parsers *parser.Parsers) {
 			parsersTomb.Go(func() error {
 				defer trace.CatchPanic("crowdsec/runParse")
 
-				if err := runParse(inputLineChan, inputEventChan, *parsers.Ctx, parsers.Nodes); err != nil {
-					// this error will never happen as parser.Parse is not able to return errors
-					return err
-				}
+				runParse(inputLineChan, inputEventChan, *parsers.Ctx, parsers.Nodes)
 
 				return nil
 			})
@@ -147,7 +144,6 @@ func startLPMetrics(ctx context.Context, cConfig *csconfig.Config, apiClient *ap
 		apiClient,
 		lpMetricsDefaultInterval,
 		log.WithField("service", "lpmetrics"),
-		[]string{},
 		datasources,
 		hub,
 	)

cmd/crowdsec/lpmetrics.go

@@ -88,7 +88,7 @@ func getHubState(hub *cwhub.Hub) models.HubItems {
 }
 
 // newStaticMetrics is called when the process starts, or reloads the configuration
-func newStaticMetrics(consoleOptions []string, datasources []acquisition.DataSource, hub *cwhub.Hub) staticMetrics {
+func newStaticMetrics(datasources []acquisition.DataSource, hub *cwhub.Hub) staticMetrics {
 	datasourceMap := map[string]int64{}
 
 	for _, ds := range datasources {
@@ -112,11 +112,10 @@ func NewMetricsProvider(
 	apic *apiclient.ApiClient,
 	interval time.Duration,
 	logger *logrus.Entry,
-	consoleOptions []string,
 	datasources []acquisition.DataSource,
 	hub *cwhub.Hub,
 ) *MetricsProvider {
-	static := newStaticMetrics(consoleOptions, datasources, hub)
+	static := newStaticMetrics(datasources, hub)
 
 	logger.Debugf("Detected %s %s (family: %s)", static.osName, static.osVersion, static.osFamily)
 

cmd/crowdsec/parse.go

@@ -59,12 +59,12 @@ func parseEvent(
 	return &parsed
 }
 
-func runParse(input chan pipeline.Event, output chan pipeline.Event, parserCTX parser.UnixParserCtx, nodes []parser.Node) error {
+func runParse(input chan pipeline.Event, output chan pipeline.Event, parserCTX parser.UnixParserCtx, nodes []parser.Node) {
 	for {
 		select {
 		case <-parsersTomb.Dying():
 			log.Infof("Killing parser routines")
-			return nil
+			return
 		case event := <-input:
 			parsed := parseEvent(event, parserCTX, nodes)
 			if parsed == nil {

cmd/crowdsec/win_service_manage.go

@@ -10,8 +10,6 @@ import (
 	"fmt"
 	"time"
 
-	//"time"
-
 	"golang.org/x/sys/windows/svc"
 	"golang.org/x/sys/windows/svc/mgr"
 )