unit tests: rename ./tests, ./test_data -> ./testdata (#3673)

* unit tests: rename ./tests, ./test_data -> ./testdata
* same for exprlib
* same for cticlient

Author: mmetc

pkg/cticlient/client_test.go

@@ -51,12 +51,12 @@ func fireHandler(req *http.Request) *http.Response {
 
 	//unmarshal data
 	if fireResponses == nil {
-		page1, err := os.ReadFile("tests/fire-page1.json")
+		page1, err := os.ReadFile("testdata/fire-page1.json")
 		if err != nil {
 			panic("can't read file")
 		}
 
-		page2, err := os.ReadFile("tests/fire-page2.json")
+		page2, err := os.ReadFile("testdata/fire-page2.json")
 		if err != nil {
 			panic("can't read file")
 		}

pkg/cticlient/tests/fire-page1.json renamed to pkg/cticlient/testdata/fire-page1.json

@@ -20,8 +20,6 @@ import (
 	"github.com/crowdsecurity/crowdsec/pkg/types"
 )
 
-const TestFolder = "tests"
-
 func getDBClient(t *testing.T) *database.Client {
 	t.Helper()
 
@@ -272,7 +270,7 @@ func TestRegexpCacheBehavior(t *testing.T) {
 	require.NoError(t, err)
 
 	filename := "test_data_re.txt"
-	err = FileInit(TestFolder, filename, "regex")
+	err = FileInit("testdata", filename, "regex")
 	require.NoError(t, err)
 
 	// cache with no TTL
@@ -305,7 +303,7 @@ func TestRegexpInFile(t *testing.T) {
 		t.Fatal(err)
 	}
 
-	err := FileInit(TestFolder, "test_data_re.txt", "regex")
+	err := FileInit("testdata", "test_data_re.txt", "regex")
 	if err != nil {
 		t.Fatal(err)
 	}
@@ -397,7 +395,7 @@ func TestFileInit(t *testing.T) {
 	}
 
 	for _, test := range tests {
-		err := FileInit(TestFolder, test.filename, test.types)
+		err := FileInit("testdata", test.filename, test.types)
 		if err != nil {
 			t.Fatal(err)
 		}
@@ -438,7 +436,7 @@ func TestFile(t *testing.T) {
 		t.Fatal(err)
 	}
 
-	err := FileInit(TestFolder, "test_data.txt", "string")
+	err := FileInit("testdata", "test_data.txt", "string")
 	if err != nil {
 		t.Fatal(err)
 	}

pkg/cticlient/tests/fire-page2.json renamed to pkg/cticlient/testdata/fire-page2.json

@@ -13,7 +13,7 @@ func TestJsonExtract(t *testing.T) {
 		t.Fatal(err)
 	}
 
-	err := FileInit(TestFolder, "test_data_re.txt", "regex")
+	err := FileInit("testdata", "test_data_re.txt", "regex")
 	if err != nil {
 		t.Fatal(err)
 	}
@@ -68,7 +68,7 @@ func TestJsonExtractUnescape(t *testing.T) {
 		t.Fatal(err)
 	}
 
-	err := FileInit(TestFolder, "test_data_re.txt", "regex")
+	err := FileInit("testdata", "test_data_re.txt", "regex")
 	if err != nil {
 		t.Fatal(err)
 	}
@@ -116,7 +116,7 @@ func TestJsonExtractSlice(t *testing.T) {
 		t.Fatal(err)
 	}
 
-	err := FileInit(TestFolder, "test_data_re.txt", "regex")
+	err := FileInit("testdata", "test_data_re.txt", "regex")
 	if err != nil {
 		t.Fatal(err)
 	}
@@ -178,7 +178,7 @@ func TestJsonExtractObject(t *testing.T) {
 		t.Fatal(err)
 	}
 
-	err := FileInit(TestFolder, "test_data_re.txt", "regex")
+	err := FileInit("testdata", "test_data_re.txt", "regex")
 	if err != nil {
 		t.Fatal(err)
 	}

pkg/exprhelpers/exprlib_test.go

@@ -38,7 +38,7 @@ func TestBucket(t *testing.T) {
 		tomb       = &tomb.Tomb{}
 	)
 
-	testdata := "./tests"
+	testdata := "./testdata"
 
 	hubCfg := &csconfig.LocalHubCfg{
 		HubDir:         filepath.Join(testdata, "hub"),