-
Notifications
You must be signed in to change notification settings - Fork 32
Description
We use ArgoCD with Helm and generate our Application resources via templates. Our templates use spec.source.helm.values to set a bunch of global values (stuff like version and environment name and owning team), and sets several valueFiles that may or may not exist in the chart using ignoreMissingValueFiles: true to make this OK. (We use this to let you customize a chart by environment or by multiple apps that install the same chart by using specially named values files.)
Occasionally we want to make some small tweaks to the chart that are best done with Kustomize and so your plugin is a very attractive option. However, it's hard to take our existing setup and just switch it to lovely. To make it easier to swap an app from the built-in helm plugin to lovely, it would be great if we could:
Directly set values in a YAML format (either as a string like(OK, looks likespec.source.helm.valuesor an object likespec.source.helm.valuesObject) within the Application spec (the built-in Helm support writes this to a temp file and passes it as the final--valuesoptionLOVELY_HELM_MERGEbasically does this, though it would be nice if this was the higher priority rather than coming before most of the values files)- Set an "ignore missing values files" flag (the built-in Helm support loops over specified values files and filters out those that don't exist if the flag is set)
Would a PR to add this functionality be likely to be accepted?