Fix all golangci-lint issues

- Fix var-naming: rename userIdParam/userIdFlag to userIDParam/userIDFlag
- Fix rangeValCopy: use index-based access with pointers in range loops
- Fix ifElseChain: convert if-else to switch statement in naming.go
- Fix appendAssign: properly initialize slice before appending in load.go
- Fix gofmt/goimports formatting issues
- Fix staticcheck SA4017: add hasAnyPrefix helper for prefix checks in sse.go
- Update .golangci.yml: replace deprecated exportloopref with copyloopvar

Co-Authored-By: Claude Opus 4.5 <[email protected]>

Author: bilby91

.golangci.yml

@@ -18,7 +18,7 @@ linters:
     - unconvert
     - bodyclose
     - nilerr
-    - exportloopref
+    - copyloopvar
     - gocritic
     - revive
 

cmd/opencligen/main.go

@@ -7,10 +7,11 @@ import (
 	"os/exec"
 	"path/filepath"
 
+	"github.com/spf13/cobra"
+
 	"github.com/crunchloop/opencligen/internal/gen"
 	"github.com/crunchloop/opencligen/internal/plan"
 	"github.com/crunchloop/opencligen/internal/spec"
-	"github.com/spf13/cobra"
 )
 
 // Version information set by ldflags during build
@@ -155,9 +156,11 @@ func printPlan(p *plan.Plan) {
 	fmt.Printf("\n=== Command Plan for %s ===\n\n", p.AppName)
 	fmt.Printf("Module: %s\n\n", p.ModuleName)
 
-	for _, group := range p.Groups {
+	for gi := range p.Groups {
+		group := &p.Groups[gi]
 		fmt.Printf("Group: %s\n", group.Name)
-		for _, op := range group.Operations {
+		for oi := range group.Operations {
+			op := &group.Operations[oi]
 			cmdPath := ""
 			for i, part := range op.CommandPath {
 				if i > 0 {
@@ -167,7 +170,8 @@ func printPlan(p *plan.Plan) {
 			}
 
 			flags := ""
-			for _, f := range op.Flags {
+			for fi := range op.Flags {
+				f := &op.Flags[fi]
 				if flags != "" {
 					flags += ", "
 				}
@@ -179,7 +183,8 @@ func printPlan(p *plan.Plan) {
 			}
 
 			positionals := ""
-			for _, pos := range op.Positionals {
+			for pi := range op.Positionals {
+				pos := &op.Positionals[pi]
 				positionals += fmt.Sprintf(" <%s>", pos.Name)
 			}
 

cmd/opencligen/main_test.go

@@ -68,9 +68,9 @@ func createTestCommand() *cobra.Command {
 
 func TestGen_MissingRequiredFlags(t *testing.T) {
 	tests := []struct {
-		name        string
-		args        []string
-		wantErrMsg  string
+		name       string
+		args       []string
+		wantErrMsg string
 	}{
 		{
 			name:       "missing all flags",

internal/gen/generate.go

@@ -178,8 +178,9 @@ func (g *Generator) generateCommands() error {
 		}
 
 		// Generate operation files
-		for _, op := range group.Operations {
-			if err := g.generateOperation(opTmpl, group, op); err != nil {
+		for oi := range group.Operations {
+			op := &group.Operations[oi]
+			if err := g.generateOperation(opTmpl, group, *op); err != nil {
 				return fmt.Errorf("failed to generate operation %s: %w", op.OperationID, err)
 			}
 		}
@@ -194,7 +195,8 @@ func (g *Generator) generateOperation(tmpl *template.Template, group plan.GroupP
 
 	// Build positionals data
 	positionals := make([]map[string]interface{}, len(op.Positionals))
-	for i, p := range op.Positionals {
+	for i := range op.Positionals {
+		p := &op.Positionals[i]
 		positionals[i] = map[string]interface{}{
 			"Name":    p.Name,
 			"VarName": toVarName(p.FlagName),
@@ -203,7 +205,8 @@ func (g *Generator) generateOperation(tmpl *template.Template, group plan.GroupP
 
 	// Build flags data
 	flags := make([]map[string]interface{}, len(op.Flags))
-	for i, p := range op.Flags {
+	for i := range op.Flags {
+		p := &op.Flags[i]
 		defaultStr := ""
 		if p.Default != nil {
 			defaultStr = fmt.Sprintf("%v", p.Default)
@@ -225,14 +228,14 @@ func (g *Generator) generateOperation(tmpl *template.Template, group plan.GroupP
 
 	// Build use string with positionals
 	use := cmdName
-	for _, p := range op.Positionals {
-		use += fmt.Sprintf(" <%s>", p.Name)
+	for i := range op.Positionals {
+		use += fmt.Sprintf(" <%s>", op.Positionals[i].Name)
 	}
 
 	// Check if any flags are required
 	hasRequiredFlags := false
-	for _, p := range op.Flags {
-		if p.Required {
+	for i := range op.Flags {
+		if op.Flags[i].Required {
 			hasRequiredFlags = true
 			break
 		}

internal/gen/runtime/sse.go

@@ -19,6 +19,16 @@ func isEventStream(contentType string) bool {
 	return strings.Contains(contentType, "text/event-stream")
 }
 
+// hasAnyPrefix checks if s has any of the given prefixes
+func hasAnyPrefix(s string, prefixes ...string) bool {
+	for _, prefix := range prefixes {
+		if strings.HasPrefix(s, prefix) {
+			return true
+		}
+	}
+	return false
+}
+
 // handleSSE handles Server-Sent Events response
 func handleSSE(reader io.Reader, out io.Writer) error {
 	scanner := bufio.NewScanner(reader)
@@ -69,9 +79,7 @@ func handleSSE(reader io.Reader, out io.Writer) error {
 		}
 
 		// Handle other SSE fields (event, id, retry) - we just skip them for now
-		if strings.HasPrefix(line, "event:") ||
-			strings.HasPrefix(line, "id:") ||
-			strings.HasPrefix(line, "retry:") {
+		if hasAnyPrefix(line, "event:", "id:", "retry:") {
 			continue
 		}
 	}

internal/plan/builder.go

@@ -15,12 +15,13 @@ func Build(s *spec.Spec, appName, moduleName string) *Plan {
 
 	// Group operations by tag
 	groups := make(map[string][]spec.Operation)
-	for _, op := range s.Operations {
+	for i := range s.Operations {
+		op := &s.Operations[i]
 		tag := op.Tag
 		if tag == "" {
 			tag = "default"
 		}
-		groups[tag] = append(groups[tag], op)
+		groups[tag] = append(groups[tag], *op)
 	}
 
 	// Sort group names for deterministic output
@@ -45,8 +46,8 @@ func buildGroupPlan(name string, ops []spec.Operation) GroupPlan {
 		Name: DeriveGroupName(name),
 	}
 
-	for _, op := range ops {
-		opPlan := buildOpPlan(name, op)
+	for i := range ops {
+		opPlan := buildOpPlan(name, ops[i])
 		group.Operations = append(group.Operations, opPlan)
 	}
 
@@ -88,17 +89,19 @@ func buildOpPlan(groupName string, op spec.Operation) OpPlan {
 	var pathParams []spec.Param
 	var otherParams []spec.Param
 
-	for _, p := range op.Params {
+	for i := range op.Params {
+		p := &op.Params[i]
 		if p.In == "path" {
-			pathParams = append(pathParams, p)
+			pathParams = append(pathParams, *p)
 		} else {
-			otherParams = append(otherParams, p)
+			otherParams = append(otherParams, *p)
 		}
 	}
 
 	// Path params become positionals by default (in path order)
-	for _, p := range pathParams {
-		paramPlan := buildParamPlan(p)
+	for i := range pathParams {
+		p := &pathParams[i]
+		paramPlan := buildParamPlan(*p)
 
 		// Check if explicitly marked as non-positional
 		isPositional := true
@@ -114,8 +117,8 @@ func buildOpPlan(groupName string, op spec.Operation) OpPlan {
 	}
 
 	// Other params become flags
-	for _, p := range otherParams {
-		paramPlan := buildParamPlan(p)
+	for i := range otherParams {
+		paramPlan := buildParamPlan(otherParams[i])
 		opPlan.Flags = append(opPlan.Flags, paramPlan)
 	}
 

internal/plan/naming.go

@@ -64,7 +64,8 @@ func toKebabCase(s string) string {
 
 	var result strings.Builder
 	for i, r := range s {
-		if unicode.IsUpper(r) {
+		switch {
+		case unicode.IsUpper(r):
 			if i > 0 {
 				// Don't add hyphen if previous char was already uppercase (e.g., "ID" -> "id")
 				prev := rune(s[i-1])
@@ -73,9 +74,9 @@ func toKebabCase(s string) string {
 				}
 			}
 			result.WriteRune(unicode.ToLower(r))
-		} else if r == '_' || r == ' ' {
+		case r == '_' || r == ' ':
 			result.WriteRune('-')
-		} else {
+		default:
 			result.WriteRune(r)
 		}
 	}

internal/plan/plan_test.go

@@ -138,15 +138,15 @@ func TestBuild_TasksCreateHasUserIdAndDataFlags(t *testing.T) {
 	}
 
 	// Check for --user-id flag (X-User-Id header)
-	var userIdFlag *ParamPlan
+	var userIDFlag *ParamPlan
 	for i := range createOp.Flags {
 		if createOp.Flags[i].FlagName == "user-id" {
-			userIdFlag = &createOp.Flags[i]
+			userIDFlag = &createOp.Flags[i]
 			break
 		}
 	}
 
-	if userIdFlag == nil {
+	if userIDFlag == nil {
 		t.Error("expected --user-id flag (from X-User-Id header)")
 	}
 

internal/runtime_skel/sse.go

@@ -19,6 +19,16 @@ func isEventStream(contentType string) bool {
 	return strings.Contains(contentType, "text/event-stream")
 }
 
+// hasAnyPrefix checks if s has any of the given prefixes
+func hasAnyPrefix(s string, prefixes ...string) bool {
+	for _, prefix := range prefixes {
+		if strings.HasPrefix(s, prefix) {
+			return true
+		}
+	}
+	return false
+}
+
 // handleSSE handles Server-Sent Events response
 func handleSSE(reader io.Reader, out io.Writer) error {
 	scanner := bufio.NewScanner(reader)
@@ -69,9 +79,7 @@ func handleSSE(reader io.Reader, out io.Writer) error {
 		}
 
 		// Handle other SSE fields (event, id, retry) - we just skip them for now
-		if strings.HasPrefix(line, "event:") ||
-			strings.HasPrefix(line, "id:") ||
-			strings.HasPrefix(line, "retry:") {
+		if hasAnyPrefix(line, "event:", "id:", "retry:") {
 			continue
 		}
 	}

internal/spec/load.go

@@ -122,7 +122,9 @@ func extractOperation(path, method string, op *openapi3.Operation, pathParams op
 	}
 
 	// Extract parameters (path-level + operation-level)
-	allParams := append(pathParams, op.Parameters...)
+	allParams := make([]*openapi3.ParameterRef, 0, len(pathParams)+len(op.Parameters))
+	allParams = append(allParams, pathParams...)
+	allParams = append(allParams, op.Parameters...)
 	for _, paramRef := range allParams {
 		if paramRef == nil || paramRef.Value == nil {
 			continue