code review

Author: crusaderky

src/array_api_extra/_lib/_funcs.py

@@ -312,10 +312,9 @@ def isclose(
     rtol: float = 1e-05,
     atol: float = 1e-08,
     equal_nan: bool = False,
-    xp: ModuleType | None = None,
+    xp: ModuleType,
 ) -> Array:  # numpydoc ignore=PR01,RT01
     """See docstring in array_api_extra._delegation."""
-    xp = array_namespace(a, b) if xp is None else xp
 
     a_inexact = xp.isdtype(a.dtype, ("real floating", "complex floating"))
     b_inexact = xp.isdtype(b.dtype, ("real floating", "complex floating"))

src/array_api_extra/_lib/_testing.py

@@ -136,7 +136,7 @@ def xp_assert_close(
 
     Notes
     -----
-    The default `atol` and `rtol` differ from `xp.all(xpx.allclose(a, b))`.
+    The default `atol` and `rtol` differ from `xp.all(xpx.isclose(a, b))`.
     """
     xp = _check_ns_shape_dtype(actual, desired)