Skip to content

Commit cef1bbe

Browse files
committed
Code review
1 parent c853b58 commit cef1bbe

File tree

2 files changed

+4
-3
lines changed

2 files changed

+4
-3
lines changed

src/array_api_extra/_lib/_utils/_helpers.py

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -279,6 +279,9 @@ def capabilities(xp: ModuleType) -> dict[str, int]:
279279
"""
280280
Return patched ``xp.__array_namespace_info__().capabilities()``.
281281
282+
TODO this helper should be eventually removed once all the special cases
283+
it handles are fixed in the respective backends.
284+
282285
Parameters
283286
----------
284287
xp : array_namespace

tests/test_funcs.py

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -838,9 +838,7 @@ def test_all_equal(self, xp: ModuleType):
838838
xp_assert_equal(nunique(a), xp.asarray(1))
839839

840840
@pytest.mark.xfail_xp_backend(Backend.DASK, reason="No equal_nan kwarg in unique")
841-
@pytest.mark.xfail_xp_backend(
842-
Backend.SPARSE, reason="Non-compliant equal_nan=True behaviour"
843-
)
841+
@pytest.mark.xfail_xp_backend(Backend.SPARSE, reason="sparse#855")
844842
def test_nan(self, xp: ModuleType, library: Backend):
845843
if library.like(Backend.NUMPY) and NUMPY_VERSION < (1, 24):
846844
pytest.xfail("NumPy <1.24 has no equal_nan kwarg in unique")

0 commit comments

Comments
 (0)