Skip to content

Commit 8e0474c

Browse files
authored
Chore: update cubecl + fix no-std (tracel-ai#3771)
* Update rev and loader changes * Update rev
1 parent 0ad6c88 commit 8e0474c

File tree

5 files changed

+30
-31
lines changed

5 files changed

+30
-31
lines changed

Cargo.lock

Lines changed: 20 additions & 20 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

Cargo.toml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -169,9 +169,9 @@ portable-atomic = { version = "1.11.1" }
169169
portable-atomic-util = { version = "0.2.4", features = ["alloc"] }
170170

171171
### For the main burn branch. ###
172-
cubecl = { git = "https://github.com/tracel-ai/cubecl", default-features = false, rev = "ad03f7892f4069d3406f936fd9fa3ac3b090c1fe" }
173-
cubecl-common = { git = "https://github.com/tracel-ai/cubecl", default-features = false, rev = "ad03f7892f4069d3406f936fd9fa3ac3b090c1fe" }
174-
cubecl-quant = { git = "https://github.com/tracel-ai/cubecl", default-features = false, rev = "ad03f7892f4069d3406f936fd9fa3ac3b090c1fe" }
172+
cubecl = { git = "https://github.com/tracel-ai/cubecl", default-features = false, rev = "98eb9d27624375fb11d4a97febd364b049933fdc" }
173+
cubecl-common = { git = "https://github.com/tracel-ai/cubecl", default-features = false, rev = "98eb9d27624375fb11d4a97febd364b049933fdc" }
174+
cubecl-quant = { git = "https://github.com/tracel-ai/cubecl", default-features = false, rev = "98eb9d27624375fb11d4a97febd364b049933fdc" }
175175
### For local development. ###
176176
# cubecl = { path = "../cubecl/crates/cubecl", default-features = false }
177177
# cubecl-common = { path = "../cubecl/crates/cubecl-common", default-features = false }

crates/burn-cubecl-fusion/src/matmul/optimization.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@ use burn_ir::TensorIr;
2222
use cubecl::features::TypeUsage;
2323
use cubecl::matmul::components::AccG;
2424
use cubecl::matmul::components::AccS;
25-
use cubecl::matmul::components::tile::loader::Filled;
25+
use cubecl::matmul::components::tile::reader::Filled;
2626
use cubecl::matmul::kernels::layered::Selection;
2727
use cubecl::matmul::kernels::layered::double_buffering::CyclicDoubleBufferingAlgorithm;
2828
use cubecl::matmul::kernels::layered::double_buffering::DoubleBufferingArgs;

crates/burn-cubecl-fusion/src/shared/io.rs

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -248,8 +248,7 @@ pub fn input_as_linear_view<C: CubePrimitive>(
248248
#[comptime] pos: u32,
249249
) -> View<Line<C>, u32> {
250250
let slice = input_as_slice::<Line<C>>(inputs, pos);
251-
let line_size = slice.line_size();
252-
let layout = LinearLayout::new_Plain(PlainLayout::new(slice.len(), comptime!(line_size as u8)));
251+
let layout = LinearLayout::new_Plain(PlainLayout::new(slice.len()));
253252
View::new::<Slice<Line<C>>, u32>(&slice, layout)
254253
}
255254

crates/burn-cubecl/src/kernel/matmul/tune/base.rs

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
use burn_tensor::DType;
22
use cubecl::{
33
matmul::{
4-
MatmulInputHandleRef, Strategy, SyncLoadingStrategy, SyncPartialLoadingStrategy,
4+
MatmulInputHandleRef, Strategy, SyncPartialReadingStrategy, SyncReadingStrategy,
55
components::{AccG, MatmulKind},
66
kernels::layered::{
77
Selection, TileSizeSelection, double_buffering::DoubleBufferingArgs,
@@ -161,7 +161,7 @@ fn matmul_simple<R: CubeRuntime, E: MatmulElement>(
161161
) -> Result<(), String> {
162162
cubecl::matmul::launch_ref::<R, E>(
163163
&Strategy::Simple(
164-
SyncLoadingStrategy::Cyclic,
164+
SyncReadingStrategy::Cyclic,
165165
Selection::Inferred(SimpleArgs { multi_rows: false }),
166166
),
167167
&lhs.client,
@@ -179,7 +179,7 @@ fn matmul_simple_multi_rows<R: CubeRuntime, E: MatmulElement>(
179179
) -> Result<(), String> {
180180
cubecl::matmul::launch_ref::<R, E>(
181181
&Strategy::Simple(
182-
SyncLoadingStrategy::Cyclic,
182+
SyncReadingStrategy::Cyclic,
183183
Selection::Inferred(SimpleArgs { multi_rows: true }),
184184
),
185185
&lhs.client,
@@ -197,7 +197,7 @@ fn matmul_double_buffering<R: CubeRuntime, E: MatmulElement>(
197197
) -> Result<(), String> {
198198
cubecl::matmul::launch_ref::<R, E>(
199199
&Strategy::DoubleBuffering(
200-
SyncPartialLoadingStrategy::Tilewise,
200+
SyncPartialReadingStrategy::Tilewise,
201201
Selection::Inferred(DoubleBufferingArgs { specialized: false }),
202202
),
203203
&lhs.client,
@@ -215,7 +215,7 @@ fn matmul_double_buffering_specialized<R: CubeRuntime, E: MatmulElement>(
215215
) -> Result<(), String> {
216216
cubecl::matmul::launch_ref::<R, E>(
217217
&Strategy::DoubleBuffering(
218-
SyncPartialLoadingStrategy::Tilewise,
218+
SyncPartialReadingStrategy::Tilewise,
219219
Selection::Inferred(DoubleBufferingArgs { specialized: true }),
220220
),
221221
&lhs.client,

0 commit comments

Comments
 (0)