Skip to content

Commit b16c3b5

Browse files
Josh-MatsuokaJosh-Matsuoka
authored
feat(diagnostics): Add diagnostics buckets setup (#265)
1 parent 9d8aa69 commit b16c3b5

File tree

6 files changed

+38
-2
lines changed

6 files changed

+38
-2
lines changed

‎charts/cryostat/README.md‎

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -193,6 +193,8 @@ certificate issuance and rotation.
193193
| `storage.buckets.names.archivedReports` | the name of the storage bucket containing the Automated Analysis Report for archived Flight Recordings | `archivedreports` |
194194
| `storage.buckets.names.eventTemplates` | the name of the storage bucket containing Custom Event Templates | `eventtemplates` |
195195
| `storage.buckets.names.jmcAgentProbeTemplates` | the name of the storage bucket containing JMC Agent Probe Templates | `probes` |
196+
| `storage.buckets.names.threadDumps` | the name of the storage bucket containing archived Thread Dumps | `threaddumps` |
197+
| `storage.buckets.names.heapDumps` | the name of the storage bucket containing archived Heap Dumps | `heapdumps` |
196198
| `storage.buckets.names.metadata` | the name of the storage bucket containing files' metadata. Only used if storage.provider.metadata.storageMode is set to 'bucket'. | `metadata` |
197199
| `storage.encryption.enabled` | Enable at-rest encryption of stored objects. The storage container will generate a secret key for each stored object and use this key to encrypt and decrypt objects transparently. The key is written to the object metadata, so in the default storage container configuration this only adds a small layer of additional security | `true` |
198200
| `storage.podAnnotations` | Annotations to be applied to the Storage Pods | `{}` |

‎charts/cryostat/templates/cryostat_deployment.yaml‎

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -96,6 +96,10 @@ spec:
9696
value: {{ .Values.storage.buckets.names.eventTemplates }}
9797
- name: STORAGE_BUCKETS_PROBE_TEMPLATES_NAME
9898
value: {{ .Values.storage.buckets.names.jmcAgentProbeTemplates }}
99+
- name: STORAGE_BUCKETS_THREAD_DUMPS_NAME
100+
value: {{ .Values.storage.buckets.names.threadDumps }}
101+
- name: STORAGE_BUCKETS_HEAP_DUMPS_NAME
102+
value: {{ .Values.storage.buckets.names.heapDumps }}
99103
- name: STORAGE_BUCKETS_METADATA_NAME
100104
value: {{ .Values.storage.buckets.names.metadata }}
101105
- name: CRYOSTAT_SERVICES_REPORTS_STORAGE_CACHE_NAME

‎charts/cryostat/tests/cryostat_deployment_test.yaml‎

Lines changed: 14 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -109,6 +109,12 @@ tests:
109109
- equal:
110110
path: spec.template.spec.containers[?(@.name=='cryostat')].env[?(@.name=='STORAGE_BUCKETS_PROBE_TEMPLATES_NAME')].value
111111
value: "probes"
112+
- equal:
113+
path: spec.template.spec.containers[?(@.name=='cryostat')].env[?(@.name=='STORAGE_BUCKETS_THREAD_DUMPS_NAME')].value
114+
value: "threaddumps"
115+
- equal:
116+
path: spec.template.spec.containers[?(@.name=='cryostat')].env[?(@.name=='STORAGE_BUCKETS_HEAP_DUMPS_NAME')].value
117+
value: "heapdumps"
112118
- equal:
113119
path: spec.template.spec.containers[?(@.name=='cryostat')].env[?(@.name=='STORAGE_BUCKETS_METADATA_NAME')].value
114120
value: "metadata"
@@ -207,6 +213,8 @@ tests:
207213
eventTemplates: c
208214
jmcAgentProbeTemplates: d
209215
metadata: e
216+
threadDumps: f
217+
heapDumps: g
210218
asserts:
211219
- equal:
212220
path: spec.template.spec.containers[?(@.name=='cryostat')].env[?(@.name=='STORAGE_METADATA_STORAGE_MODE')].value
@@ -226,6 +234,12 @@ tests:
226234
- equal:
227235
path: spec.template.spec.containers[?(@.name=='cryostat')].env[?(@.name=='STORAGE_BUCKETS_METADATA_NAME')].value
228236
value: "e"
237+
- equal:
238+
path: spec.template.spec.containers[?(@.name=='cryostat')].env[?(@.name=='STORAGE_BUCKETS_THREAD_DUMPS_NAME')].value
239+
value: "f"
240+
- equal:
241+
path: spec.template.spec.containers[?(@.name=='cryostat')].env[?(@.name=='STORAGE_BUCKETS_HEAP_DUMPS_NAME')].value
242+
value: "g"
229243

230244
- it: should allow disabling S3 TLS validation
231245
set:

‎charts/cryostat/tests/storage_deployment_test.yaml‎

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -69,7 +69,7 @@ tests:
6969
value: "Always"
7070
- equal:
7171
path: spec.template.spec.containers[?(@.name=='cryostat-storage')].env[?(@.name=='CRYOSTAT_BUCKETS')].value
72-
value: "archivedrecordings,archivedreports,eventtemplates,metadata,probes"
72+
value: "archivedrecordings,archivedreports,eventtemplates,heapdumps,metadata,probes,threaddumps"
7373
- equal:
7474
path: spec.template.spec.containers[?(@.name=='cryostat-storage')].env[?(@.name=='CRYOSTAT_ACCESS_KEY')].valueFrom.secretKeyRef
7575
value:
@@ -147,10 +147,12 @@ tests:
147147
archivedReports: c
148148
eventTemplates: d
149149
jmcAgentProbeTemplates: e
150+
threadDumps: f
151+
heapDumps: g
150152
asserts:
151153
- equal:
152154
path: spec.template.spec.containers[?(@.name=='cryostat-storage')].env[?(@.name=='CRYOSTAT_BUCKETS')].value
153-
value: "a,b,c,d,e"
155+
value: "a,b,c,d,e,f,g"
154156

155157
- it: should allow disabling at-rest encryption
156158
set:

‎charts/cryostat/values.schema.json‎

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -739,6 +739,16 @@
739739
"description": "the name of the storage bucket containing JMC Agent Probe Templates",
740740
"default": "probes"
741741
},
742+
"threadDumps": {
743+
"type": "string",
744+
"description": "the name of the storage bucket containing archived Thread Dumps",
745+
"default": "threaddumps"
746+
},
747+
"heapDumps": {
748+
"type": "string",
749+
"description": "the name of the storage bucket containing archived Heap Dumps",
750+
"default": "heapdumps"
751+
},
742752
"metadata": {
743753
"type": "string",
744754
"description": "the name of the storage bucket containing files' metadata. Only used if storage.provider.metadata.storageMode is set to 'bucket'.",

‎charts/cryostat/values.yaml‎

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -300,6 +300,10 @@ storage:
300300
eventTemplates: eventtemplates
301301
## @param storage.buckets.names.jmcAgentProbeTemplates the name of the storage bucket containing JMC Agent Probe Templates
302302
jmcAgentProbeTemplates: probes
303+
## @param storage.buckets.names.threadDumps the name of the storage bucket containing archived Thread Dumps
304+
threadDumps: threaddumps
305+
## @param storage.buckets.names.heapDumps the name of the storage bucket containing archived Heap Dumps
306+
heapDumps: heapdumps
303307
## @param storage.buckets.names.metadata the name of the storage bucket containing files' metadata. Only used if storage.provider.metadata.storageMode is set to 'bucket'.
304308
metadata: metadata
305309
encryption:

0 commit comments

Comments
 (0)