DI qualifier fixup, setting storageMode=noop allows selection of no-op service

Author: andrewazores

src/main/java/io/cryostat/recordings/BucketedArchivedRecordingMetadataService.java

@@ -30,7 +30,6 @@
 import jakarta.enterprise.context.ApplicationScoped;
 import jakarta.enterprise.event.Observes;
 import jakarta.inject.Inject;
-import jakarta.ws.rs.Produces;
 import org.eclipse.microprofile.config.inject.ConfigProperty;
 import org.jboss.logging.Logger;
 import software.amazon.awssdk.core.sync.RequestBody;
@@ -39,7 +38,6 @@
 import software.amazon.awssdk.services.s3.model.GetObjectRequest;
 import software.amazon.awssdk.services.s3.model.PutObjectRequest;
 
-@Produces
 @ApplicationScoped
 @LookupIfProperty(
         name = ConfigProperties.ARCHIVED_RECORDINGS_METADATA_STORAGE_MODE,

src/main/java/io/cryostat/recordings/NoopArchivedRecordingMetadataService.java

@@ -18,16 +18,17 @@
 import java.io.IOException;
 import java.util.Optional;
 
+import io.cryostat.ConfigProperties;
 import io.cryostat.recordings.ActiveRecordings.Metadata;
 
 import com.fasterxml.jackson.core.JsonProcessingException;
-import io.quarkus.arc.DefaultBean;
+import io.quarkus.arc.lookup.LookupIfProperty;
 import jakarta.enterprise.context.ApplicationScoped;
-import jakarta.ws.rs.Produces;
 
-@Produces
 @ApplicationScoped
-@DefaultBean
+@LookupIfProperty(
+        name = ConfigProperties.ARCHIVED_RECORDINGS_METADATA_STORAGE_MODE,
+        stringValue = NoopArchivedRecordingMetadataService.METADATA_STORAGE_MODE_NOOP)
 /**
  * No-op implementation of {@link ArchivedRecordingMetadataService}. The default metadata storage
  * mode is 'tagging', which uses embedded object tags and is directly implemented within {@link
@@ -37,6 +38,8 @@
  */
 class NoopArchivedRecordingMetadataService implements ArchivedRecordingMetadataService {
 
+    static final String METADATA_STORAGE_MODE_NOOP = "noop";
+
     @Override
     public void create(String storageKey, Metadata metadata) throws JsonProcessingException {}
 

src/main/java/io/cryostat/recordings/RecordingHelper.java

@@ -91,6 +91,7 @@
 import io.vertx.mutiny.ext.web.multipart.MultipartForm;
 import jakarta.enterprise.context.ApplicationScoped;
 import jakarta.enterprise.event.Observes;
+import jakarta.enterprise.inject.Instance;
 import jakarta.inject.Inject;
 import jakarta.persistence.PersistenceException;
 import jakarta.transaction.Transactional;
@@ -166,7 +167,7 @@ public class RecordingHelper {
     @Inject TargetTemplateService.Factory targetTemplateServiceFactory;
     @Inject S3TemplateService customTemplateService;
     @Inject PresetTemplateService presetTemplateService;
-    @Inject ArchivedRecordingMetadataService metadataService;
+    @Inject Instance<ArchivedRecordingMetadataService> metadataService;
     @Inject Scheduler scheduler;
 
     @Inject
@@ -835,8 +836,12 @@ public ArchivedRecording archiveRecording(ActiveRecording recording, String save
             if (useObjectTagging()) {
                 builder = builder.tagging(createActiveRecordingTagging(recording));
             } else {
-                metadataService.create(
-                        recording.target.jvmId, filename, createActiveRecordingMetadata(recording));
+                metadataService
+                        .get()
+                        .create(
+                                recording.target.jvmId,
+                                filename,
+                                createActiveRecordingMetadata(recording));
             }
             CreateMultipartUploadRequest request = builder.build();
             multipartId = storage.createMultipartUpload(request).uploadId();
@@ -991,7 +996,7 @@ public Optional<Metadata> getArchivedRecordingMetadata(String storageKey) {
                                                         .build())
                                         .tagSet()));
             }
-            return metadataService.read(storageKey);
+            return metadataService.get().read(storageKey);
         } catch (NoSuchKeyException nske) {
             logger.warn(nske);
             return Optional.empty();
@@ -1135,7 +1140,7 @@ public void deleteArchivedRecording(String jvmId, String filename) {
         }
 
         if (!useObjectTagging()) {
-            metadataService.delete(jvmId, filename);
+            metadataService.get().delete(jvmId, filename);
         }
 
         var event =
@@ -1260,7 +1265,7 @@ public ArchivedRecording uploadArchivedRecording(
             requestBuilder = requestBuilder.tagging(createMetadataTagging(new Metadata(labels)));
         } else {
             try {
-                metadataService.create(jvmId, filename, metadata);
+                metadataService.get().create(jvmId, filename, metadata);
             } catch (JsonProcessingException jpe) {
                 throw new InternalServerErrorException(jpe);
             }
@@ -1311,7 +1316,7 @@ public ArchivedRecording updateArchivedRecordingMetadata(
                             .build());
         } else {
             try {
-                metadataService.update(jvmId, filename, updatedMetadata);
+                metadataService.get().update(jvmId, filename, updatedMetadata);
             } catch (JsonProcessingException e) {
                 throw new InternalServerErrorException(e);
             }