Skip to content

Commit 791eabd

Browse files
authored
test(s3): simplify s3 configurations (#919)
* test(s3): simplify S3 configurations * remove env var setting config property to default value * expose minio console port * remove unused env var
1 parent e401344 commit 791eabd

File tree

4 files changed

+12
-28
lines changed

4 files changed

+12
-28
lines changed

compose/s3-cloudserver.yml

Lines changed: 10 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -4,14 +4,10 @@ services:
44
s3:
55
condition: service_healthy
66
environment:
7-
STORAGE_BUCKETS_ARCHIVES_NAME: archivedrecordings
87
QUARKUS_S3_ENDPOINT_OVERRIDE: http://s3:8000
98
STORAGE_EXT_URL: /storage/
109
QUARKUS_S3_PATH_STYLE_ACCESS: "true" # needed since compose setup does not support DNS subdomain resolution
1110
QUARKUS_S3_AWS_REGION: us-east-1
12-
QUARKUS_S3_AWS_CREDENTIALS_TYPE: static
13-
QUARKUS_S3_AWS_CREDENTIALS_STATIC_PROVIDER_ACCESS_KEY_ID: accessKey1
14-
QUARKUS_S3_AWS_CREDENTIALS_STATIC_PROVIDER_SECRET_ACCESS_KEY: verySecretKey1
1511
AWS_ACCESS_KEY_ID: accessKey1
1612
AWS_SECRET_ACCESS_KEY: verySecretKey1
1713
s3:
@@ -27,13 +23,13 @@ services:
2723
SCALITY_ACCESS_KEY_ID: accessKey1
2824
SCALITY_SECRET_ACCESS_KEY: verySecretKey1
2925
restart: always
30-
# healthcheck:
31-
# test:
32-
# - CMD-SHELL
33-
# - curl
34-
# - --fail
35-
# - http://localhost:8000/
36-
# interval: 10s
37-
# retries: 3
38-
# start_period: 30s
39-
# timeout: 5s
26+
healthcheck:
27+
test:
28+
- CMD-SHELL
29+
- curl
30+
- --fail
31+
- http://localhost:8000/_/healthcheck/deep
32+
interval: 10s
33+
retries: 3
34+
start_period: 30s
35+
timeout: 5s

compose/s3-localstack.yml

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -4,14 +4,10 @@ services:
44
s3:
55
condition: service_healthy
66
environment:
7-
STORAGE_BUCKETS_ARCHIVES_NAME: archivedrecordings
87
QUARKUS_S3_ENDPOINT_OVERRIDE: http://s3:4566
98
STORAGE_EXT_URL: /storage/
109
QUARKUS_S3_PATH_STYLE_ACCESS: "true" # needed since compose setup does not support DNS subdomain resolution
1110
QUARKUS_S3_AWS_REGION: us-east-1
12-
QUARKUS_S3_AWS_CREDENTIALS_TYPE: static
13-
QUARKUS_S3_AWS_CREDENTIALS_STATIC_PROVIDER_ACCESS_KEY_ID: unused
14-
QUARKUS_S3_AWS_CREDENTIALS_STATIC_PROVIDER_SECRET_ACCESS_KEY: unused
1511
AWS_ACCESS_KEY_ID: unused
1612
AWS_SECRET_ACCESS_KEY: unused
1713
s3:

compose/s3-minio.yml

Lines changed: 2 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -4,26 +4,23 @@ services:
44
s3:
55
condition: service_healthy
66
environment:
7-
STORAGE_BUCKETS_ARCHIVES_NAME: archivedrecordings
87
QUARKUS_S3_ENDPOINT_OVERRIDE: http://s3:9000
98
STORAGE_EXT_URL: /storage/
109
QUARKUS_S3_PATH_STYLE_ACCESS: "true" # needed since compose setup does not support DNS subdomain resolution
1110
QUARKUS_S3_AWS_REGION: us-east-1
12-
QUARKUS_S3_AWS_CREDENTIALS_TYPE: static
13-
QUARKUS_S3_AWS_CREDENTIALS_STATIC_PROVIDER_ACCESS_KEY_ID: minioroot
14-
QUARKUS_S3_AWS_CREDENTIALS_STATIC_PROVIDER_SECRET_ACCESS_KEY: minioroot
1511
AWS_ACCESS_KEY_ID: minioroot
1612
AWS_SECRET_ACCESS_KEY: minioroot
1713
s3:
1814
image: ${MINIO_IMAGE:-quay.io/minio/minio:latest}
1915
hostname: s3
16+
ports:
17+
- "9001:9001"
2018
expose:
2119
- "9000"
2220
command: server /data --console-address ":9001"
2321
environment:
2422
MINIO_ROOT_USER: minioroot
2523
MINIO_ROOT_PASSWORD: minioroot
26-
MINIO_DEFAULT_BUCKETS: ${PRECREATE_BUCKETS}
2724
volumes:
2825
- minio_data:/data
2926
- minio_certs:/certs

compose/s3-seaweed.yml

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -4,15 +4,10 @@ services:
44
s3:
55
condition: service_healthy
66
environment:
7-
STORAGE_BUCKETS_ARCHIVES_NAME: archivedrecordings
8-
CRYOSTAT_SERVICES_REPORTS_STORAGE_CACHE_NAME: archivedreports
97
QUARKUS_S3_ENDPOINT_OVERRIDE: http://s3:8333
108
STORAGE_EXT_URL: /storage/
119
QUARKUS_S3_PATH_STYLE_ACCESS: "true" # needed since compose setup does not support DNS subdomain resolution
1210
QUARKUS_S3_AWS_REGION: us-east-1
13-
QUARKUS_S3_AWS_CREDENTIALS_TYPE: static
14-
QUARKUS_S3_AWS_CREDENTIALS_STATIC_PROVIDER_ACCESS_KEY_ID: access_key
15-
QUARKUS_S3_AWS_CREDENTIALS_STATIC_PROVIDER_SECRET_ACCESS_KEY: secret_key
1611
AWS_ACCESS_KEY_ID: access_key
1712
AWS_SECRET_ACCESS_KEY: secret_key
1813
s3:

0 commit comments

Comments
 (0)