update constructors in ccapi_subscription.h and ccapi_request.h

Author: ubuntu

include/ccapi_cpp/ccapi_request.h

@@ -139,10 +139,8 @@ class Request {
     return output;
   }
 
-  Request() {}
-
-  explicit Request(Operation operation, const std::string& exchange = "", const std::string& instrument = "", const std::string& correlationId = "",
-                   const std::map<std::string, std::string>& credential = {})
+  explicit Request(Operation operation = Operation::UNKNOWN, const std::string& exchange = "", const std::string& instrument = "",
+                   const std::string& correlationId = "", const std::map<std::string, std::string>& credential = {})
       : operation(operation), exchange(exchange), instrument(instrument), correlationId(correlationId), credential(credential) {
     if (operation == Operation::CUSTOM) {
       this->serviceName = CCAPI_UNKNOWN;

include/ccapi_cpp/ccapi_subscription.h

@@ -15,10 +15,8 @@ namespace ccapi {
  */
 class Subscription {
  public:
-  Subscription() {}
-
-  Subscription(const std::string& exchange, const std::string& instrument, const std::string& field, const std::string& options = "",
-               const std::string& correlationId = "", const std::map<std::string, std::string>& credential = {})
+  explicit Subscription(const std::string& exchange = "", const std::string& instrument = "", const std::string& field = "", const std::string& options = "",
+                        const std::string& correlationId = "", const std::map<std::string, std::string>& credential = {})
       : exchange(exchange), instrument(instrument), field(field), correlationId(correlationId), credential(credential) {
     auto originalInstrumentSet = UtilString::splitToSet(instrument, ",");
     std::copy_if(originalInstrumentSet.begin(), originalInstrumentSet.end(), std::inserter(this->instrumentSet, this->instrumentSet.end()),
@@ -127,6 +125,12 @@ class Subscription {
 
   const std::string& getMarginType() const { return marginType; }
 
+  void setExchange(const std::string& exchange) { this->exchange = exchange; }
+
+  void setInstrument(const std::string& instrument) { this->instrument = instrument; }
+
+  void setField(const std::string& field) { this->field = field; }
+
   void setTimeSent(TimePoint timeSent) { this->timeSent = timeSent; }
 
   void setInstrumentType(const std::string& instrumentType) { this->instrumentType = instrumentType; }