Skip to content

Commit b335017

Browse files
committed
fix binance GET_MARKET_DEPTH rest api response
1 parent 43d0c6f commit b335017

File tree

3 files changed

+10
-10
lines changed

3 files changed

+10
-10
lines changed

README.md

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -354,13 +354,12 @@ Best bid and ask at 2020-07-27T23:56:51.935993000Z are:
354354
### Advanced Market Data
355355

356356
#### Complex request parameters
357-
Please follow the exchange's API documentations: e.g. https://www.okx.com/docs-v5/en/#order-book-trading-market-data-get-trades-history.
357+
Please follow the exchange's API documentations: e.g. https://bybit-exchange.github.io/docs/v5/market/instrument.
358358
```
359-
Request request(Request::Operation::GET_HISTORICAL_TRADES, "okx", "BTC-USDT");
359+
Request request(Request::Operation::GET_INSTRUMENTS, "bybit");
360360
request.appendParam({
361-
{"before", "1"},
362-
{"after", "3"},
363-
{"limit", "1"},
361+
{"category", "linear"},
362+
{"limit", "1000"},
364363
});
365364
```
366365

example/market_data_advanced_request/main.cpp

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -22,11 +22,10 @@ int main(int argc, char** argv) {
2222
SessionConfigs sessionConfigs;
2323
MyEventHandler eventHandler;
2424
Session session(sessionOptions, sessionConfigs, &eventHandler);
25-
Request request(Request::Operation::GET_HISTORICAL_TRADES, "bybit", "BTCUSDT");
25+
Request request(Request::Operation::GET_INSTRUMENTS, "bybit");
2626
request.appendParam({
27-
{"before", "1"},
28-
{"after", "3"},
29-
{"limit", "1"},
27+
{"category", "linear"},
28+
{"limit", "1000"},
3029
});
3130
session.sendRequest(request);
3231
std::this_thread::sleep_for(std::chrono::seconds(10));

include/ccapi_cpp/service/ccapi_market_data_service_binance_base.h

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -543,7 +543,9 @@ class MarketDataServiceBinanceBase : public MarketDataService {
543543
case Request::Operation::GET_MARKET_DEPTH: {
544544
MarketDataMessage marketDataMessage;
545545
marketDataMessage.type = MarketDataMessage::Type::MARKET_DATA_EVENTS_MARKET_DEPTH;
546-
marketDataMessage.tp = UtilTime::makeTimePointFromMilliseconds(std::stoll(document["T"].GetString()));
546+
if (this->isDerivatives) {
547+
marketDataMessage.tp = UtilTime::makeTimePointFromMilliseconds(std::stoll(document["T"].GetString()));
548+
}
547549
for (const auto& x : document["bids"].GetArray()) {
548550
MarketDataMessage::TypeForDataPoint dataPoint;
549551
dataPoint.emplace(MarketDataMessage::DataFieldType::PRICE, x[0].GetString());

0 commit comments

Comments
 (0)