Chore: More precise grep in Cypress bash script (#1911)

* more precise grep in test-cypress.sh + log_cli set to True in pytest.ini

* comment log_cli out

* fix issue when there is no python process running at all

Co-authored-by: k9ert <[email protected]>

Author: moneymanolis

pytest.ini

@@ -5,7 +5,10 @@ addopts = --bitcoind-version v22.0.0 --elementsd-version v0.21.0.2
 markers =
     slow: mark test as slow.
     elm: mark test as elementsd dependent
-#log_cli = 1
+# If you need live logging to debug, uncomment the next line
+# log_cli = True 
+# Then set the desired logging level on the command line, for example:
+# pytest --log-cli-level INFO
 
 filterwarnings =
     ignore::DeprecationWarning:bitbox02[.*]

utils/test-cypress.sh

@@ -20,13 +20,24 @@ fi
 
 function check_consistency {
   if ! npm version 2> /dev/null 1>&2 ; then
-    echo "npm is not on the PATH. Please install node and bring on the PATH"
+    echo "npm is not on the PATH. Please install node and bring it on the PATH."
     exit 1
   fi
-  if ps | grep python | grep -v grep ; then # the second grep might be necessary because MacOs has a non POSIX ps
-      echo "there is still a python-process running which is suspicious. Maybe wait a few more seconds"
-      sleep 5
-      ps | grep python && (echo "please investigate or kill " && exit 1)
+  if ! ps | grep python | grep -q -v grep; then
+    echo "There are no other Python processes running, good to go!"
+  else 
+    GREP_OUTPUT=$(ps | grep python | grep -v grep) 
+    SPECTER_STR="cryptoadvance.specter server"
+    while read -r line; do # https://unix.stackexchange.com/questions/9784/how-can-i-read-line-by-line-from-a-variable-in-bash
+      if [[ "$line" == *"$SPECTER_STR"* ]]; then 
+          echo "There is another Specter process running, this is fine."
+      else
+        echo "There is a suspicious Python process running. Maybe wait a few more seconds."
+        sleep 5
+        echo "Please investigate the following process and perhaps kill: $line"
+        exit 1
+      fi
+    done <<< "$GREP_OUTPUT"
   fi
   $(npm bin)/cypress verify
 }