Bugfix: method getaddressinfo not implemented (#2313)

This PR fixes #2312 which are four things:
* getaddressinfo was not implemented in spectrum which results in "method not found"
* There was an unrelated KeyError which occured in Transactions where one the output was a change-address. It's a bit unknown why that hasn't occured earlier. At least it was diffcult to spot as the fetch_transactions call was way to huge and very confusing. So ...
* the fetch_transactions call was refactored in its own class, TxFetcher. As we did that,  we also moved two other related files in a newly created wallet-package.
* Tiny bug around tx["amount"] which only exists as tx["flow_amount"] for transactions.

Author: k9ert

requirements.in

@@ -33,5 +33,5 @@ psycopg2-binary==2.9.5
 cryptoadvance-liquidissuer==0.2.4
 specterext-exfund==0.1.7
 specterext-faucet==0.1.2
-cryptoadvance.spectrum==0.6.3
+cryptoadvance.spectrum==0.6.4
 specterext-stacktrack==0.3.0

requirements.txt

@@ -2,7 +2,7 @@
 # This file is autogenerated by pip-compile with Python 3.10
 # by the following command:
 #
-#    pip-compile --generate-hashes requirements.in
+#    pip-compile --generate-hashes --resolver=backtracking requirements.in
 #
 aniso8601==9.0.1 \
     --hash=sha256:1d2b7ef82963909e93c4f24ce48d4de9e66009a21bf1c1e1c85bdd0812fe412f \
@@ -119,9 +119,9 @@ cryptoadvance-liquidissuer==0.2.4 \
     --hash=sha256:5a2c531801854c5a4a46daf184877e22f731cdb42d2cfb840785bda7371ba6fb \
     --hash=sha256:9e468f3e35ecc566b3f74a2263677cf26632548abb194521dba15ad37acd1e9b
     # via -r requirements.in
-cryptoadvance-spectrum==0.6.3 \
-    --hash=sha256:706287a9e1640f1a27a1a3c6e27a147599dde9969e7dbd2df99c890514b2b1ba \
-    --hash=sha256:877006d81c5be0d5da12ca8d4b0dd7dc21b104bc826cd35c7de5019ca56cf64a
+cryptoadvance-spectrum==0.6.4 \
+    --hash=sha256:226f89dfe96dac2fcd82f462706e118f017582df5565ff1924f27e4392bc6a0e \
+    --hash=sha256:fa6c877b3a5ba683ccde991f020fce2f3b06e0b8f5219a6fdc592658cacb1d3d
     # via -r requirements.in
 cryptography==39.0.1 \
     --hash=sha256:0f8da300b5c8af9f98111ffd512910bc792b4c77392a9523624680f7956a99d4 \

src/cryptoadvance/specter/liquid/addresslist.py

@@ -1,4 +1,4 @@
-from ..addresslist import *
+from ..wallet.addresslist import *
 from embit.liquid.addresses import addr_decode, to_unconfidential
 
 

src/cryptoadvance/specter/liquid/txlist.py

@@ -1,4 +1,4 @@
-from ..txlist import *
+from ..wallet.txlist import *
 from embit.liquid.transaction import LTransaction, TxOutWitness, unblind
 from embit.liquid.pset import PSET
 from embit.liquid import slip77

src/cryptoadvance/specter/liquid/wallet.py

@@ -8,12 +8,12 @@
 from embit.liquid.pset import PSET
 from embit.liquid.transaction import LTransaction
 
-from ..addresslist import Address
 from ..specter_error import SpecterError
 from ..wallet import *
 from .addresslist import LAddressList
 from .txlist import LTxList
 from .util.pset import SpecterPSET
+from .addresslist import Address
 
 
 class LWallet(Wallet):

src/cryptoadvance/specter/server_endpoints/wallets/wallets_api.py

@@ -21,7 +21,7 @@
 from flask_login import current_user, login_required
 from werkzeug.wrappers import Response
 
-from cryptoadvance.specter.txlist import WalletAwareTxItem
+from cryptoadvance.specter.wallet.txlist import WalletAwareTxItem
 
 from ...commands.psbt_creator import PsbtCreator
 from ...helpers import bcur2base64
@@ -1075,8 +1075,8 @@ def process_txlist(txlist, idx=0, limit=100, search=None, sortby=None, sortdir="
             )
             or (
                 any(search in str(amount) for amount in tx["amount"])
-                if isinstance(tx["amount"], list)
-                else search in str(tx["amount"])
+                if isinstance(tx["flow_amount"], list)
+                else search in str(tx["flow_amount"])
             )
             or search in str(tx["confirmations"])
             or search in str(tx["time"])

src/cryptoadvance/specter/services/service.py

@@ -13,7 +13,6 @@
 from .service_encrypted_storage import ServiceEncryptedStorageManager
 from .service_annotations_storage import ServiceAnnotationsStorage
 
-from cryptoadvance.specter.addresslist import Address
 from cryptoadvance.specter.services import callbacks
 
 

src/cryptoadvance/specter/wallet/__init__.py

@@ -0,0 +1,3 @@
+from .wallet import Wallet, purposes
+from .addresslist import Address
+from .txlist import WalletAwareTxItem

src/cryptoadvance/specter/wallet/abstract_wallet.py

@@ -0,0 +1,25 @@
+from .txlist import TxList
+
+
+class AbstractWallet:
+    @property
+    def transactions(self) -> TxList:
+        if hasattr(self, "_transactions"):
+            return self._transactions
+        else:
+            return None
+
+    @property
+    def addresses(self) -> TxList:
+        if hasattr(self, "_addresses"):
+            return self._addresses
+        else:
+            return None
+
+    @property
+    # abstractmethod
+    def rpc(self):
+        """Cache RPC instance. Reuse if manager's RPC instance hasn't changed. Create new RPC instance otherwise.
+        This RPC instance is also used by objects created by the wallet, such as TxList or TxItem
+        """
+        pass

src/cryptoadvance/specter/addresslist.py …ptoadvance/specter/wallet/addresslist.pysrc/cryptoadvance/specter/addresslist.py renamed to src/cryptoadvance/specter/wallet/addresslist.py src/cryptoadvance/specter/addresslist.py renamed to src/cryptoadvance/specter/wallet/addresslist.py

@@ -2,7 +2,7 @@
 Manages the list of addresses for the wallet, including labels and derivation paths
 """
 import os
-from .persistence import write_csv, read_csv
+from ..persistence import write_csv, read_csv
 import logging
 
 logger = logging.getLogger(__name__)