Use only explicit and no wildcard imports

Author: SailReal

src/main/java/org/cryptomator/cloudaccess/webdav/ProgressRequestWrapper.java

@@ -2,7 +2,11 @@
 
 import okhttp3.MediaType;
 import okhttp3.RequestBody;
-import okio.*;
+import okio.Buffer;
+import okio.BufferedSink;
+import okio.ForwardingSink;
+import okio.Okio;
+import okio.Sink;
 import org.cryptomator.cloudaccess.api.ProgressListener;
 
 import java.io.IOException;

src/main/java/org/cryptomator/cloudaccess/webdav/ProgressResponseWrapper.java

@@ -2,7 +2,11 @@
 
 import okhttp3.MediaType;
 import okhttp3.ResponseBody;
-import okio.*;
+import okio.Buffer;
+import okio.BufferedSource;
+import okio.ForwardingSource;
+import okio.Okio;
+import okio.Source;
 import org.cryptomator.cloudaccess.api.ProgressListener;
 
 import java.io.IOException;
@@ -39,7 +43,7 @@ private Source source(final Source source) {
             long totalBytesRead = 0L;
 
             @Override public long read(final Buffer sink, final long byteCount) throws IOException {
-                long bytesRead = super.read(sink, byteCount);
+                final var bytesRead = super.read(sink, byteCount);
                 totalBytesRead += bytesRead != EOF ? bytesRead : 0;
                 if(bytesRead != EOF) {
                     progressListener.onProgress(totalBytesRead);

src/main/java/org/cryptomator/cloudaccess/webdav/PropfindResponseParser.java

@@ -11,7 +11,10 @@
 import java.text.ParseException;
 import java.text.SimpleDateFormat;
 import java.time.Instant;
-import java.util.*;
+import java.util.ArrayList;
+import java.util.List;
+import java.util.Locale;
+import java.util.Optional;
 
 import static java.lang.String.format;
 

src/main/java/org/cryptomator/cloudaccess/webdav/WebDavClient.java

@@ -1,22 +1,28 @@
 package org.cryptomator.cloudaccess.webdav;
 
-import okhttp3.*;
+import okhttp3.MediaType;
+import okhttp3.Request;
+import okhttp3.RequestBody;
+import okhttp3.Response;
 import org.cryptomator.cloudaccess.api.CloudItemList;
 import org.cryptomator.cloudaccess.api.CloudItemMetadata;
-import org.cryptomator.cloudaccess.api.exceptions.*;
 import org.cryptomator.cloudaccess.api.ProgressListener;
+import org.cryptomator.cloudaccess.api.exceptions.BackendException;
+import org.cryptomator.cloudaccess.api.exceptions.CloudNodeAlreadyExistsException;
+import org.cryptomator.cloudaccess.api.exceptions.ForbiddenException;
+import org.cryptomator.cloudaccess.api.exceptions.InsufficientStorageException;
+import org.cryptomator.cloudaccess.api.exceptions.NotFoundException;
+import org.cryptomator.cloudaccess.api.exceptions.UnauthorizedException;
 import org.xmlpull.v1.XmlPullParserException;
 
 import java.io.IOException;
 import java.io.InputStream;
+import java.net.HttpURLConnection;
 import java.nio.file.Path;
 import java.util.ArrayList;
 import java.util.Comparator;
 import java.util.List;
 
-import static java.lang.String.format;
-import static java.net.HttpURLConnection.*;
-
 public class WebDavClient {
 
     private final WebDavCompatibleHttpClient httpClient;
@@ -144,7 +150,7 @@ Path move(final Path from, final Path to, boolean replace) throws BackendExcepti
         }
 
         try (final var response = httpClient.execute(builder)) {
-            if (response.code() == HTTP_PRECON_FAILED) {
+            if (response.code() == HttpURLConnection.HTTP_PRECON_FAILED) {
                 throw new CloudNodeAlreadyExistsException(absolutePathFrom(to));
             }
 
@@ -165,7 +171,7 @@ InputStream read(final Path path, final ProgressListener progressListener) throw
 
     InputStream read(final Path path, final long offset, final long count, final ProgressListener progressListener) throws BackendException {
         final var getRequest = new Request.Builder() //
-                .header("Range", format("bytes=%d-%d", offset, offset + count - 1))
+                .header("Range", String.format("bytes=%d-%d", offset, offset + count - 1))
                 .get() //
                 .url(absolutePathFrom(path));
         return read(getRequest, progressListener);
@@ -261,12 +267,12 @@ void tryAuthenticatedRequest() throws UnauthorizedException  {
 
     private void checkExecutionSucceeded(final int status) throws BackendException {
         switch (status) {
-            case HTTP_UNAUTHORIZED:
+            case HttpURLConnection.HTTP_UNAUTHORIZED:
                 throw new UnauthorizedException();
-            case HTTP_FORBIDDEN:
+            case HttpURLConnection.HTTP_FORBIDDEN:
                 throw new ForbiddenException();
-            case HTTP_NOT_FOUND: // fall through
-            case HTTP_CONFLICT: //
+            case HttpURLConnection.HTTP_NOT_FOUND: // fall through
+            case HttpURLConnection.HTTP_CONFLICT: //
                 throw new NotFoundException();
             case HTTP_INSUFFICIENT_STORAGE:
                 throw new InsufficientStorageException();

src/main/java/org/cryptomator/cloudaccess/webdav/WebDavCompatibleHttpClient.java

@@ -7,16 +7,18 @@
 import com.burgstaller.okhttp.digest.CachingAuthenticator;
 import com.burgstaller.okhttp.digest.Credentials;
 import com.burgstaller.okhttp.digest.DigestAuthenticator;
-import okhttp3.*;
+import okhttp3.Authenticator;
+import okhttp3.OkHttpClient;
+import okhttp3.Request;
+import okhttp3.Response;
+import org.cryptomator.cloudaccess.api.NetworkTimeout;
 import org.slf4j.Logger;
 import org.slf4j.LoggerFactory;
 
 import java.io.IOException;
 import java.util.Map;
 import java.util.concurrent.ConcurrentHashMap;
 
-import static org.cryptomator.cloudaccess.api.NetworkTimeout.*;
-
 class WebDavCompatibleHttpClient {
 
     private static final Logger LOG = LoggerFactory.getLogger(WebDavCompatibleHttpClient.class);
@@ -40,9 +42,9 @@ private static OkHttpClient httpClientFor(final WebDavCredential webDavCredentia
 
         final var builder = new OkHttpClient()
                 .newBuilder()
-                .connectTimeout(CONNECTION.getTimeout(), CONNECTION.getUnit())
-                .readTimeout(READ.getTimeout(), READ.getUnit())
-                .writeTimeout(WRITE.getTimeout(), WRITE.getUnit())
+                .connectTimeout(NetworkTimeout.CONNECTION.getTimeout(), NetworkTimeout.CONNECTION.getUnit())
+                .readTimeout(NetworkTimeout.READ.getTimeout(), NetworkTimeout.READ.getUnit())
+                .writeTimeout(NetworkTimeout.WRITE.getTimeout(), NetworkTimeout.WRITE.getUnit())
                 .followRedirects(false)
                 .addInterceptor(new HttpLoggingInterceptor(LOG::info))
                 .authenticator(httpAuthenticator(webDavCredential.getUsername(), webDavCredential.getPassword(), authCache))

src/test/java/org/cryptomator/cloudaccess/webdav/HttpLoggingInterceptorTest.java

@@ -1,6 +1,11 @@
 package org.cryptomator.cloudaccess.webdav;
 
-import okhttp3.*;
+import okhttp3.Interceptor;
+import okhttp3.MediaType;
+import okhttp3.Protocol;
+import okhttp3.Request;
+import okhttp3.Response;
+import okhttp3.ResponseBody;
 import org.junit.jupiter.api.Test;
 import org.mockito.ArgumentMatchers;
 import org.mockito.Mockito;

src/test/java/org/cryptomator/cloudaccess/webdav/PropfindResponseParserTest.java

@@ -12,7 +12,11 @@
 import java.io.IOException;
 import java.io.InputStream;
 import java.nio.file.Path;
-import java.util.*;
+import java.util.ArrayList;
+import java.util.Collections;
+import java.util.Comparator;
+import java.util.List;
+import java.util.Optional;
 
 public class PropfindResponseParserTest {
 

src/test/java/org/cryptomator/cloudaccess/webdav/WebDavClientTest.java

@@ -1,17 +1,27 @@
 package org.cryptomator.cloudaccess.webdav;
 
-import okhttp3.*;
+import okhttp3.MediaType;
+import okhttp3.Protocol;
+import okhttp3.Request;
+import okhttp3.Response;
+import okhttp3.ResponseBody;
 import org.cryptomator.cloudaccess.api.CloudItemMetadata;
 import org.cryptomator.cloudaccess.api.CloudItemType;
 import org.cryptomator.cloudaccess.api.ProgressListener;
 import org.cryptomator.cloudaccess.api.exceptions.CloudNodeAlreadyExistsException;
 import org.cryptomator.cloudaccess.api.exceptions.UnauthorizedException;
 import org.junit.Assert;
-import org.junit.jupiter.api.*;
+import org.junit.jupiter.api.Assertions;
+import org.junit.jupiter.api.BeforeEach;
+import org.junit.jupiter.api.DisplayName;
+import org.junit.jupiter.api.Test;
 import org.mockito.ArgumentMatchers;
 import org.mockito.Mockito;
 
-import java.io.*;
+import java.io.BufferedReader;
+import java.io.IOException;
+import java.io.InputStream;
+import java.io.InputStreamReader;
 import java.nio.charset.StandardCharsets;
 import java.nio.file.Path;
 import java.util.List;

src/test/java/org/cryptomator/cloudaccess/webdav/WebDavCloudProviderTestIT.java

@@ -9,9 +9,13 @@
 import org.cryptomator.cloudaccess.api.ProgressListener;
 import org.cryptomator.cloudaccess.api.exceptions.CloudNodeAlreadyExistsException;
 import org.junit.Assert;
-import org.junit.jupiter.api.*;
+import org.junit.jupiter.api.Assertions;
+import org.junit.jupiter.api.DisplayName;
+import org.junit.jupiter.api.Test;
 
-import java.io.*;
+import java.io.BufferedReader;
+import java.io.IOException;
+import java.io.InputStreamReader;
 import java.nio.charset.StandardCharsets;
 import java.nio.file.Path;
 import java.util.List;

src/test/java/org/cryptomator/cloudaccess/webdav/WebDavRedirectHandlerTest.java

@@ -1,6 +1,12 @@
 package org.cryptomator.cloudaccess.webdav;
 
-import okhttp3.*;
+import okhttp3.Call;
+import okhttp3.MediaType;
+import okhttp3.OkHttpClient;
+import okhttp3.Protocol;
+import okhttp3.Request;
+import okhttp3.Response;
+import okhttp3.ResponseBody;
 import org.junit.Assert;
 import org.junit.jupiter.api.Assertions;
 import org.junit.jupiter.api.BeforeEach;