Skip to content

Commit 7ab7629

Browse files
committed
Merge branch 'develop' into release/1.3.0
# Conflicts: # pom.xml
2 parents 39028c3 + c9093fb commit 7ab7629

File tree

3 files changed

+9
-15
lines changed

3 files changed

+9
-15
lines changed

pom.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -44,7 +44,7 @@
4444
<secret-service.version>1.8.1-jdk17</secret-service.version>
4545
<kdewallet.version>1.3.0</kdewallet.version>
4646
<appindicator.version>1.3.1</appindicator.version>
47-
<guava.version>31.1-jre</guava.version>
47+
<guava.version>32.0.0-jre</guava.version>
4848
<slf4j.version>1.7.36</slf4j.version>
4949
<commons-lang3.version>3.12.0</commons-lang3.version>
5050

src/test/java/org/cryptomator/linux/keychain/SecretServiceKeychainAccessTest.java

Lines changed: 8 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -3,8 +3,7 @@
33
import org.junit.jupiter.api.Assertions;
44
import org.junit.jupiter.api.BeforeAll;
55
import org.junit.jupiter.api.Test;
6-
import org.junit.jupiter.api.condition.EnabledOnOs;
7-
import org.junit.jupiter.api.condition.OS;
6+
import org.junit.jupiter.api.condition.EnabledIf;
87

98
import java.io.IOException;
109
import java.util.List;
@@ -13,14 +12,13 @@
1312
/**
1413
* Unit tests for GNOME keyring access via DBUS.
1514
*/
16-
@EnabledOnOs(OS.LINUX)
1715
public class SecretServiceKeychainAccessTest {
1816

1917
private static boolean isInstalled;
2018

2119
@BeforeAll
2220
public static void checkSystemAndSetup() throws IOException {
23-
ProcessBuilder dbusSend = new ProcessBuilder("dbus-send","--print-reply","--dest=org.freedesktop.DBus", "/org/freedesktop/DBus", "org.freedesktop.DBus.ListNames");
21+
ProcessBuilder dbusSend = new ProcessBuilder("dbus-send", "--print-reply", "--dest=org.freedesktop.DBus", "/org/freedesktop/DBus", "org.freedesktop.DBus.ListNames");
2422
ProcessBuilder grep = new ProcessBuilder("grep", "org.gnome.keyring");
2523
try {
2624
Process end = ProcessBuilder.startPipeline(List.of(dbusSend, grep)).get(1);
@@ -36,10 +34,13 @@ public static void checkSystemAndSetup() throws IOException {
3634

3735

3836
@Test
39-
public void testIsSupported(){
37+
@EnabledIf("isXdgDisplayEnvVarSet")
38+
public void testIsSupported() {
4039
SecretServiceKeychainAccess secretService = new SecretServiceKeychainAccess();
4140
Assertions.assertEquals(isInstalled, secretService.isSupported());
4241
}
4342

44-
45-
}
43+
public boolean isXdgDisplayEnvVarSet() {
44+
return System.getenv("DISPLAY") != null;
45+
}
46+
}

suppression.xml

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,3 @@
11
<?xml version="1.0" encoding="UTF-8"?>
22
<suppressions xmlns="https://jeremylong.github.io/DependencyCheck/dependency-suppression.1.3.xsd">
3-
<suppress>
4-
<notes><![CDATA[
5-
Vulnerable method `Files::createTempDir` not used.
6-
]]></notes>
7-
<gav regex="true">^com\.google\.guava:.*$</gav>
8-
<cve>CVE-2020-8908</cve>
9-
</suppress>
103
</suppressions>

0 commit comments

Comments
 (0)