Migrate from Codacy to SonarCloud, fix CI build warnings

Author: tobihagemann

.github/workflows/build.yml

@@ -17,6 +17,10 @@ jobs:
         config: ['freemium', 'premium']
     steps:
       - uses: actions/checkout@v4
+        with:
+          # Disable shallow clone for SonarCloud analysis
+          # https://docs.sonarsource.com/sonarqube-cloud/advanced-setup/ci-based-analysis/github-actions-for-sonarcloud
+          fetch-depth: 0
       - uses: actions/cache@v4
         with:
           path: .build
@@ -43,12 +47,14 @@ jobs:
         run: set -o pipefail && env NSUnbufferedIO=YES xcodebuild clean build-for-testing -scheme 'AllTests' -destination "name=$DEVICE" -derivedDataPath $DERIVED_DATA_PATH ${{ env.BUILD_CMD }} | xcbeautify
       - name: Test
         run: set -o pipefail && env NSUnbufferedIO=YES xcodebuild test-without-building -xctestrun $(find . -type f -name "*.xctestrun") -destination "name=$DEVICE" -derivedDataPath $DERIVED_DATA_PATH | xcbeautify
-      - name: Upload code coverage report
+      - name: Generate coverage report
         if: ${{ matrix.config == 'freemium' }}
         run: |
-          gem install slather
-          slather coverage -x  --build-directory $DERIVED_DATA_PATH --ignore "$DERIVED_DATA_PATH/SourcePackages/*" --scheme AllTests Cryptomator.xcodeproj
-          bash <(curl -Ls https://coverage.codacy.com/get.sh)
+          xcresult_path=$(find $DERIVED_DATA_PATH/Logs/Test -name "*.xcresult" | head -n 1)
+          bash Scripts/xccov-to-sonarqube-generic.sh "$xcresult_path" > sonarqube-generic-coverage.xml
+      - name: SonarCloud Scan
+        if: ${{ matrix.config == 'freemium' }}
+        uses: SonarSource/sonarqube-scan-action@v6.0.0
         env:
-          CODACY_PROJECT_TOKEN: ${{ secrets.CODACY_PROJECT_TOKEN }}
+          SONAR_TOKEN: ${{ secrets.SONAR_TOKEN }}
         continue-on-error: true

.swiftformat

@@ -1,4 +1,5 @@
---minversion 0.49.2
+--minversion 0.58.3
+--exclude DerivedData
 
 # format options
 

README.md

@@ -1,7 +1,8 @@
 # Cryptomator for iOS
 
 [![Build](https://github.com/cryptomator/ios/actions/workflows/build.yml/badge.svg)](https://github.com/cryptomator/ios/actions/workflows/build.yml)
-[![Codacy Badge](https://app.codacy.com/project/badge/Grade/efc080db52a5449fac50ffde8d8fd6bc)](https://www.codacy.com/gh/cryptomator/ios/dashboard)
+[![Quality Gate Status](https://sonarcloud.io/api/project_badges/measure?project=cryptomator_ios&metric=alert_status)](https://sonarcloud.io/summary/new_code?id=cryptomator_ios)
+[![Coverage](https://sonarcloud.io/api/project_badges/measure?project=cryptomator_ios&metric=coverage)](https://sonarcloud.io/summary/new_code?id=cryptomator_ios)
 [![Mastodon](https://img.shields.io/mastodon/follow/176112?domain=mastodon.online&style=flat)](https://mastodon.online/@cryptomator)
 [![Crowdin](https://badges.crowdin.net/cryptomator/localized.svg)](https://translate.cryptomator.org/)
 [![Community](https://img.shields.io/badge/help-Community-orange.svg)](https://community.cryptomator.org)

Scripts/xccov-to-sonarqube-generic.sh

@@ -0,0 +1,46 @@
+#!/usr/bin/env bash
+# Source: https://github.com/SonarSource/sonar-scanning-examples/blob/master/swift-coverage/swift-coverage-example/xccov-to-sonarqube-generic.sh
+set -euo pipefail
+
+function convert_xccov_to_xml {
+  sed -n                                                                                       \
+      -e '/:$/s/&/\&amp;/g;s/^\(.*\):$/  <file path="\1">/p'                                   \
+      -e 's/^ *\([0-9][0-9]*\): 0.*$/    <lineToCover lineNumber="\1" covered="false"\/>/p'    \
+      -e 's/^ *\([0-9][0-9]*\): [1-9].*$/    <lineToCover lineNumber="\1" covered="true"\/>/p' \
+      -e 's/^$/  <\/file>/p'
+}
+
+function xccov_to_generic {
+  local xcresult="$1"
+
+  echo '<coverage version="1">'
+  xcrun xccov view --archive "$xcresult" | convert_xccov_to_xml
+  echo '</coverage>'
+}
+
+function check_xcode_version() {
+  local major=${1:-0} minor=${2:-0}
+  return $(( (major >= 14) || (major == 13 && minor >= 3) ))
+}
+
+if ! xcode_version="$(xcodebuild -version | sed -n '1s/^Xcode \([0-9.]*\)$/\1/p')"; then
+  echo 'Failed to get Xcode version' 1>&2
+  exit 1
+elif check_xcode_version ${xcode_version//./ }; then
+  echo "Xcode version '$xcode_version' not supported, version 13.3 or above is required" 1>&2;
+  exit 1
+fi
+
+xcresult="$1"
+if [[ $# -ne 1 ]]; then
+  echo "Invalid number of arguments. Expecting 1 path matching '*.xcresult'"
+  exit 1
+elif [[ ! -d $xcresult ]]; then
+  echo "Path not found: $xcresult" 1>&2;
+  exit 1
+elif [[ $xcresult != *".xcresult"* ]]; then
+  echo "Expecting input to match '*.xcresult', got: $xcresult" 1>&2;
+  exit 1
+fi
+
+xccov_to_generic "$xcresult"

sonar-project.properties

@@ -0,0 +1,15 @@
+# Organization and project keys are defined in SonarCloud UI
+sonar.organization=cryptomator
+sonar.projectKey=cryptomator_ios
+
+# Source and test directories
+sonar.sources=Cryptomator,CryptomatorCommon/Sources,CryptomatorFileProvider,FileProviderExtension,FileProviderExtensionUI,CryptomatorIntents,SharedResources
+sonar.tests=CryptomatorTests,CryptomatorCommon/Tests,CryptomatorFileProviderTests
+
+# Disable C/C++/Objective-C analysis
+sonar.c.file.suffixes=-
+sonar.cpp.file.suffixes=-
+sonar.objc.file.suffixes=-
+
+# Coverage report path (generated by xccov)
+sonar.coverageReportPaths=sonarqube-generic-coverage.xml