Merge pull request #14 from cryptomkt/feat/withdrawal-fees

feat: get withdraw fees

Author: ppbustamante

pom.xml

@@ -114,7 +114,7 @@
     <dependency>
       <groupId>com.squareup.okio</groupId>
       <artifactId>okio</artifactId>
-      <version>2.8.0</version>
+      <version>3.7.0</version>
     </dependency>
     <dependency>
       <groupId>com.squareup.okhttp3</groupId>

src/main/java/com/cryptomarket/sdk/Adapter.java

@@ -264,4 +264,11 @@ public List<String> stringlistFromStringMap(Object value, String key) throws Par
     }
     return listFromValue(list, String.class);
   }
+
+  public <T> String listToJson(List<T> list, Class<T> cls) throws ParseException {
+    Type type = Types.newParameterizedType(List.class, cls);
+    JsonAdapter<List<T>> listAdapter = moshi.adapter(type);
+    return ConvertingException.ioAndJsonDataAndAssertionToParse(listAdapter::toJson, list);
+
+  }
 }

src/main/java/com/cryptomarket/sdk/models/Fee.java

@@ -0,0 +1,53 @@
+package com.cryptomarket.sdk.models;
+
+public class Fee {
+  private String fee;
+  private String networkFee;
+  private String amount;
+  private String currency;
+
+  public Fee(String fee, String networkFee, String amount, String currency) {
+    this.fee = fee;
+    this.networkFee = networkFee;
+    this.amount = amount;
+    this.currency = currency;
+  }
+
+  public String getFee() {
+    return fee;
+  }
+
+  public void setFee(String fee) {
+    this.fee = fee;
+  }
+
+  public String getNetworkFee() {
+    return networkFee;
+  }
+
+  public void setNetworkFee(String networkFee) {
+    this.networkFee = networkFee;
+  }
+
+  public String getAmount() {
+    return amount;
+  }
+
+  public void setAmount(String amount) {
+    this.amount = amount;
+  }
+
+  public String getCurrency() {
+    return currency;
+  }
+
+  public void setCurrency(String currency) {
+    this.currency = currency;
+  }
+
+  @Override
+  public String toString() {
+    return "Fee [fee=" + fee + ", networkFee=" + networkFee + ", amount=" + amount + ", currency=" + currency + "]";
+  }
+
+}

src/main/java/com/cryptomarket/sdk/models/FeeRequest.java

@@ -0,0 +1,45 @@
+package com.cryptomarket.sdk.models;
+
+import com.squareup.moshi.Json;
+
+public class FeeRequest {
+  private String currency;
+  private String amount;
+  @Json(name = "network_code")
+  private String networkCode;
+
+  public FeeRequest(String currency, String amount, String networkCode) {
+    this.currency = currency;
+    this.amount = amount;
+    this.networkCode = networkCode;
+  }
+
+  public String getCurrency() {
+    return currency;
+  }
+
+  public void setCurrency(String currency) {
+    this.currency = currency;
+  }
+
+  public String getAmount() {
+    return amount;
+  }
+
+  public void setAmount(String amount) {
+    this.amount = amount;
+  }
+
+  public String getNetworkCode() {
+    return networkCode;
+  }
+
+  public void setNetworkCode(String networkCode) {
+    this.networkCode = networkCode;
+  }
+
+  @Override
+  public String toString() {
+    return "FeeRequest [currency=" + currency + ", amount=" + amount + ", networkCode=" + networkCode + "]";
+  }
+}

src/main/java/com/cryptomarket/sdk/rest/CryptomarketRestClient.java

@@ -29,6 +29,8 @@
 import com.cryptomarket.sdk.models.Candle;
 import com.cryptomarket.sdk.models.Commission;
 import com.cryptomarket.sdk.models.Currency;
+import com.cryptomarket.sdk.models.Fee;
+import com.cryptomarket.sdk.models.FeeRequest;
 import com.cryptomarket.sdk.models.Order;
 import com.cryptomarket.sdk.models.OrderBook;
 import com.cryptomarket.sdk.models.Price;
@@ -1067,6 +1069,19 @@ public String getEstimateWithdrawalFee(String currency, String amount, @Nullable
    */
   public String getEstimateWithdrawalFee(ParamsBuilder paramsBuilder) throws CryptomarketSDKException;
 
+  /**
+   * Get estimates of withdrawal fees
+   * <p>
+   * Requires the "Payment information" API key Access Right
+   * <p>
+   * https://api.exchange.cryptomkt.com/#estimate-withdrawal-fees
+   *
+   * @param feeRequests a list of fee requests
+   * @return the list of fees
+   * @throws CryptomarketSDKException
+   */
+  public List<Fee> getEstimateWithdrawalFees(List<FeeRequest> feeRequests) throws CryptomarketSDKException;
+
   /**
    * Converts between currencies
    * <p>

src/main/java/com/cryptomarket/sdk/rest/CryptomarketRestClientImpl.java

@@ -32,6 +32,8 @@
 import com.cryptomarket.sdk.models.Candle;
 import com.cryptomarket.sdk.models.Commission;
 import com.cryptomarket.sdk.models.Currency;
+import com.cryptomarket.sdk.models.Fee;
+import com.cryptomarket.sdk.models.FeeRequest;
 import com.cryptomarket.sdk.models.Order;
 import com.cryptomarket.sdk.models.OrderBook;
 import com.cryptomarket.sdk.models.Price;
@@ -739,7 +741,16 @@ public String getEstimateWithdrawalFee(ParamsBuilder paramsBuilder)
         "wallet/crypto/fee/estimate",
         paramsBuilder.build());
     return adapter.objectFromJsonValue(jsonResponse, "fee", String.class);
+  }
 
+  @Override
+  public List<Fee> getEstimateWithdrawalFees(List<FeeRequest> feeRequests) throws CryptomarketSDKException {
+    var payload = adapter.listToJson(feeRequests, FeeRequest.class);
+    String jsonResponse = httpClient.post(
+        "wallet/crypto/fees/estimate",
+        payload);
+        System.out.println(jsonResponse);
+    return adapter.listFromJson(jsonResponse, Fee.class);
   }
 
   @Override

src/test/java/com/cryptomarket/sdk/Checker.java

@@ -12,6 +12,7 @@
 import com.cryptomarket.sdk.models.Candle;
 import com.cryptomarket.sdk.models.Commission;
 import com.cryptomarket.sdk.models.Currency;
+import com.cryptomarket.sdk.models.Fee;
 import com.cryptomarket.sdk.models.HistoryPoint;
 import com.cryptomarket.sdk.models.NativeTransaction;
 import com.cryptomarket.sdk.models.Network;
@@ -287,16 +288,14 @@ public class Checker {
     // obj.getReportType().toString()
     fields.forEach(checkString);
   };
-
-  public static Consumer<SubAccount> checkSubAccount = obj -> {
+  static Consumer<SubAccount> checkSubAccount = obj -> {
     List<String> fields = new ArrayList<>(Arrays.asList(
         obj.getSubAccountId(),
         obj.getEmail(),
         obj.getStatus().toString()));
     fields.forEach(checkString);
   };
-
-  public static Consumer<? super SubAccountSettings> checkSubAccountSettings = obj -> {
+  static Consumer<? super SubAccountSettings> checkSubAccountSettings = obj -> {
     List<String> fields = new ArrayList<>(Arrays.asList(
         obj.getSubAccountId(),
         obj.isDepositAddressGenerationEnabled().toString(),
@@ -305,4 +304,14 @@ public class Checker {
         obj.getUpdatedAt()));
     fields.forEach(checkString);
   };
+  static Consumer<Fee> checkFee = obj -> {
+    List<String> fields = new ArrayList<>(Arrays.asList(
+        obj.getFee(),
+        obj.getNetworkFee(),
+        obj.getCurrency(),
+        obj.getAmount()
+    // obj.getUpdatedAt()
+    ));
+    fields.forEach(checkString);
+  };
 }

src/test/java/com/cryptomarket/sdk/TestRestClientWalletManagement.java

@@ -11,6 +11,7 @@
 import com.cryptomarket.sdk.exceptions.CryptomarketSDKException;
 import com.cryptomarket.sdk.models.Address;
 import com.cryptomarket.sdk.models.Balance;
+import com.cryptomarket.sdk.models.FeeRequest;
 import com.cryptomarket.sdk.models.Transaction;
 import com.cryptomarket.sdk.rest.CryptomarketRestClient;
 import com.cryptomarket.sdk.rest.CryptomarketRestClientImpl;
@@ -111,6 +112,16 @@ public void testWithdrawCryptoRollback() throws CryptomarketSDKException {
     }
   }
 
+
+  @Test
+  public void testGetEstimateWithdrawFees() throws CryptomarketSDKException {
+    var fees = client.getEstimateWithdrawalFees(List.of(new FeeRequest("EOS", "100", null),new FeeRequest("ETH", "100", null)));
+    if (fees.size()!=2) {
+      fail("invalid amount of fees");
+    }
+    fees.forEach(Checker.checkFee);
+  }
+
   @Test
   public void testGetEstimateWithdrawFee() throws CryptomarketSDKException {
     String estimate = client.getEstimateWithdrawalFee("EOS", "100", null);