test: change credentials, change window

Author: Insmael

src/main/java/com/cryptomarket/sdk/rest/CryptomarketRestClient.java

@@ -64,7 +64,7 @@ public interface CryptomarketRestClient extends Closeable {
   /**
    * Changes the window used in authenticated calls
    *
-   * @param window acceptable time between request and server execution
+   * @param window acceptable time between request and server execution in millis
    */
   public void changeWindow(Integer window);
 
@@ -1394,7 +1394,7 @@ public String getEstimateWithdrawalFee(String currency, String amount, @Nullable
    * <p>
    * Requires the "Payment information" API key Access Right
    * <p>
-   * https://api.exchange.cryptomkt.com/#bulk-estimate-deposit-fee
+   * https://api.exchange.cryptomkt.com/#bulk-estimate-withdrawal-fee
    *
    * @param feeRequests a list of fee requests
    * @return the list of fees

src/test/java/com/cryptomarket/sdk/TestRestClientChangeCredentials.java

@@ -0,0 +1,44 @@
+package com.cryptomarket.sdk;
+
+import static org.junit.Assert.fail;
+
+import java.util.List;
+
+import org.junit.Test;
+
+import com.cryptomarket.sdk.exceptions.CryptomarketSDKException;
+import com.cryptomarket.sdk.models.Balance;
+import com.cryptomarket.sdk.rest.CryptomarketRestClient;
+import com.cryptomarket.sdk.rest.CryptomarketRestClientImpl;
+
+public class TestRestClientChangeCredentials {
+  CryptomarketRestClient client = new CryptomarketRestClientImpl(KeyLoader.getApiKey(), KeyLoader.getApiSecret());
+
+  @Test
+  public void testChangeCredentials() throws CryptomarketSDKException {
+    List<Balance> balances = client.getWalletBalances();
+    if (balances.size() == 0)
+      fail();
+    balances.forEach(balance -> {
+      if (balance.getCurrency() == null || balance.getCurrency().equals(""))
+        fail();
+    });
+
+    client.changeCredentials("null", "null");
+    try {
+      balances = client.getWalletBalances();
+      fail("should fail");
+    } catch (CryptomarketSDKException e) {
+      // good
+    }
+    client.changeCredentials(KeyLoader.getApiKey(), KeyLoader.getApiSecret());
+
+    balances = client.getWalletBalances();
+    if (balances.size() == 0)
+      fail();
+    balances.forEach(balance -> {
+      if (balance.getCurrency() == null || balance.getCurrency().equals(""))
+        fail();
+    });
+  }
+}

src/test/java/com/cryptomarket/sdk/TestRestClientChangeWindow.java

@@ -0,0 +1,44 @@
+package com.cryptomarket.sdk;
+
+import static org.junit.Assert.fail;
+
+import java.util.List;
+
+import org.junit.Test;
+
+import com.cryptomarket.sdk.exceptions.CryptomarketSDKException;
+import com.cryptomarket.sdk.models.Balance;
+import com.cryptomarket.sdk.rest.CryptomarketRestClient;
+import com.cryptomarket.sdk.rest.CryptomarketRestClientImpl;
+
+public class TestRestClientChangeWindow {
+  CryptomarketRestClient client = new CryptomarketRestClientImpl(KeyLoader.getApiKey(), KeyLoader.getApiSecret());
+
+  @Test
+  public void testChangeCredentials() throws CryptomarketSDKException {
+    List<Balance> balances = client.getWalletBalances();
+    if (balances.size() == 0)
+      fail();
+    balances.forEach(balance -> {
+      if (balance.getCurrency() == null || balance.getCurrency().equals(""))
+        fail();
+    });
+
+    client.changeWindow(100);
+    try {
+      balances = client.getWalletBalances();
+      fail("should fail");
+    } catch (CryptomarketSDKException e) {
+      // good
+    }
+    client.changeWindow(10_000);
+
+    balances = client.getWalletBalances();
+    if (balances.size() == 0)
+      fail();
+    balances.forEach(balance -> {
+      if (balance.getCurrency() == null || balance.getCurrency().equals(""))
+        fail();
+    });
+  }
+}

src/test/java/com/cryptomarket/sdk/TestRestClientWalletManagement.java

@@ -1,5 +1,6 @@
 package com.cryptomarket.sdk;
 
+import static org.junit.Assert.assertTrue;
 import static org.junit.Assert.fail;
 
 import java.util.List;
@@ -205,6 +206,7 @@ public void testGetTransactionHistoryWithParams() throws CryptomarketSDKExceptio
         .offset(0)
         .currencies(List.of())
         .from("1614815872000"));
+    assertTrue(transactions.size() > 0);
     transactions.forEach(Checker.checkTransaction);
   }
 

src/test/java/com/cryptomarket/sdk/TestWSWalletClient.java

@@ -1,9 +1,17 @@
 package com.cryptomarket.sdk;
 
+import com.cryptomarket.params.OrderBy;
+import com.cryptomarket.params.ParamsBuilder;
+import com.cryptomarket.params.Sort;
+import com.cryptomarket.sdk.exceptions.CryptomarketSDKException;
+import com.cryptomarket.sdk.models.Transaction;
 import com.cryptomarket.sdk.websocket.CryptomarketWSWalletClient;
 import com.cryptomarket.sdk.websocket.CryptomarketWSWalletClientImpl;
 
+import static org.junit.Assert.assertTrue;
+
 import java.io.IOException;
+import java.util.List;
 
 import org.junit.After;
 import org.junit.Before;
@@ -53,4 +61,18 @@ public void testGetTransactions() {
     Helpers.sleep(3);
   }
 
+  @Test
+  public void testGetTransactionHistoryWithParams() throws CryptomarketSDKException {
+    wsClient.getTransactions((transactions, exception) -> {
+      assertTrue(transactions.size() > 0);
+      transactions.forEach(Checker.checkTransaction);
+    }, new ParamsBuilder()
+        .orderBy(OrderBy.CREATED_AT)
+        .sort(Sort.DESC)
+        .limit(1000)
+        .offset(0)
+        .currencies(List.of())
+        .from("1614815872000"));
+  }
+
 }