refactor: simplifies some one argument method calls. fix: websocket tests

Author: Insmael

lib/websocket/tradingClient.ts

@@ -215,13 +215,11 @@ export class TradingClient extends AuthClient {
    *
    * https://api.exchange.cryptomkt.com/#get-spot-trading-balance-2
    *
-   * @param {string} params.currency The currency code to query the balance
+   * @param {string} currency The currency code to query the balance
    * @return A promise that resolves with the spot trading balance of a currency
    */
-  async getSpotTradingBalance(params: {
-    currency: string;
-  }): Promise<Balance> {
-    return this.makeRequest<Balance>({ method: "spot_balance", params });
+  async getSpotTradingBalance(currency: string): Promise<Balance> {
+    return this.makeRequest<Balance>({ method: "spot_balance", params: { currency } });
   }
 
   /**
@@ -240,13 +238,11 @@ export class TradingClient extends AuthClient {
    *
    * https://api.exchange.cryptomkt.com/#get-spot-fee
    *
-   * @param {string} params.symbol The symbol of the commission rate
+   * @param {string} symbol The symbol of the commission rate
    * @return A promise that resolves with the commission rate of a symbol
    */
-  async getSpotFee(params: {
-    symbol: string;
-  }): Promise<Commission> {
-    return this.makeRequest<Commission>({ method: "spot_fee", params });
+  async getSpotFee(symbol: string): Promise<Commission> {
+    return this.makeRequest<Commission>({ method: "spot_fee", params: { symbol } });
   }
 
   ///////////////////

test/websocket/trading.test.ts

@@ -28,9 +28,7 @@ describe("TradingClient", () => {
     it("gets only one", async function () {
       this.timeout(0);
       await wsclient.connect();
-      const balance = await wsclient.getSpotTradingBalanceOfCurrency({
-        currency: "EOS",
-      });
+      const balance = await wsclient.getSpotTradingBalance("EOS");
       expect(goodBalance(balance)).to.be.true
     });
   });
@@ -94,7 +92,7 @@ describe("TradingClient", () => {
     it("gets a commission list", async function () {
       this.timeout(0);
       await wsclient.connect();
-      const commissions = await wsclient.getSpotCommissions();
+      const commissions = await wsclient.getSpotFees();
       expect(commissions.length).to.be.greaterThanOrEqual(1);
       const allGood = commissions.map(goodTradingCommission).every(Boolean)
       expect(allGood).to.be.true
@@ -103,9 +101,7 @@ describe("TradingClient", () => {
     it("gets only one", async function () {
       this.timeout(0);
       await wsclient.connect();
-      const commission = await wsclient.getSpotCommissionOfSymbol({
-        symbol: "EOSETH",
-      });
+      const commission = await wsclient.getSpotFee("EOSETH");
       expect(goodTradingCommission(commission)).to.be.true
     });
   });

test/websocket/wallet.test.ts

@@ -26,7 +26,7 @@ describe("WalletClient", function () {
     it("gets only one balance", async function () {
       this.timeout(0);
       await wsclient.connect();
-      const balance = await wsclient.getWalletBalanceOfCurrency("EOS");
+      const balance = await wsclient.getWalletBalance("EOS");
       expect(goodBalance(balance)).to.be.true
     });
   });