style: functions in tests to snake case

Author: Insmael

.rubocop.yml

@@ -1,13 +1,14 @@
 # frozen_string_literal: true
-source "https://rubygems.org"
 
-gem 'rest-client'
-gem 'openssl'
+source 'https://rubygems.org'
+
 gem 'eventmachine'
 gem 'faye-websocket'
+gem 'openssl'
+gem 'rest-client'
 
 
 group :test do
-  gem 'test-unit'
   gem 'rubocop'
-end
+  gem 'test-unit'
+end

Gemfile

@@ -1,6 +1,7 @@
 GEM
   remote: https://rubygems.org/
   specs:
+    ast (2.4.2)
     domain_name (0.6.20240107)
     eventmachine (1.2.7)
     faye-websocket (0.11.3)
@@ -9,19 +10,44 @@ GEM
     http-accept (1.7.0)
     http-cookie (1.0.5)
       domain_name (~> 0.5)
+    json (2.7.1)
+    language_server-protocol (3.17.0.3)
     mime-types (3.5.2)
       mime-types-data (~> 3.2015)
     mime-types-data (3.2024.0206)
     netrc (0.11.0)
     openssl (3.2.0)
+    parallel (1.24.0)
+    parser (3.3.0.5)
+      ast (~> 2.4.1)
+      racc
     power_assert (2.0.3)
+    racc (1.7.3)
+    rainbow (3.1.1)
+    regexp_parser (2.9.0)
     rest-client (2.1.0)
       http-accept (>= 1.7.0, < 2.0)
       http-cookie (>= 1.0.2, < 2.0)
       mime-types (>= 1.16, < 4.0)
       netrc (~> 0.8)
+    rexml (3.2.6)
+    rubocop (1.60.2)
+      json (~> 2.3)
+      language_server-protocol (>= 3.17.0)
+      parallel (~> 1.10)
+      parser (>= 3.3.0.2)
+      rainbow (>= 2.2.2, < 4.0)
+      regexp_parser (>= 1.8, < 3.0)
+      rexml (>= 3.2.5, < 4.0)
+      rubocop-ast (>= 1.30.0, < 2.0)
+      ruby-progressbar (~> 1.7)
+      unicode-display_width (>= 2.4.0, < 3.0)
+    rubocop-ast (1.30.0)
+      parser (>= 3.2.1.0)
+    ruby-progressbar (1.13.0)
     test-unit (3.6.2)
       power_assert
+    unicode-display_width (2.5.0)
     websocket-driver (0.7.6)
       websocket-extensions (>= 0.1.0)
     websocket-extensions (0.1.5)
@@ -34,6 +60,7 @@ DEPENDENCIES
   faye-websocket
   openssl
   rest-client
+  rubocop
   test-unit
 
 BUNDLED WITH

Gemfile.lock

@@ -1,5 +1,6 @@
 # frozen_string_literal: true
 
+# rubocop:disable Layout/LineLength
 require_relative 'http_manager'
 
 module Cryptomarket

lib/cryptomarket/client.rb

@@ -10,8 +10,9 @@
 
 module Cryptomarket
   # Builds a credential used by the cryptomarket server
-  class CredentialFactory
-    def initialize(api_key:, api_secret:, window: nil)
+  class CredentialsFactory
+    def initialize(api_version:, api_key:, api_secret:, window: nil)
+      @api_version = api_version
       @api_key = api_key
       @api_secret = api_secret
       @window = window
@@ -29,7 +30,7 @@ def get_credential(http_method, method, params)
     end
 
     def build_credential_message(http_method, method, timestamp, params)
-      msg = http_method + @@api_version + method
+      msg = http_method + @api_version + method
       msg += if http_method.upcase == 'POST'
                params
              else

lib/cryptomarket/credentials_factory.rb

@@ -7,34 +7,35 @@
 require 'rest-client'
 require 'date'
 require_relative 'exceptions'
-require_relative 'credential_factory'
+require_relative 'credentials_factory'
 
 module Cryptomarket
   # Manager of http requests to the cryptomarket server
   class HttpManager
-    Request = Data.define(:uri, :endpoint, :payload, :headers, :is_json)
     @@API_URL = 'https://api.exchange.cryptomkt.com' # rubocop:disable Naming/VariableName,Style/ClassVars
     @@API_VERSION = '/api/3/' # rubocop:disable Naming/VariableName,Style/ClassVars
 
     def initialize(api_key:, api_secret:, window: nil)
-      @credential_factory = CredentialFactory(api_key, api_secret, window)
+      @credential_factory = Cryptomarket::CredentialsFactory.new(
+        api_version: @@API_VERSION, api_key: api_key, api_secret: api_secret, window: window
+      )
     end
 
     def make_request(method:, endpoint:, params: nil, public: false)
-      uri = URI(@@API_URL + version_as_str + endpoint)
+      uri = URI(@@API_URL + @@API_VERSION + endpoint)
       payload = build_payload(params)
       headers = build_headers(method, endpoint, params, public)
       if ((method.upcase == 'GET') || (method.upcase == 'PUT')) && !payload.nil?
-        payload = nil
         uri.query = URI.encode_www_form payload
+        payload = nil
       end
-      do_request(Request[method, uri, payload, headers, false])
+      do_request(method, uri, payload, headers)
     end
 
     def make_post_request(method:, endpoint:, params: nil)
-      uri = URI(@@API_URL + version_as_str + endpoint)
+      uri = URI(@@API_URL + @@API_VERSION + endpoint)
       payload = build_payload(params)
-      do_request(Request[method, uri, payload, build_post_headers(endpoint, payload), true])
+      do_request(method, uri, payload, build_post_headers(endpoint, payload), is_json: true)
     end
 
     def build_headers(method, endpoint, params, public)
@@ -51,12 +52,11 @@ def build_payload(params)
       payload
     end
 
-    def do_request(request:)
+    def do_request(method, uri, payload, headers, is_json: false)
       response = RestClient::Request.execute(
-        method: request.method.downcase.to_sym, url: request.uri.to_s,
-        payload: request.payload.to_json, headers: request.headers
+        method: method.downcase.to_sym, url: uri.to_s, payload: payload.to_json, headers: headers
       )
-      response[:content_type] = :json if request.is_json
+      response[:content_type] = :json if is_json
       handle_response(response)
     rescue RestClient::ExceptionWithResponse => e
       handle_response(e.response)

lib/cryptomarket/http_manager.rb

@@ -1,5 +1,6 @@
 # frozen_string_literal: true
 
+# rubocop:disable Layout/LineLength
 require 'securerandom'
 
 require_relative 'market_data_client_core'
@@ -269,9 +270,7 @@ def subscribe_to_top_of_book_in_batches(callback:, speed:, symbols: ['*'], resul
 
       def subscribe_to_price_rates(callback:, speed:, target_currency:, currencies: ['*'], result_callback: nil)
         params = {
-          speed: speed,
-          target_currency: target_currency,
-          currencies: currencies
+          speed: speed, target_currency: target_currency, currencies: currencies
         }
         send_channel_subscription("price/rate/#{speed}", params, callback,
                                   intercept_result_callback(result_callback))
@@ -295,9 +294,7 @@ def subscribe_to_price_rates(callback:, speed:, target_currency:, currencies: ['
       def subscribe_to_price_rates_in_batches(callback:, speed:, target_currency:, currencies: ['*'],
                                               result_callback: nil)
         params = {
-          speed: speed,
-          target_currency: target_currency,
-          currencies: currencies
+          speed: speed, target_currency: target_currency, currencies: currencies
         }
         send_channel_subscription("price/rate/#{speed}/batch", params, callback,
                                   intercept_result_callback(result_callback))

lib/cryptomarket/websocket/market_data_client.rb

@@ -1,5 +1,6 @@
 # frozen_string_literal: true
 
+# rubocop:disable Layout/LineLength
 require_relative 'auth_client'
 require_relative '../constants'
 
@@ -177,10 +178,7 @@ def create_spot_order( # rubocop:disable Metrics/ParameterLists
       # +Proc+ +callback+:: Optional. A +Proc+ of two arguments, An exception and a result, called either with the exception or with the result, a list of reports of the created orders
 
       def create_spot_order_list(
-        orders:,
-        contingency_type:,
-        order_list_id: nil,
-        callback: nil
+        orders:, contingency_type:, order_list_id: nil, callback: nil
       )
         request('spot_new_order_list', callback, {
                   orders: orders, contingency_type: contingency_type, order_list_id: order_list_id

lib/cryptomarket/websocket/trading_client.rb

@@ -1,5 +1,6 @@
 # frozen_string_literal: true
 
+# rubocop:disable Layout/LineLength
 require_relative 'auth_client'
 require_relative '../constants'