Skip to content

Commit 26e3969

Browse files
committed
fix: comments deposit fee methods
1 parent e159938 commit 26e3969

File tree

2 files changed

+37
-37
lines changed

2 files changed

+37
-37
lines changed

lib/cryptomarket/client.rb

Lines changed: 27 additions & 27 deletions
Original file line numberDiff line numberDiff line change
@@ -885,33 +885,33 @@ def get_estimate_withdrawal_fee(currency:, amount:, network_code: nil)
885885
get('wallet/crypto/fee/estimate', params)['fee']
886886
end
887887

888-
# Get an estimates for deposit fees of currencies
889-
#
890-
# Requires the "Payment information" API key Access Right
891-
#
892-
# https://api.exchange.cryptomkt.com/#bulk-estimate-deposit-fee
893-
#
894-
# ==== Params
895-
# +Array[]+ +fee_requests+:: the list of fee requests, each request is a Hash in the form {currency:"string", amount:"string", network_code:"optional string"}
896-
def get_bulk_estimate_deposit_fees(fee_requests:)
897-
params = fee_requests
898-
post('wallet/crypto/fee/deposit/estimate/bulk', params)
899-
end
900-
901-
# Get an estimate of the deposit fee
902-
#
903-
# Requires the "Payment information" API key Access Right
904-
#
905-
# https://api.exchange.cryptomkt.com/#estimate-deposit-fee
906-
#
907-
# ==== Params
908-
# +String+ +currency+:: the currency code for deposit
909-
# +float+ +amount+:: the expected deposit amount
910-
911-
def get_estimate_deposit_fee(currency:, amount:, network_code: nil)
912-
params = { amount: amount, currency: currency, network_code: network_code }
913-
get('wallet/crypto/fee/deposit/estimate', params)['fee']
914-
end
888+
# # Get an estimates for deposit fees of currencies
889+
# #
890+
# # Requires the "Payment information" API key Access Right
891+
# #
892+
# # https://api.exchange.cryptomkt.com/#bulk-estimate-deposit-fee
893+
# #
894+
# # ==== Params
895+
# # +Array[]+ +fee_requests+:: the list of fee requests, each request is a Hash in the form {currency:"string", amount:"string", network_code:"optional string"}
896+
# def get_bulk_estimate_deposit_fees(fee_requests:)
897+
# params = fee_requests
898+
# post('wallet/crypto/fee/deposit/estimate/bulk', params)
899+
# end
900+
901+
# # Get an estimate of the deposit fee
902+
# #
903+
# # Requires the "Payment information" API key Access Right
904+
# #
905+
# # https://api.exchange.cryptomkt.com/#estimate-deposit-fee
906+
# #
907+
# # ==== Params
908+
# # +String+ +currency+:: the currency code for deposit
909+
# # +float+ +amount+:: the expected deposit amount
910+
911+
# def get_estimate_deposit_fee(currency:, amount:, network_code: nil)
912+
# params = { amount: amount, currency: currency, network_code: network_code }
913+
# get('wallet/crypto/fee/deposit/estimate', params)['fee']
914+
# end
915915

916916
# Converts between currencies
917917
# Successful response to the request does not necessarily mean the resulting transaction got executed immediately. It has to be processed first and may eventually be rolled back

tests/rest/wallet_management.rb

Lines changed: 10 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -62,16 +62,16 @@ def test_get_estimate_withdrawal_fee
6262
assert(!result.empty?)
6363
end
6464

65-
def test_get_bulk_estimate_deposit_fees
66-
result = @client.get_bulk_estimate_deposit_fees fee_requests: [{ currency: 'ETH', amount: '12' },
67-
{ currency: 'BTC', amount: '1' }]
68-
assert(result.count == 2)
69-
end
70-
71-
def test_get_estimate_deposit_fee
72-
result = @client.get_estimate_deposit_fee currency: 'XLM', amount: '3'
73-
assert(!result.empty?)
74-
end
65+
# def test_get_bulk_estimate_deposit_fees
66+
# result = @client.get_bulk_estimate_deposit_fees fee_requests: [{ currency: 'ETH', amount: '12' },
67+
# { currency: 'BTC', amount: '1' }]
68+
# assert(result.count == 2)
69+
# end
70+
71+
# def test_get_estimate_deposit_fee
72+
# result = @client.get_estimate_deposit_fee currency: 'XLM', amount: '3'
73+
# assert(!result.empty?)
74+
# end
7575

7676
def test_crypto_address_belongs_to_current_account
7777
ada_address = @client.get_deposit_crypto_address(currency: 'ADA')['address']

0 commit comments

Comments
 (0)