fix: last commit

Author: Insmael

lib/cryptomarket/client.rb

@@ -39,12 +39,23 @@ def delete(endpoint, params = nil)
       @http_manager.make_request(method: 'delete', endpoint: endpoint, params: params)
     end
 
+    # Changes the user credentials used for authentication in calls
+    #
+    # ==== Params
+    # +String+ +api_key+:: The user public key used in new calls
+    # +String+ +api_secret+:: The user secret key used in new calls
+
     def change_credentials(api_key:, api_secret:)
-      @credential_factory.change_credentials(api_key, api_secret)
+      @http_manager.change_credentials(api_key: api_key, api_secret: api_secret)
     end
 
+    # Changes the window used in authenticated calls
+    #
+    # ==== Params
+    # +Integer+ +window+:: Acceptable time between request and server execution in millis
+
     def change_window(window:)
-      @credential_factory.change_window(window)
+      @http_manager.change_window(window: window)
     end
 
     ################

lib/cryptomarket/credentials_factory.rb

@@ -46,7 +46,7 @@ def build_credential_message(http_method, method, timestamp, params)
                not_post_params(http_method, params)
              end
       msg += timestamp
-      msg += @window unless @window.nil?
+      msg += @window.to_s unless @window.nil?
       msg
     end
 

lib/cryptomarket/http_manager.rb

@@ -38,11 +38,11 @@ def initialize(api_key:, api_secret:, window: nil)
     end
 
     def change_credentials(api_key:, api_secret:)
-      @credential_factory.change_credentials(api_key, api_secret)
+      @credential_factory.change_credentials(api_key: api_key, api_secret: api_secret)
     end
 
     def change_window(window:)
-      @credential_factory.change_window(window)
+      @credential_factory.change_window(window: window)
     end
 
     def make_request(method:, endpoint:, params: nil, public: false)

tests/rest/change_credentials.rb

@@ -0,0 +1,29 @@
+# frozen_string_literal: true
+
+require 'test/unit'
+require_relative '../key_loader'
+require_relative '../checks'
+require_relative '../../lib/cryptomarket/client'
+
+class ChangeCredentials < Test::Unit::TestCase # rubocop:disable Style/Documentation
+  def setup
+    @client = Cryptomarket::Client.new api_key: KeyLoader.api_key, api_secret: KeyLoader.api_secret
+  end
+
+  def test_change_credentials
+    result = @client.get_wallet_balances
+    assert(good_list(->(balance) { Check.good_balance(balance) }, result))
+
+    @client.change_credentials api_key: '', api_secret: ''
+    begin
+      @client.get_wallet_balances
+      assert(false)
+    rescue Cryptomarket::APIException
+      nil
+    end
+
+    @client.change_credentials api_key: KeyLoader.api_key, api_secret: KeyLoader.api_secret
+    result = @client.get_wallet_balances
+    assert(good_list(->(balance) { Check.good_balance(balance) }, result))
+  end
+end

tests/rest/change_window.rb

@@ -0,0 +1,29 @@
+# frozen_string_literal: true
+
+require 'test/unit'
+require_relative '../key_loader'
+require_relative '../checks'
+require_relative '../../lib/cryptomarket/client'
+
+class ChangeWindow < Test::Unit::TestCase # rubocop:disable Style/Documentation
+  def setup
+    @client = Cryptomarket::Client.new api_key: KeyLoader.api_key, api_secret: KeyLoader.api_secret
+  end
+
+  def test_change_window
+    result = @client.get_wallet_balances
+    assert(good_list(->(balance) { Check.good_balance(balance) }, result))
+
+    @client.change_window window: 100
+    begin
+      @client.get_wallet_balances
+      assert(false)
+    rescue Cryptomarket::APIException
+      nil
+    end
+
+    @client.change_window window: 10_000
+    result = @client.get_wallet_balances
+    assert(good_list(->(balance) { Check.good_balance(balance) }, result))
+  end
+end

tests/rest/test_suite.rb

@@ -6,3 +6,5 @@
 require_relative 'spot_trading_history'
 require_relative 'spot_trading'
 require_relative 'wallet_management'
+require_relative 'change_window'
+require_relative 'change_credentials'