Replace Time.monotonic with Time.instant (#16498)

Author: straight-shoota

spec/std/crystal/event_loop/polling/poll_descriptor_spec.cr

@@ -31,7 +31,7 @@ class Crystal::EventLoop::FakeLoop < Crystal::EventLoop::Polling
     operations << {:del, fd, closing}
   end
 
-  private def system_set_timer(time : Time::Span?) : Nil
+  private def system_set_timer(time : Time::Instant?) : Nil
   end
 end
 

spec/std/crystal/event_loop/timers_spec.cr

@@ -4,10 +4,10 @@ require "crystal/event_loop/timers"
 private struct Timer
   include Crystal::PointerPairingHeap::Node
 
-  property! wake_at : Time::Span
+  property! wake_at : Time::Instant
 
   def initialize(timeout : Time::Span? = nil)
-    @wake_at = Time.monotonic + timeout if timeout
+    @wake_at = Crystal::System::Time.instant + timeout if timeout
   end
 
   def heap_compare(other : Pointer(self)) : Bool
@@ -89,7 +89,7 @@ describe Crystal::EventLoop::Timers do
     timers.add(pointerof(event2)).should be_false
     timers.add(pointerof(event3)).should be_false
 
-    event0.wake_at = -1.minute
+    event0.wake_at = Crystal::System::Time.instant - 1.minute
     timers.add(pointerof(event0)).should be_true # added new head (next ready)
   end
 

spec/std/http/spec_helper.cr

@@ -11,12 +11,12 @@ private def wait_for(&)
             {% else %}
               5.seconds
             {% end %}
-  now = Time.monotonic
+  now = Time.instant
 
   until yield
     Fiber.yield
 
-    if (Time.monotonic - now) > timeout
+    if now.elapsed > timeout
       raise "server failed to start within #{timeout}"
     end
   end

spec/std/sync/spec_helper.cr

@@ -3,15 +3,15 @@ require "wait_group"
 
 module Sync
   def self.eventually(timeout : Time::Span = 1.second, &)
-    start = Time.monotonic
+    start = Time.instant
 
     loop do
       Fiber.yield
 
       begin
         yield
       rescue ex
-        raise ex if (Time.monotonic - start) > timeout
+        raise ex if start.elapsed > timeout
       else
         break
       end

spec/support/fibers.cr

@@ -1,17 +1,17 @@
 def wait_until_blocked(f : Fiber, timeout = 5.seconds)
-  now = Time.monotonic
+  now = Time.instant
 
   until f.resumable?
     Fiber.yield
-    raise "Fiber failed to block within #{timeout}" if (Time.monotonic - now) > timeout
+    raise "Fiber failed to block within #{timeout}" if now.elapsed > timeout
   end
 end
 
 def wait_until_finished(f : Fiber, timeout = 5.seconds)
-  now = Time.monotonic
+  now = Time.instant
   until f.dead?
     Fiber.yield
-    raise "Fiber failed to finish within #{timeout}" if (Time.monotonic - now) > timeout
+    raise "Fiber failed to finish within #{timeout}" if now.elapsed > timeout
   end
 end
 

src/benchmark.cr

@@ -131,9 +131,9 @@ module Benchmark
 
   # Returns the time used to execute the given block.
   def measure(label = "", &) : BM::Tms
-    t0, r0 = Process.times, Time.monotonic
+    t0, r0 = Process.times, Time.instant
     yield
-    t1, r1 = Process.times, Time.monotonic
+    t1, r1 = Process.times, Time.instant
     BM::Tms.new(t1.utime - t0.utime,
       t1.stime - t0.stime,
       t1.cutime - t0.cutime,

src/benchmark/ips.cr

@@ -67,9 +67,9 @@ module Benchmark
 
           count = 0_u64
           elapsed = Time.measure do
-            target = Time.monotonic + @warmup_time
+            target = Time.instant + @warmup_time
 
-            while Time.monotonic < target
+            while Time.instant < target
               item.call
               count += 1
             end
@@ -87,7 +87,7 @@ module Benchmark
           bytes = 0_i64
           cycles = 0_i64
 
-          target = Time.monotonic + @calculation_time
+          target = Time.instant + @calculation_time
 
           loop do
             elapsed = nil
@@ -97,7 +97,7 @@ module Benchmark
             bytes += bytes_taken
             cycles += item.cycles
             measurements << elapsed.not_nil!
-            break if Time.monotonic >= target
+            break if Time.instant >= target
           end
 
           ips = measurements.map { |m| item.cycles.to_f / m.total_seconds }

src/compiler/crystal/macros/macros.cr

@@ -82,7 +82,7 @@ class Crystal::Program
   end
 
   def macro_compile(filename)
-    time = Time.monotonic
+    time = Time.instant
 
     source = File.read(filename)
 
@@ -107,8 +107,7 @@ class Crystal::Program
     {% end %}
 
     if can_reuse_previous_compilation?(filename, executable_path, recorded_requires_path, requires_path)
-      elapsed_time = Time.monotonic - time
-      return CompiledMacroRun.new(executable_path, elapsed_time, true)
+      return CompiledMacroRun.new(executable_path, time.elapsed, true)
     end
 
     result = host_compiler.compile Compiler::Source.new(filename, source), executable_path
@@ -131,8 +130,7 @@ class Crystal::Program
       requires_with_timestamps.to_json(file)
     end
 
-    elapsed_time = Time.monotonic - time
-    CompiledMacroRun.new(executable_path, elapsed_time, false)
+    CompiledMacroRun.new(executable_path, time.elapsed, false)
   end
 
   @host_compiler : Compiler?

src/compiler/crystal/progress_tracker.cr

@@ -18,9 +18,9 @@ module Crystal
       print_stats
       print_progress
 
-      time_start = Time.monotonic
+      time_start = Time.instant
       retval = yield
-      time_taken = Time.monotonic - time_start
+      time_taken = time_start.elapsed
 
       print_stats(time_taken)
       print_progress

src/crystal/event_loop/epoll.cr

@@ -122,7 +122,7 @@ class Crystal::EventLoop::Epoll < Crystal::EventLoop::Polling
     @epoll.delete(fd) { yield }
   end
 
-  private def system_set_timer(time : Time::Span?) : Nil
+  private def system_set_timer(time : Time::Instant?) : Nil
     if time
       @timerfd.set(time)
     else