Fix shellcheck violations (#16221)

Author: straight-shoota

etc/win-ci/build-iconv.ps1

@@ -16,7 +16,7 @@ Run-InDirectory $BuildTree {
     $env:CHERE_INVOKING = 1
     [System.IO.File]::WriteAllText("src\Makefile.in", [System.IO.File]::ReadAllText("src\Makefile.in").Replace("chmod 777 .", "true"))
 
-    & 'C:\cygwin64\bin\bash.exe' --login "$PSScriptRoot\cygwin-build-iconv.sh" "$Version" "$(if ($Dynamic) { 1 })"
+    & 'C:\cygwin64\bin\bash.exe' --login "$PSScriptRoot\cygwin-build-iconv.sh" "$(if ($Dynamic) { 1 })"
     if (-not $?) {
         Write-Host "Error: Failed to build libiconv" -ForegroundColor Red
         Exit 1

etc/win-ci/cygwin-build-iconv.sh

@@ -1,9 +1,9 @@
 #!/bin/sh
+# shellcheck disable=SC2155
 
-set -eo pipefail
+set -e
 
-Version=$1
-Dynamic=$2
+Dynamic=$1
 
 export PATH="$(pwd)/build-aux:$PATH"
 export CC="$(pwd)/build-aux/compile cl -nologo"
@@ -26,7 +26,7 @@ else
   # GNU libiconv appears to define `BUILDING_DLL` unconditionally, so the static
   # library contains `/EXPORT` directives that make any executable also export
   # the iconv symbols, which we don't want
-  find . '(' -name '*.h' -or -name '*.h.build.in' ')' -print0 | xargs -0 -i sed -i 's/__declspec(dllexport)//' '{}'
+  find . '(' -name '*.h' -or -name '*.h.build.in' ')' -print0 | xargs -0 -I{} sed -i 's/__declspec(dllexport)//' '{}'
 fi
 export CPPFLAGS="-O2 -D_WIN32_WINNT=_WIN32_WINNT_WIN7 -I$(pwd)/iconv/include"
 export LDFLAGS="-L$(pwd)/iconv/lib"

spec/llvm-ir/test.sh

@@ -9,7 +9,7 @@ SCRIPT_PATH="$(realpath "$0")"
 SCRIPT_ROOT="$(dirname "$SCRIPT_PATH")"
 
 BUILD_DIR=$SCRIPT_ROOT/../../.build
-LLVM_CONFIG="$(basename $("$SCRIPT_ROOT"/../../src/llvm/ext/find-llvm-config.sh))"
+LLVM_CONFIG="$(basename "$("$SCRIPT_ROOT"/../../src/llvm/ext/find-llvm-config.sh)")"
 FILE_CHECK=FileCheck-"${LLVM_CONFIG#llvm-config-}"
 crystal=${CRYSTAL_SPEC_COMPILER_BIN:-$SCRIPT_ROOT/../../bin/crystal}