Skip to content

Commit 8fa7f90

Browse files
[CI] Add fail-fast: false to all matrix strategies (#16656)
We almost always want `fail-fast: false`: If one matrix job fails, the others should still run. This patch adds it when missing and moves it always as the first item for better visibility.
1 parent 23b1aad commit 8fa7f90

File tree

4 files changed

+4
-3
lines changed

4 files changed

+4
-3
lines changed

.github/workflows/interpreter.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -51,9 +51,9 @@ jobs:
5151
container:
5252
image: crystallang/crystal:1.19.1-build
5353
strategy:
54+
fail-fast: false
5455
matrix:
5556
part: [0, 1, 2, 3]
56-
fail-fast: false
5757
name: "Test std_spec with interpreter (${{ matrix.part }})"
5858
steps:
5959
- uses: actions/checkout@v6

.github/workflows/linux.yml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -61,6 +61,7 @@ jobs:
6161
ARCH_CMD: linux64
6262
runs-on: ${{ case(startsWith(matrix.arch, 'aarch64'), 'ubuntu-24.04-arm', 'ubuntu-latest') }}
6363
strategy:
64+
fail-fast: false
6465
matrix:
6566
arch:
6667
- x86_64

.github/workflows/macos.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,6 +17,7 @@ jobs:
1717
runs-on: ${{ matrix.runs-on }}
1818
name: "${{ matrix.runs-on }} (${{ matrix.arch }})"
1919
strategy:
20+
fail-fast: false
2021
matrix:
2122
include:
2223
- runs-on: macos-15-intel
@@ -25,7 +26,6 @@ jobs:
2526
arch: aarch64-darwin
2627
- runs-on: macos-15
2728
arch: aarch64-darwin
28-
fail-fast: false
2929
steps:
3030
- name: Download Crystal source
3131
uses: actions/checkout@v6

.github/workflows/smoke.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -61,8 +61,8 @@ jobs:
6161
runs-on: ubuntu-latest
6262

6363
strategy:
64-
max-parallel: 2
6564
fail-fast: false
65+
max-parallel: 2
6666
matrix:
6767
target:
6868
- aarch64-linux-android

0 commit comments

Comments
 (0)