Remove redundant begin/end blocks (#16554)

Author: straight-shoota

src/compiler/crystal/codegen/cache_dir.cr

@@ -95,12 +95,10 @@ module Crystal
 
       # Return the first one for which we could create a directory
       candidates.each do |candidate|
-        begin
-          Dir.mkdir_p(candidate)
-          return @dir = candidate
-        rescue File::Error
-          # Try next one
-        end
+        Dir.mkdir_p(candidate)
+        return @dir = candidate
+      rescue File::Error
+        # Try next one
       end
 
       msg = String.build do |io|

src/compiler/crystal/command.cr

@@ -277,35 +277,33 @@ class Crystal::Command
   private def execute(output_filename, run_args, compiler, *, error_on_exit = false)
     time = @time && !@progress_tracker.stats?
     status, elapsed_time = @progress_tracker.stage("Execute") do
-      begin
-        elapsed = Time.measure do
-          Process.run(output_filename, args: run_args, input: Process::Redirect::Inherit, output: Process::Redirect::Inherit, error: Process::Redirect::Inherit) do |process|
-            {% unless flag?(:wasm32) %}
-              # Ignore the signal so we don't exit the running process
-              # (the running process can still handle this signal)
-              Process.ignore_interrupts!
-            {% end %}
-          end
+      elapsed = Time.measure do
+        Process.run(output_filename, args: run_args, input: Process::Redirect::Inherit, output: Process::Redirect::Inherit, error: Process::Redirect::Inherit) do |process|
+          {% unless flag?(:wasm32) %}
+            # Ignore the signal so we don't exit the running process
+            # (the running process can still handle this signal)
+            Process.ignore_interrupts!
+          {% end %}
         end
-        {$?, elapsed}
-      ensure
-        File.delete?(output_filename)
-
-        # Delete related PDB generated by MSVC, if any exist
-        {% if flag?(:msvc) %}
-          unless compiler.debug.none?
-            basename = output_filename.rchop(".exe")
-            File.delete?("#{basename}.pdb")
-          end
-        {% end %}
-
-        # Delete related dwarf generated by dsymutil, if any exist
-        {% if flag?(:darwin) %}
-          unless compiler.debug.none?
-            File.delete?("#{output_filename}.dwarf")
-          end
-        {% end %}
       end
+      {$?, elapsed}
+    ensure
+      File.delete?(output_filename)
+
+      # Delete related PDB generated by MSVC, if any exist
+      {% if flag?(:msvc) %}
+        unless compiler.debug.none?
+          basename = output_filename.rchop(".exe")
+          File.delete?("#{basename}.pdb")
+        end
+      {% end %}
+
+      # Delete related dwarf generated by dsymutil, if any exist
+      {% if flag?(:darwin) %}
+        unless compiler.debug.none?
+          File.delete?("#{output_filename}.dwarf")
+        end
+      {% end %}
     end
 
     if time

src/compiler/crystal/macros/macros.cr

@@ -197,13 +197,11 @@ class Crystal::Program
     # We start with the target filename
     required_files = Set{filename}
     recorded_requires.map do |recorded_require|
-      begin
-        files = @program.find_in_path(recorded_require.filename, recorded_require.relative_to)
-        required_files.concat(files) if files
-      rescue Crystal::CrystalPath::NotFoundError
-        # Maybe the file is gone
-        next
-      end
+      files = @program.find_in_path(recorded_require.filename, recorded_require.relative_to)
+      required_files.concat(files) if files
+    rescue Crystal::CrystalPath::NotFoundError
+      # Maybe the file is gone
+      next
     end
 
     new_requires_with_timestamps = required_files.map do |required_file|

src/compiler/crystal/semantic/semantic_visitor.cr

@@ -443,12 +443,10 @@ abstract class Crystal::SemanticVisitor < Crystal::Visitor
     skip_macro_exception = nil
 
     generated_nodes = expand_macro(the_macro, node, mode: mode, visibility: :public, accept: accept) do
-      begin
-        @program.expand_macro node, (@scope || current_type), @path_lookup, free_vars, @untyped_def
-      rescue ex : SkipMacroException
-        skip_macro_exception = ex
-        {ex.expanded_before_skip, ex.macro_expansion_pragmas}
-      end
+      @program.expand_macro node, (@scope || current_type), @path_lookup, free_vars, @untyped_def
+    rescue ex : SkipMacroException
+      skip_macro_exception = ex
+      {ex.expanded_before_skip, ex.macro_expansion_pragmas}
     end
 
     node.expanded = generated_nodes

src/compiler/crystal/semantic/top_level_visitor.cr

@@ -858,13 +858,11 @@ class Crystal::TopLevelVisitor < Crystal::SemanticVisitor
 
   def visit(node : Expressions)
     node.expressions.each_with_index do |child, i|
-      begin
-        child.accept self
-      rescue ex : SkipMacroException
-        @program.macro_expansion_error_hook.try &.call(ex.cause) if ex.is_a? SkipMacroCodeCoverageException
-        node.expressions.delete_at(i..-1)
-        break
-      end
+      child.accept self
+    rescue ex : SkipMacroException
+      @program.macro_expansion_error_hook.try &.call(ex.cause) if ex.is_a? SkipMacroCodeCoverageException
+      node.expressions.delete_at(i..-1)
+      break
     end
     false
   end

src/compiler/crystal/syntax/parser.cr

@@ -5406,17 +5406,15 @@ module Crystal
     # Looks ahead next tokens to check whether they indicate type.
     def type_start?(*, consume_newlines)
       peek_ahead do
-        begin
-          if consume_newlines
-            next_token_skip_space_or_newline
-          else
-            next_token_skip_space
-          end
-
-          type_start?
-        rescue
-          false
+        if consume_newlines
+          next_token_skip_space_or_newline
+        else
+          next_token_skip_space
         end
+
+        type_start?
+      rescue
+        false
       end
     end
 

src/compiler/crystal/tools/playground/server.cr

@@ -187,21 +187,19 @@ module Crystal::Playground
     private def bind_io_as_output(tag, io)
       spawn do
         loop do
-          begin
-            output = String.new(4096) do |buffer|
-              length = io.read_utf8(Slice.new(buffer, 4096))
-              {length, 0}
-            end
-            break if output.empty?
+          output = String.new(4096) do |buffer|
+            length = io.read_utf8(Slice.new(buffer, 4096))
+            {length, 0}
+          end
+          break if output.empty?
 
-            send_with_json_builder do |json|
-              json.field "type", "output"
-              json.field "tag", tag
-              json.field "content", output
-            end
-          rescue
-            break
+          send_with_json_builder do |json|
+            json.field "type", "output"
+            json.field "tag", tag
+            json.field "content", output
           end
+        rescue
+          break
         end
       end
     end

src/crystal/event_loop/polling/arena.cr

@@ -148,11 +148,9 @@ class Crystal::EventLoop::Polling::Arena(T, BLOCK_BYTESIZE)
   # *index* is out of bounds.
   def free(index : Index, &) : Nil
     at?(index) do |entry|
-      begin
-        yield entry.value.pointer
-      ensure
-        entry.value.free
-      end
+      yield entry.value.pointer
+    ensure
+      entry.value.free
     end
   end
 

src/file_utils.cr

@@ -333,10 +333,8 @@ module FileUtils
   def mv(srcs : Enumerable(Path | String), dest : Path | String) : Nil
     raise ArgumentError.new("No such directory : #{dest}") unless Dir.exists?(dest)
     srcs.each do |src|
-      begin
-        mv(src, File.join(dest, File.basename(src)))
-      rescue File::Error
-      end
+      mv(src, File.join(dest, File.basename(src)))
+    rescue File::Error
     end
   end
 
@@ -441,10 +439,8 @@ module FileUtils
   # ```
   def rm_rf(paths : Enumerable(Path | String)) : Nil
     paths.each do |path|
-      begin
-        rm_r(path)
-      rescue File::Error
-      end
+      rm_r(path)
+    rescue File::Error
     end
   end
 

src/json/any.cr

@@ -299,15 +299,13 @@ struct JSON::Any
     inspect_key = {0_u64, :__json_inspect__}
 
     hash.put(inspect_key, nil) do
-      begin
-        # here's the root case, where we wrap with JSON::Any(...)
-        io << "JSON::Any("
-        @raw.inspect(io)
-        io << ")"
-        return
-      ensure
-        hash.delete(inspect_key)
-      end
+      # here's the root case, where we wrap with JSON::Any(...)
+      io << "JSON::Any("
+      @raw.inspect(io)
+      io << ")"
+      return
+    ensure
+      hash.delete(inspect_key)
     end
 
     # This is the non-root case, where we don't wrap with anything.