Skip to content

Create argv before fork #16286

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Nov 1, 2025
Merged

Create argv before fork #16286

merged 7 commits into from
Nov 1, 2025
+43 −45

Conversation

@straight-shoota
Copy link
Member

@straight-shoota straight-shoota commented Oct 27, 2025 •
edited
Loading

Reduces code executing between fork and exec. Most importantly, removes the unsafe allocation from command_args.map.

@straight-shoota straight-shoota self-assigned this Oct 27, 2025
@straight-shoota straight-shoota added kind:bug A bug in the code. Does not apply to documentation, specs, etc. topic:stdlib:system platform:unix labels Oct 27, 2025
@straight-shoota straight-shoota force-pushed the refactor/argv-before-fork branch from ff168ee to 8924397 Compare October 28, 2025 08:50
ysbaddaden
ysbaddaden approved these changes Oct 28, 2025
View reviewed changes
@ysbaddaden ysbaddaden added this to the 1.19.0 milestone Oct 28, 2025
@ysbaddaden
Copy link
Contributor

ysbaddaden commented Oct 28, 2025

Now I'm confused with command and prepared_args 😵

@straight-shoota
Copy link
Member Author

straight-shoota commented Oct 28, 2025

prepared_args are the exact arguments to execvp, i.e. already transformed to C types.
command is usually the same value as prepared_args[1][0], but as a String instead of a C string (UInt8*).

Actually, it should probably better be LibC::Char*.

@straight-shoota straight-shoota removed this from the 1.19.0 milestone Oct 29, 2025
@straight-shoota straight-shoota added this to the 1.19.0 milestone Oct 31, 2025
@straight-shoota straight-shoota merged commit 6f69506 into crystal-lang:master Nov 1, 2025
40 checks passed
@straight-shoota straight-shoota deleted the refactor/argv-before-fork branch November 1, 2025 22:54
straight-shoota added a commit to straight-shoota/crystal that referenced this pull request Nov 4, 2025
@straight-shoota
Fixup call execvpe wrapper instead of LibC.execvpe
9e27179 
Fixup for unintended change in crystal-lang#16286
straight-shoota
straight-shoota commented Nov 4, 2025
View reviewed changes
@straight-shoota straight-shoota mentioned this pull request Nov 4, 2025
Merged
straight-shoota added a commit that referenced this pull request Nov 4, 2025
@straight-shoota
Fixup call execvpe wrapper instead of LibC.execvpe (#16321)
7572ca2 
Fixup for unintended change in #16286. It should've stayed using the `execvpe` wrapper from #16294

Fixes #16286 (comment)
@straight-shoota straight-shoota mentioned this pull request Nov 5, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ysbaddaden ysbaddaden ysbaddaden approved these changes

Assignees

@straight-shoota straight-shoota

Labels

kind:bug A bug in the code. Does not apply to documentation, specs, etc. platform:unix topic:stdlib:system

Projects

None yet

Milestone

1.19.0

Development

Successfully merging this pull request may close these issues.

2 participants

@straight-shoota @ysbaddaden