Update shards release process (#279)

Author: straight-shoota

processes/scripts/prepare-shards-release.sh

@@ -12,14 +12,24 @@
 set -eu
 
 if [ $# -lt 1 ]; then
-  echo "Usage: $0 VERSION"
-  exit 1
-fi
+  printf "Release version: "
+  read VERSION
 
-VERSION=$1
+  if [ -z "$VERSION" ]; then
+    echo "Usage: $0 VERSION"
+    exit 1
+  fi
+else
+  VERSION=$1
+fi
 
 . $(dirname $(realpath $0))/functions.sh
 
+if [[ ! "$VERSION" =~ ^[0-9] ]]; then
+  echo "Invalid VERSION: ${VERSION}"
+  exit 1
+fi
+
 case $VERSION in
   *.0.0)
     TYPE=major
@@ -48,5 +58,7 @@ case $TYPE in
   ;;
 esac
 
+body=$(echo "$body" | sed -E "s/\\$\{VERSION\}/$VERSION/g")
+
 body=$(printf "%q" "$body")
 step "Create tracking issue in crystal-lang/distribution-scripts" gh issue create -R crystal-lang/distribution-scripts --body "$body" --label "release" --title \"Release Shards $VERSION\"

processes/shards-release.md

@@ -1,6 +1,6 @@
 # Shards release process checklist
 
-Add an issue `Shards release X.Y.Z` in https://github.com/crystal-lang/distribution-scripts/issues with a copy of this document. In this way it's easy to track the progress of the release (*Helper script: [`scripts/prepare-shards-release.sh`](./scripts/prepare-shards-release.sh)*)
+Add an issue `Shards release ${VERSION}` in https://github.com/crystal-lang/distribution-scripts/issues with a copy of this document. In this way it's easy to track the progress of the release (*Helper script: [`scripts/prepare-shards-release.sh`](./scripts/prepare-shards-release.sh)*)
 
 ## Release preparation
 
@@ -15,14 +15,15 @@ Add an issue `Shards release X.Y.Z` in https://github.com/crystal-lang/distribut
 1. [ ] Finalize the release PR
    * Make sure all changes are mentioned in the changelog
    * Check release date
-   * Build man files with the release date: `$ make clean docs SOURCE_DATE_EPOCH=$(gdate -d "YYYY-MM-DD" +"%s")`
+   * Build man files with the release date: `$ make clean docs SOURCE_DATE_EPOCH=$(gdate -ud "YYYY-MM-DD" +"%s")`
    * Un-draft the PR
 2. [ ] (minor) Split off release branch (`release/x.y`)
 3. [ ] Smoke test with [test-ecosystem](https://github.com/crystal-lang/test-ecosystem)
    * Run [*Test Crystal & Shards Workflow*](https://github.com/crystal-lang/test-ecosystem/actions/workflows/test-crystal-shards.yml) with the release branch as `shards_branch`.
 4. [ ] Merge the release PR
 5. [ ] Tag & annotate the commit with the changelog using v`<M.m.p>` pattern as {version}
-   * `git tag -s -a -m v$VERSION v$VERSION`
+   * `git tag -s -a -m v${VERSION} v${VERSION}`
+   * `git push --tags`
 6. [ ] Publish Github release (https://github.com/crystal-lang/shards/releases/new)
    * Copy the changelog section as description
 7. [ ] Close milestone (https://github.com/crystal-lang/shards/milestones)
@@ -34,7 +35,7 @@ Add an issue `Shards release X.Y.Z` in https://github.com/crystal-lang/distribut
    * Edit [linux/Makefile](../linux/Makefile)
    * Edit [omnibus/config/software/shards.rb](../omnibus/config/software/shards.rb)
 3. [ ] Update https://github.com/crystal-lang/crystal
-   * Edit [`.github/workflows/win.yml`](https://github.com/crystal-lang/crystal/blob/master/.github/workflows/win.yml)
+   * Edit [`.github/workflows/win_build_portable.yml`](https://github.com/crystal-lang/crystal/blob/master/.github/workflows/win_build_portable.yml)
 3. [ ] Submit a PR to update the homebrew formula in https://github.com/Homebrew/homebrew-core/blob/master/Formula/crystal.rb . Or do it on Crystal release.
 4. [ ] Update default base version in test-ecosystem
 6. [ ] (minor) Perform uncomment/todos left in the repo