Update crystal release process (#334)

Author: straight-shoota

packages/obs-release.sh

@@ -56,7 +56,7 @@ sed -i -e "s/^Version: .*/Version: ${VERSION}-1/" *.dsc
 sed -i -e "s/version_suffix .*/version_suffix ${VERSION%.*}/" *.spec
 sed -i -e "s/version_current .*/version_current ${VERSION}/" *.spec
 sed -i -e "s/version_previous .*/version_previous ${previous_version}/" *.spec
-sed -i -e "/%define obsolete_crystal_versioned()/  Obsoletes:      %{1}${previous_version%.*}%{?2:-%{2}} \\\\" *.spec
+sed -i -e "/%define obsolete_crystal_versioned()/ n;iObsoletes:      %{1}${previous_version%.*}%{?2:-%{2}} \\\\" *.spec
 
 sed -i -e "s/^Depends: crystal[^-]*/Depends: crystal${VERSION%.*}/" debian.control
 sed -i -e "s/^Version: .*/Version: ${VERSION%.*}/" debian.control

processes/crystal-release.md

@@ -4,27 +4,27 @@ Add an issue `Crystal release X.Y.Z` in https://github.com/crystal-lang/distribu
 
 ## Release preparation
 
-1. [ ] (minor) Announce expected release date and time span for feature freeze
+1. [ ] (minor) Announce expected release date (${RELEASE_DATE}) and time span for feature freeze (starting on ${FREEZE_PERIOD})
    * (minor) Feature freeze is about two weeks before release
    * (minor) Set date on milestone
 2. [ ] Prepare the changelog entry: [`crystal:scripts/github-changelog.cr`](https://github.com/crystal-lang/crystal/blob/master/scripts/github-changelog.cr)
    * Ensure that all merged PRs are added to the milestone (check [`is:pr is:merged sort:updated-desc no:milestone`](https://github.com/crystal-lang/crystal/pulls?q=is%3Apr+is%3Amerged+sort%3Aupdated-desc+no%3Amilestone+-label%3Astatus%3Areverted+base%3Amaster+merged%3A%3E%3D2023-01-01)).
    * Ensure that all milestoned PRs are properly labelled (check [`is:pr is:merged sort:updated-desc no:label milestone:${VERSION}`](https://github.com/crystal-lang/crystal/pulls?q=is%3Apr+is%3Amerged+sort%3Aupdated-desc+milestone%3A${VERSION}+no%3Alabel)).
 3. [ ] Start preparing release notes
-3. [ ] (minor) Start feature freeze period
+4. [ ] (minor) Start feature freeze period (on ${FREEZE_PERIOD})
    * (minor) Either no merging of features into `master` or split off release branch for backporting bugfixes.
-4. [ ] Publish release PR draft
+5. [ ] Publish release PR draft
    * (minor) It should contain the expected date of the release.
    * It should be populated with updates to `CHANGELOG.md`, `src/VERSION` and the version in `shard.yml`.
-5. [ ] (minor) Ensure documentation for language and compiler changes and other relevant changes is up to date.
+6. [ ] (minor) Ensure documentation for language and compiler changes and other relevant changes is up to date.
    * (minor) [Crystal Book](https://github.com/crystal-lang/crystal-book/)
       * (minor) Update language specification
       * (minor) Update compiler manual
       * (minor) Add or update guides / tutorials?
-6. [ ] Ensure that [test-ecosystem](https://github.com/crystal-lang/test-ecosystem) functions and succeeeds on master
+7. [ ] Ensure that [test-ecosystem](https://github.com/crystal-lang/test-ecosystem) functions and succeeeds on master
    * Run [*Test Crystal & Shards Workflow*](https://github.com/crystal-lang/test-ecosystem/actions/workflows/test-crystal-shards.yml)
 
-## Release process
+## Release process (on ${RELEASE_DATE})
 
 ### Source release
 

processes/scripts/make-crystal-release.sh

@@ -27,7 +27,7 @@ git show
 
 step "Push tag to GitHub" git push --tags
 
-sed -E '3,/^## /!d' CHANGELOG.md | sed '$d' | sed -Ez 's/^\n+//; s/\n+$/\n/g' > CHANGELOG.$VERSION.md
+sed -E '7,/^## /!d' CHANGELOG.md | sed '$d' | sed -Ez 's/^\n+//; s/\n+$/\n/g' > CHANGELOG.$VERSION.md
 
 echo "$ more CHANGELOG.$VERSION.md"
 more CHANGELOG.$VERSION.md

processes/scripts/prepare-crystal-release.sh

@@ -4,19 +4,24 @@
 #
 # Usage:
 #
-#    scripts/prepare-crystal-release.sh VERSION
+#    scripts/prepare-crystal-release.sh VERSION RELEASE_DATE FREEZE_PERIOD
 #
 # The content is generated from Crystal release checklist (../crystal-release.md)
 # with filters applied based on the version type (major, minor, or patch).
 
 set -eu
 
 if [ $# -lt 1 ]; then
-  echo "Usage: $0 VERSION"
-  exit 1
-fi
+  printf "Release version: "
+  read VERSION
 
-VERSION=$1
+  if [ -z "$VERSION" ]; then
+    echo "Usage: $0 VERSION"
+    exit 1
+  fi
+else
+  VERSION=$1
+fi
 
 . $(dirname $(realpath $0))/functions.sh
 
@@ -32,6 +37,19 @@ case $VERSION in
   ;;
 esac
 
+if [ "$TYPE" != "patch" ]; then
+  if [ $# -lt 3 ]; then
+    printf "Scheduled release date: "
+    read RELEASE_DATE
+
+    printf "Freeze period begin: "
+    read FREEZE_PERIOD
+  else
+    RELEASE_DATE=$2
+    FREEZE_PERIOD=$3
+  fi
+fi
+
 dist_scripts_root=$(dirname $(dirname $(dirname $(realpath $0))))
 
 body=$(sed -E '/^##/,$!d' $dist_scripts_root/processes/crystal-release.md)
@@ -48,5 +66,7 @@ case $TYPE in
   ;;
 esac
 
+body=$(echo "$body" | sed -E "s/\\$\{RELEASE_DATE\}/$RELEASE_DATE/g; s/\\$\{FREEZE_PERIOD\}/$FREEZE_PERIOD/g; s/\\$\{VERSION\}/$VERSION/g; s/\\$\{VERSION%\.\*\}/${VERSION%.*}/g")
+
 body=$(printf "%q" "$body")
 step "Create tracking issue in crystal-lang/distribution-scripts" gh issue create -R crystal-lang/distribution-scripts --body "$body" --label "release" --title \"Release Crystal $VERSION\"