single logic for known git providers

Author: bcardiff

src/dependency_definition.cr

@@ -60,24 +60,12 @@ module Shards
         source = value
       end
 
-      if value.starts_with?("https://github.com")
-        resolver_key = "github"
-        uri = URI.parse(value)
+      uri = URI.parse(value)
+      if uri.scheme != "file" && uri.host &&
+         (resolver_key = GitResolver::KNOWN_PROVIDERS[uri.host]?)
         source = uri.path[1..-1].rchop(".git") # drop first "/""
       end
 
-      if value.starts_with?("https://gitlab.com")
-        resolver_key = "gitlab"
-        uri = URI.parse(value)
-        source = uri.path[1..-1].rchop(".git") # drop first "/""
-      end
-
-      if value.starts_with?("https://bitbucket.com")
-        resolver_key = "bitbucket"
-        uri = URI.parse(value)
-        source = uri.path[1..-1] # drop first "/""
-      end
-
       if value.starts_with?("git://")
         resolver_key = "git"
         source = value

src/resolvers/git.cr

@@ -100,15 +100,15 @@ module Shards
       "git"
     end
 
-    private KNOWN_PROVIDERS = {
-      "www.github.com",
-      "github.com",
-      "www.bitbucket.com",
-      "bitbucket.com",
-      "www.gitlab.com",
-      "gitlab.com",
-      "www.codeberg.org",
-      "codeberg.org",
+    KNOWN_PROVIDERS = {
+      "www.github.com"    => "github",
+      "github.com"        => "github",
+      "www.bitbucket.com" => "bitbucket",
+      "bitbucket.com"     => "bitbucket",
+      "www.gitlab.com"    => "gitlab",
+      "gitlab.com"        => "gitlab",
+      "www.codeberg.org"  => "codeberg",
+      "codeberg.org"      => "codeberg",
     }
 
     def self.normalize_key_source(key : String, source : String) : {String, String}
@@ -117,7 +117,7 @@ module Shards
         uri = URI.parse(source)
         downcased_host = uri.host.try &.downcase
         scheme = uri.scheme.try &.downcase
-        if scheme.in?("git", "http", "https") && downcased_host && downcased_host.in?(KNOWN_PROVIDERS)
+        if scheme.in?("git", "http", "https") && downcased_host && downcased_host.in?(KNOWN_PROVIDERS.keys)
           # browsers are requested to enforce HTTP Strict Transport Security
           uri.scheme = "https"
           downcased_path = uri.path.downcase