Fix: Package must return spec at commit when present, then use version

Author: ysbaddaden

src/package.cr

@@ -25,7 +25,7 @@ module Shards
     end
 
     def spec
-      @spec ||= resolver.spec(version)
+      @spec ||= resolver.spec(commit || version)
     end
 
     def installed?

test/integration/install_test.cr

@@ -318,21 +318,38 @@ class InstallCommandTest < Minitest::Test
     end
   end
 
-  def test_installs_executables
+  def test_installs_executables_at_version
     metadata = {
-      dependencies: {
-        binary: {type: "path", path: rel_path(:binary)},
-      },
+      dependencies: {binary: "0.1.0"}
     }
     with_shard(metadata) { run("shards install --no-color") }
 
     foobar = File.join(application_path, "bin", "foobar")
     baz = File.join(application_path, "bin", "baz")
+    foo = File.join(application_path, "bin", "foo")
 
     assert File.exists?(foobar), "Expected to have installed bin/foobar executable"
     assert File.exists?(baz), "Expected to have installed bin/baz executable"
+    refute File.exists?(foo), "Expected not to have installed bin/foo executable"
 
     assert_equal "OK\n", `#{foobar}`
     assert_equal "KO\n", `#{baz}`
   end
+
+  def test_installs_executables_at_refs
+    metadata = {
+      dependencies: {
+        binary: {git: git_url(:binary), commit: git_commits(:binary)[-1]}
+      },
+    }
+    with_shard(metadata) { run("shards install --no-color") }
+
+    foobar = File.join(application_path, "bin", "foobar")
+    baz = File.join(application_path, "bin", "baz")
+    foo = File.join(application_path, "bin", "foo")
+
+    assert File.exists?(foobar), "Expected to have installed bin/foobar executable"
+    assert File.exists?(baz), "Expected to have installed bin/baz executable"
+    refute File.exists?(foo), "Expected not to have installed bin/foo executable"
+  end
 end

test/integration/update_test.cr

@@ -216,21 +216,21 @@ class UpdateCommandTest < Minitest::Test
     end
   end
 
-  def test_installs_executables
-    metadata = {
-      dependencies: {
-        binary: {type: "path", path: rel_path(:binary)},
-      },
-    }
-    with_shard(metadata) { run("shards install --no-color") }
-
-    create_file "binary", "bin/foo", "echo 'FOO'", perm: 0o755
-    create_shard "binary", "name: binary\nversion: 0.2.0\nexecutables:\n  - foobar\n  - baz\n  - foo"
-
-    with_shard(metadata) { run("shards update --no-color") }
+  def test_installs_new_executables
+    metadata = {dependencies: {binary: "0.2.0"}}
+    lock = {binary: "0.1.0"}
+    with_shard(metadata, lock) { run("shards update --no-color") }
 
+    foobar = File.join(application_path, "bin", "foobar")
+    baz = File.join(application_path, "bin", "baz")
     foo = File.join(application_path, "bin", "foo")
+
+    assert File.exists?(foobar), "Expected to have installed bin/foobar executable"
+    assert File.exists?(baz), "Expected to have installed bin/baz executable"
     assert File.exists?(foo), "Expected to have installed bin/foo executable"
+
+    assert_equal "OK\n", `#{foobar}`
+    assert_equal "KO\n", `#{baz}`
     assert_equal "FOO\n", `#{foo}`
   end
 

test/support/factories.cr

@@ -36,6 +36,9 @@ module Shards
           contents = shard.is_a?(String) ? shard : "name: #{project}\nversion: #{version}\n"
           create_shard project, contents
         end
+        Dir.cd(git_path(project)) do
+          run "git add src/#{project}.cr"
+        end
         create_git_commit project, "release: v#{version}"
       end
       create_git_tag(project, "v#{version}")