Skip to content

Commit d6e0a75

Browse files
committed
Remove unused @update_cache class variables
It was meant for the check command, in order to to not fetch remote repositories, but the command was refactored and it's been left unused (since 0938075).
1 parent 4dd6e45 commit d6e0a75

File tree

4 files changed

+9
-13
lines changed

4 files changed

+9
-13
lines changed

src/manager.cr

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -6,8 +6,8 @@ module Shards
66
getter packages : Set
77
property locks : Array(Dependency)?
88

9-
def initialize(@spec, update_cache = true)
10-
@packages = Set.new(update_cache: update_cache)
9+
def initialize(@spec)
10+
@packages = Set.new
1111
end
1212

1313
def resolve

src/package.cr

Lines changed: 3 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@ module Shards
88
@resolver : Resolver?
99
@available_versions : Array(String)?
1010

11-
def initialize(@dependency : Dependency, @update_cache = false)
11+
def initialize(@dependency : Dependency)
1212
@requirements = [] of String
1313
end
1414

@@ -120,7 +120,7 @@ module Shards
120120
end
121121

122122
def resolver
123-
@resolver ||= Shards.find_resolver(@dependency, update_cache: @update_cache)
123+
@resolver ||= Shards.find_resolver(@dependency)
124124
end
125125

126126
private def available_versions
@@ -129,15 +129,11 @@ module Shards
129129
end
130130

131131
class Set < Array(Package)
132-
def initialize(@update_cache = true)
133-
super()
134-
end
135-
136132
def add(dependency)
137133
package = find { |package| package.name == dependency.name }
138134

139135
unless package
140-
package = Package.new(dependency, update_cache: @update_cache)
136+
package = Package.new(dependency)
141137
self << package
142138
end
143139

src/resolvers/git.cr

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -172,7 +172,7 @@ module Shards
172172
@updated_cache = false
173173
end
174174

175-
return if !@update_cache || @updated_cache
175+
return if @updated_cache
176176
Shards.logger.info "Fetching #{git_url}"
177177

178178
if cloned_repository?

src/resolvers/resolver.cr

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@ module Shards
88
abstract class Resolver
99
getter dependency : Dependency
1010

11-
def initialize(@dependency, @update_cache = true)
11+
def initialize(@dependency)
1212
end
1313

1414
def spec(version = nil)
@@ -57,11 +57,11 @@ module Shards
5757
@@resolver_classes[resolver.key] = resolver
5858
end
5959

60-
def self.find_resolver(dependency, update_cache = true)
60+
def self.find_resolver(dependency)
6161
@@resolvers[dependency.name] ||= begin
6262
klass = get_resolver_class(dependency.keys)
6363
raise Error.new("Failed can't resolve dependency #{dependency.name} (unsupported resolver)") unless klass
64-
klass.new(dependency, update_cache: update_cache)
64+
klass.new(dependency)
6565
end
6666
end
6767

0 commit comments

Comments
 (0)