Skip to content

Commit 3045b4c

Browse files
authored
Update to gh super linter 4.9.2 + linters (#252)
This PR cleanup our CI to use a fix version of gh super linter, to avoid breaking the CI on new super linter release. Additionally it update our linters, the new versions: - pylint 2.13.4 - black 22.3.0 - mypy 0.942
1 parent 3e5ea1b commit 3045b4c

File tree

7 files changed

+8
-5
lines changed

7 files changed

+8
-5
lines changed

.github/workflows/black.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,7 @@ jobs:
3333
cp pyproject.toml .github/linters
3434
3535
- name: Black
36-
uses: docker://github/super-linter:v4
36+
uses: github/super-linter/[email protected]
3737
if: always()
3838
env:
3939
# run linter on everything to catch preexisting problems

.github/workflows/linter.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,7 @@ jobs:
3333
cp pyproject.toml .github/linters
3434
3535
- name: Lint everything else
36-
uses: docker://github/super-linter:v4
36+
uses: github/super-linter/[email protected]
3737
if: always()
3838
env:
3939
# run linter on everything to catch preexisting problems

.github/workflows/mypy.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,7 @@ jobs:
3333
cp mypy.ini .github/linters
3434
3535
- name: Mypy
36-
uses: docker://github/super-linter:v4
36+
uses: github/super-linter/[email protected]
3737
if: always()
3838
env:
3939
# run linter on everything to catch preexisting problems

.github/workflows/pylint.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,7 @@ jobs:
3333
cp pyproject.toml .github/linters
3434
3535
- name: Pylint
36-
uses: docker://github/super-linter:v4
36+
uses: github/super-linter/[email protected]
3737
if: always()
3838
env:
3939
# run linter on everything to catch preexisting problems

CONTRIBUTING.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,7 @@ To run them locally:
3535
- `darglint crytic_compile`
3636

3737

38-
We use pylint `2.12.2`, black `21.10b0`, mypy `0.812` and darglint `1.8.0`.
38+
We use pylint `2.13.4`, black `22.3.0`, mypy `0.942` and darglint `1.8.0`.
3939

4040
## Development Environment
4141
Instructions for installing a development version of crytic-compile can be found in our [wiki](https://github.com/crytic/crytic-compile/wiki/Developer-installation).

crytic_compile/platform/solc_standard_json.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -139,6 +139,7 @@ def run_solc_standard_json(
139139
if compiler_version.version:
140140
env["SOLC_VERSION"] = compiler_version.version
141141

142+
stderr = ""
142143
try:
143144

144145
with subprocess.Popen(

crytic_compile/platform/vyper.py

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -146,6 +146,7 @@ def _run_vyper(
146146
cmd = [vyper, filename, "-f", "combined_json"]
147147

148148
additional_kwargs: Dict = {"cwd": working_dir} if working_dir else {}
149+
stderr = ""
149150
try:
150151
with subprocess.Popen(
151152
cmd,
@@ -190,6 +191,7 @@ def _get_vyper_ast(
190191
cmd = [vyper, filename, "-f", "ast"]
191192

192193
additional_kwargs: Dict = {"cwd": working_dir} if working_dir else {}
194+
stderr = ""
193195
try:
194196
with subprocess.Popen(
195197
cmd,

0 commit comments

Comments
 (0)