Skip to content

Commit ec1826a

Browse files
authored
Merge pull request #535 from crytic/fix/windows-3.12-npx
ci: re-enable testing on Windows with Python 3.12
2 parents ad6dedc + 983e2b5 commit ec1826a

File tree

2 files changed

+3
-4
lines changed

2 files changed

+3
-4
lines changed

.github/workflows/ci.yml

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -42,9 +42,6 @@ jobs:
4242
# brownie does not install correctly with Python 3.12
4343
- python: 3.12
4444
type: brownie
45-
# TODO: review failure executing npx on Windows
46-
- os: windows-2022
47-
python: 3.12
4845
steps:
4946
- uses: actions/checkout@v4
5047
- name: Set up shell

setup.py

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,9 @@
1313
author="Trail of Bits",
1414
version="0.3.4",
1515
packages=find_packages(),
16-
python_requires=">=3.8",
16+
# Python 3.12.0 on Windows suffers from https://github.com/python/cpython/issues/109590
17+
# breaking some of our integrations. The issue is fixed in 3.12.1
18+
python_requires=">=3.8,!=3.12.0",
1719
install_requires=["pycryptodome>=3.4.6", "cbor2", "solc-select>=v1.0.4"],
1820
extras_require={
1921
"test": [

0 commit comments

Comments
 (0)